ComGuar
-
Posts
46 -
Joined
-
Last visited
Posts posted by ComGuar
-
-
I agree with fastsol. My rating is 6/10. Worst things on the site is banner on the top and link color in the footer.
-
Problem solved, i wrote function to echo included file.
function echo_inc() { global $data; include "data_file.php"; echo $mydata; } $mydata = $echo_inc();Thanks everyone for helping!
-
Hehe we do not understand each other.
Maybe i need to write function like
$data = get_data('file/i_need_to_include.php'); or something like this.
and
$usersList->set("data", $data);
-
No, i do this this way:
foreach ($users as $user) { $row = new Template("listusers.tpl"); foreach ($user as $key => $value) { $row->set($key, $value); } $usersTemplates[] = $row; } // merge in variable $users_list = Template::merge($usersTemplates); $usersList = new Template("listusers.tpl"); $usersList->set("users", $users_list);And this is working great.
Problem is when i have situation to include file with some data. This included file have sometimes more then 400 lines of code.
-
Thanks for helping me trq.
Can you tell me how to do this without template engine?
Note that html code must be in template files, separated from php code.
-
Now i do not use any template engine.
Whole site is on one template, and all pages have same design, only content is changable.
With template engine, there will be option to have completely different design for some pages + there will be much easier to apply new design when needed. -
Thanks requinix, but i'll try to find other solution.
I have a lot more situations when i need to include file, not only to "show time".
-
Yes, like Trq said.
-
I want to separate the presentation from the business logic, and i wrote a class.
Template engine working like any other.
Example:
page.tpl
<html><body> <div id="content"> {{content}} </div> </body></html>index.php
$content_i_want_to_add = 'yeah, this is my page content'; $content->set('content', $content_i_want_to_add);This part is working great. Problem is when i need to include file on index.php with some data that can be turned on or off. Example:
index.php
$content->set('content', $content_i_want_to_add); if ($show_time == "on") { include"time.php"; } // how to "set" this?time.php
if ($show_time == "on") { echo '<div align="center">' . date("d.m.Y.") . '<br />' . date("H:i") . '</div>'; }This is just example, i have a lot of other, more complex, situations when i need to include a file (echo data that i include).
How to solve this?
Did i must to put all data in variable or there is more "elegant" way?
time.php
if ($show_time == "on") { $time = '<div align="center">' . date("d.m.Y.") . '<br />' . date("H:i") . '</div>'; } -
I like new look, it's great!
-
Thanks Darkfreaks, I will read it.
-
On many servers gpc_magic_quotes are on and I am using stripslashes().
-
Of course, there is htmlspecialchars() and htmlentities().
I use function to check variables and inputs as I mentioned before few posts, and I think it is doing great job.
-
Darkfreaks, this is not my site, please check again.
-
I wrote my function for checking variables, and there is mysql_real_escape_string() in it
-
Thanks!
I am not using PDO. There is no need for mysql_real_replace_string() when using PDO.
-
Thanks, fixed
I removed "antidos" script until tomorrow, so you can scan site with no problems -
There is not too much code on index, only main page parser and some included files.
That is what I need. Tell me where you tried to insert value 1? I need to see error.
I think that error is in your script syntax maybie.
-
They are not, and every table have prefix.
-
It is server side, so you can't see syntax.
In debug mode error reporting is error_reporting(E_ALL), and there is no error.
Everything is working fine.
I will try scripts you suggested.
-
Thanks Darkfreaks!
Please tell me where on website you found error?
I need to know file name and what you did when error happened.
-
Darkfreaks, this is not my robots.txt file!
This file is hosted on goo.gl site.
-
Fixed, thanks Coreye!
-
I added some stuff
Is my website ok, great or fantastic?
in Website Critique
Posted
It looks ok for beginer