Template help

[tom92]

Hey, Ive been working on my own template system that parsers a static html file so it's easier to update. But say if I wanted to create a function that fetches data from mysql or something and replace this with...

 

$tags_array = array('header'=>'<h1>Header</h1>','center'=>MyFunction(),'footer'=>'<h2>Footer</h2>');

 

The output from that function appears at the very top of the page for some reason. Any help please? Thanks.

 

Heres the code i'm using...

 

<?php

function parse_template($template,$tags_array){

$template = file_get_contents($template);

foreach($tags_array as $current_tag => $new_tag){
$template = str_replace("{".$current_tag."}",$new_tag,$template);
}
return $template;
}
$tags_array = array('header'=>'<h1>Header</h1>','footer'=>'<h2>Footer</h2>');

echo parse_template('example_template.html',$tags_array);

?>

[trq]

What does MyFunction() look like?

[tom92]

Something like...

 

while($row = mysql_fetch_array($query)){
echo $row['example'];
}

[trq]

Your function needs to return its data, not echo it.

[tom92]

Thanks it works! Say if i need to return more than 1 lines of data it doesnt seem to work is there any way around this?

[trq]

You would need to return an array.

[tom92]

Okay. I've tried this just to test it out...

 

<?php

$array = array('one','two','three','four','five');
foreach($array as $key => $value){
return $key.$value;
}

?>

 

But it only seems to output the element of the array?

[Eric_Ryk]

Okay. I've tried this just to test it out...

 

<?php

$array = array('one','two','three','four','five');
foreach($array as $key => $value){
return $key.$value;
}

?>

 

But it only seems to output the element of the array?

You have to concatenate all of the values into one string. Then outside of the loop return the finished string.

[tom92]

I'm not trying to be a pain but could u show me an example of how to do this please? Thanks.

[trq]

To assist with a better example, can we see the entire MyFunction() function?

[tom92]

Sure...

 

Say i wanted to display some results from mysql and show how many rows there are...

 

<?php

function MyFunction(){

$query = mysql_query("SELECT * FROM example");

while($row = mysql_fetch_array($query)){
return $row['id'].' - '.$row['name'];
}
return 'There are '.mysql_num_rows($query).' rows in the database.';
}

?>

 

Where would i go from there?

[trq]

I think you need to take another look at what return actually does. This isn't pretty, but its your design.

 

<?php

function MyFunction() {
  if ($result = mysql_query("SELECT id, name FROM example")) {
    if (mysql_num_rows($result)) {
      $return = array();
      $return['num_rows'] = mysql_num_rows($result);
      while ($row = mysql_fetch_array($result)) {
        $return['result'][] = array($row['id'], $row['name']);
      }
      return $return;
    }
  }
  return false;
}

?>

 

And now to call it...

 

<?php

  if ($array = MyFunction()) {
    echo "There are {$array['num_rows']} rows in the database.";
    foreach ($array['result'] as $row) {
      echo $row['id'] . ' - ' . $row['name'];
    }
  }

?>

 

Ive changed your variable names around a little to make them more descriptive. Also, put some error handling in place.

[tom92]

Thanks! works a treat. Is this really the best way to be templating in php is there any other ways you would recommend?

[trq]

I wouldn't bother with any templating, it just adds overhead you don't need.

 

Its easy enough to design your code in such a way that there is only minimal amounts of php mixed in with html.

 

Just my 2 cents though.

[Eric_Ryk]

I wouldn't bother with any templating, it just adds overhead you don't need.

 

Its easy enough to design your code in such a way that there is only minimal amounts of php mixed in with html.

 

Just my 2 cents though.

I'm in agreement with thorpe. Though to add, it's usually like having "template" files that use PHP within them, though only minimally as thorpe stated.

 

ie:

<p>Some static stuff... <b>Hi <?php echo $name; ?></b></p>

 

Typically within these files instead of using if and other control statements with brackets i use the alternate structures.

 

[tom92]

Yeah, I've decided to completley scrap using a templating system after all that lol. I'm simply just going to use a dreamweaver template with some embeded php lol. Like thorpe said I guess templating is just another overhead.

[Liquid Fire]

I wouldn't bother with any templating, it just adds overhead you don't need.

 

Its easy enough to design your code in such a way that there is only minimal amounts of php mixed in with html.

 

Just my 2 cents though.

 

I don't agree with that 100%.  As a programmer I don't see a hugh difference but i know a few designer that perfer a template system then php.  Also if the template system does compiling and caching right, the over head is only on the first call and then it is barely noticeable like Smart/Dwoo(not something like XTemplates which does not compile of cache).