Jump to content


Photo

Suggestions for added features


  • This topic is locked This topic is locked
5 replies to this topic

#1 tomfmason

tomfmason
  • Staff Alumni
  • Advanced Member
  • 1,696 posts
  • Locationstealing your wifi

Posted 13 July 2006 - 07:43 AM

I have writen a contact form that saves the results to a database instead of mailing it. I did this for several reasons. One is the ammount of people that I see asking how to send mail via php and two is a friend of my asked me if I could.

Anyways, I have a test version up and running and would like some suggestions on adding features or possiblely any problems with the script. *Note this is an extreme beta version..lol. But is functional. The only thing that is not functional is the reply script. This is for security reasons.

Here is a link to the script. Please, no comments requarding the generic layout. Please stick to functional criticisms.

http://www.owpt.biz/.../test/inbox.php

Any suggestions would be great.

Traveling East in search of instruction, and West to propagate the knowledge I have had gained.

current projects: pokersource

My Blog | My Pastebin | PHP Validation class | Backtrack linux


#2 Barand

Barand
  • Moderators
  • Sen . ( ile || sei )
  • 18,021 posts

Posted 13 July 2006 - 07:49 AM

Moved to Website Critique
If you are still using mysql_ functions, STOP! Use mysqli_ or PDO. The longer you leave it the more you will have to rewrite.

Donations gratefully received






moon.png

|baaGrid| easy data tables - and more
|baaChart| easy line, column and pie charts

#3 brown2005

brown2005
  • Members
  • PipPipPip
  • Advanced Member
  • 943 posts

Posted 13 July 2006 - 07:51 AM

looks ok, maybe a rollover on the table row, to show wat message your actioning on more easily..

#4 moberemk

moberemk
  • Members
  • PipPipPip
  • Advanced Member
  • 695 posts

Posted 13 July 2006 - 11:49 AM

You know, you might want to (a) move the "message deleted" message inside the <body> tag, and (b) validate your code a bit more. Oh, and maybe style it a little.
Disclaimer: No matter how harsh I may be, I'm always IMO only.

#5 steviewdr

steviewdr
  • Moderators
  • Advanced Member
  • 1,364 posts
  • LocationIreland

Posted 13 July 2006 - 01:05 PM

Buuuuuuggggggyyyyyyyy  :'( I broke it

I got this:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Reilly', 'steve'o@test.com', 'Test "this"', 'Test's and more
tests
and ' at line 2
on
http://www.owpt.biz/home/test/send.php

You dont cancel quotes, and you allow html characters  >:(

Use htmlentities to tidy up and store the values.

Im not sure are quotes allowed in email addresses - but if they are you better plan for them.

Other than that - I do like the concept.
Rgds,
steve

#6 tomfmason

tomfmason
  • Staff Alumni
  • Advanced Member
  • 1,696 posts
  • Locationstealing your wifi

Posted 13 July 2006 - 09:25 PM

Thanks Steve that is exactly what I was looking for. I will fix the bugs and report back

Traveling East in search of instruction, and West to propagate the knowledge I have had gained.

current projects: pokersource

My Blog | My Pastebin | PHP Validation class | Backtrack linux





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users