Jump to content

An issue with renam I think... [Solved]


foreverhex

Recommended Posts

Im in the begining stages of writing an upload script. i want the results page (below) to show the image. Everything seems ok but the image comes out broken and as <img src="/art/1">. 1!!! what? Here is my code.

[code]<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());

$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");

echo 'Your art has been up loaded! <br /> <img src="/art/' . $newfilename . '">';



} else{
    echo "There was an error uploading the file, please try again!";
}
}
?>[/code]
Link to comment
Share on other sites

try that ok
[code]
<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());

$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");

echo "Your art has been up loaded! <br /> <img src= '$target_path . $newfilename '>";



} else{
    echo "There was an error uploading the file, please try again!";
}
}
?>
[/code]
Link to comment
Share on other sites

I had to switch the $newfilename around.
[code]
<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());
rename("$artdir$artnama", "$artdir$randomnum$artnama");

$newfilename = $artdir . $randomnum . $artnama;

echo 'Your art has been up loaded! <br /> <img src="' . $newfilename . '">';


} else{
    echo 'There was an error uploading the file, please try again!';
}
}
?>[/code]Doesnt seem smart but it works.
Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.