crashmaster Posted July 23, 2006 Share Posted July 23, 2006 Hi there...I would like to hear your opinion of GRAPHICAL design not functional side..here you are: [url=http://blacksun.magistri.net]blacksun.magistri.net[/url]Also you can LOG IN : demo | demo Quote Link to comment Share on other sites More sharing options...
moberemk Posted July 24, 2006 Share Posted July 24, 2006 Well, if I WAS critiquing the functional side, I would critique the invalid/deprecated code and tables, as well as the use of images for text. But I'm not. Instead, I'll critique the graphical side of things. Graphically, it's good, and except for the divider to the left and the ugly horizontal rules in the main content, this looks pretty good. Quote Link to comment Share on other sites More sharing options...
wildteen88 Posted July 24, 2006 Share Posted July 24, 2006 Not a bad design, nice and simple. However there is too many images. You dont need images to for your headers, instead you could use the htmlentity of the square character you are using, or remove the little square from your headers, but leave it in for your main header, as the square is making it all cramped together. Your naviagation is made of images, which isn't need instead you could produce the same result with CSS.Your buttons doesnt look very nice either. I would remove the bold text, or pad out the button a bit. Also when you login you should remove the login box and possibly display the users details, or a logout link so the person can logout rather than display the login box all the time. The shopping basket is ok, however I found it hard to get back to my basket once I navigate away from the basket. In the end I found my way to the basket by clicking the [i]hidden[/i] basket link. You should make this link stand out alot more, prehaps underline it/make it bold. As at the moment it looks as though its just normal text and not a link, until you hover over it.I would recommend you to define the font your site should use rather the browsers defualt font (Times New Roman). Prehaps Arial/Vardana style font. You can do this with the following CSS:[code]body, table { font-family: Arial, Verdana; font-size: 12px; background-color: #333333;}[/code]This will then effect all the text on your site. I wouldnt use Arial Black, howver it is fine for your main header, but not the text for your site. Quote Link to comment Share on other sites More sharing options...
steviewdr Posted July 24, 2006 Share Posted July 24, 2006 echo above.You need more mouse over effects for the navigation and the like.Rgds,Steve Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 24, 2006 Author Share Posted July 24, 2006 I want to sorry :) BUt Username and Password I've posted isnt correct.. I was looking to another database :D So If you want you can login there : admin | admin Sorry... :P[quote]Your naviagation is made of images, which isn't need instead you could produce the same result with CSS.[/quote]I am not sure that i understand this sentence... IF I can use CSSS insted of Images...Tell me how : ?To remove square from all images, but not from main [ [square]blacksun] ?? I will try :) But all FUN is that we will sell t-shirts... designs of T-shirts will create I and 2 my friends... And all friends are studying art school, deisgn, interier design..and nobody had never said: Remove thiis squares :D You dont like my self-done buttons ?? If text will not be bold...It will lose in background...and It doesnt like very well...after a few minutes you will fill pain in your eyes..Why dont you like TimeNewRomans??? Quote Link to comment Share on other sites More sharing options...
Gast Posted July 24, 2006 Share Posted July 24, 2006 [quote author=crashmaster link=topic=101603.msg402560#msg402560 date=1153750268]I want to sorry :) BUt Username and Password I've posted isnt correct.. I was looking to another database :D So If you want you can login there : admin | admin Sorry... :P[quote]Your naviagation is made of images, which isn't need instead you could produce the same result with CSS.[/quote]I am not sure that i understand this sentence... IF I can use CSSS insted of Images...Tell me how : ?To remove square from all images, but not from main [ [square]blacksun] ?? I will try :) But all FUN is that we will sell t-shirts... designs of T-shirts will create I and 2 my friends... And all friends are studying art school, deisgn, interier design..and nobody had never said: Remove thiis squares :D You dont like my self-done buttons ?? If text will not be bold...It will lose in background...and It doesnt like very well...after a few minutes you will fill pain in your eyes..Why dont you like TimeNewRomans??? [/quote]It is nice, but like wildteen88 said, you should lose the Times New Roman font. Why? Because it is horrible. You should only really stick to Arial, Verdana, Tahoma or maybe Trebuchet MS. You should also make the left navigation nicer. Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 24, 2006 Author Share Posted July 24, 2006 and 1 more question: why dont you like to use tabs ???or...why does many peoples say that using tabs is so noobish ?? I dont see any BAD side of using TABS.. Maybe coz I've never used <DIV>s :P And If somebody knows , why using DIV is better than TABLES, tell me it...-Konstantin Quote Link to comment Share on other sites More sharing options...
moberemk Posted July 24, 2006 Share Posted July 24, 2006 I'd link you to some articles on the subject, but they seem to be experiencing technical difficulties.All I can say is that the code is easier, the design is more flexible, it makes semantic sense, and it makes your site more accessible to the disabled. Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 24, 2006 Author Share Posted July 24, 2006 ok...any ideas why DIV is Better than TABLE ?? Quote Link to comment Share on other sites More sharing options...
wildteen88 Posted July 24, 2006 Share Posted July 24, 2006 What moberemk said pretty much sums it up.[quote]All I can say is that the code is easier, the design is more flexible, it makes semantic sense, and it makes your site more accessible to the disabled.[/quote]When you use tableless layouts you can reduce the amount of HTML code by probably more than 50%! Which can mean less file sizes and faster page loades. However your stylesheet size will go up.I am trying to find a decent article I found when I was trying to understanding tables vs tableless layouts, I cant find it at the mo. Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 24, 2006 Author Share Posted July 24, 2006 ok...I'd be happy, if you find it and post it here.. Quote Link to comment Share on other sites More sharing options...
moberemk Posted July 24, 2006 Share Posted July 24, 2006 I've got one!http://www.sitepoint.com/article/tables-vs-css Quote Link to comment Share on other sites More sharing options...
steviewdr Posted July 24, 2006 Share Posted July 24, 2006 CSS versus tables in my workds.1. It gives mouse hover effects WITHOUT Javascript.2. It renders HTML and Background Graphics Quicker than table background=""3. All your CSS code is kept in an EXTERNAL Style Sheet. This means that clients when going through your site have the CSS and Styling Code CACHED on their computer -> so all they have to download is JUST the few <div></div> and html tags. 4. If you want to change the colour of then awful standard blue <a href's etc. you can change it in 1 file and the whole site updates 5. You can tell a background image to repeat in the X or Y direction, or both to form a nice gradient full browser width background.and it goes onand on and on....Also - you have mysql errors on your page and I cant login.Rgds,Steve Quote Link to comment Share on other sites More sharing options...
makeshift_theory Posted July 25, 2006 Share Posted July 25, 2006 + css div's load quicker then tables and a lot of companies are transitioning to straight css designs, which you have to use divs for. I work as a web designer and these standards are...forced upon me....makes me cry at night.... :P Quote Link to comment Share on other sites More sharing options...
pixy Posted July 25, 2006 Share Posted July 25, 2006 It's simple...but maybe a little too simple? And I get these errors on the main page:Array ( ) --------------------------------------------------------------------------------Array ( ) --------------------------------------------------------------------------------STATUS is 0REF is LEVEL is Warning: array_keys(): The first argument should be an array in /srv2/www3/magistri.net/subdomains/blacksun/scripts/home.php on line 24Warning: Wrong parameter count for max() in /srv2/www3/magistri.net/subdomains/blacksun/scripts/home.php on line 24NUM_ITEM +1 is 1-------------------------------------------------------------------------------- CLEAR $_S[cart] Quote Link to comment Share on other sites More sharing options...
akitchin Posted July 25, 2006 Share Posted July 25, 2006 when trying to login with demo/demo, i get referred back to this thread. i'd suggest not sending someone back to their referrer if it's not from your site. Quote Link to comment Share on other sites More sharing options...
makeshift_theory Posted July 25, 2006 Share Posted July 25, 2006 He said at the beginning "ignore the functionality." ;D Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 25, 2006 Author Share Posted July 25, 2006 I know..But it isnot Error :P "Home" page is created for showing me, if variable has been setted...For example 1st line: Array is showing me my cookies2nd line: Array is showing me my $_SESSION variable3rd line: STATUS is showing me if I am looged or not4th line: is showing me $_SERVER[referer] variable5th line: Level Is Showing me level of user, logged in... If you will log as main admin your LEVEL will be "2', if you will log as normal user your level is "0"... if you log as moderator your level is 16th line: NUM_ITEM -> look my topic at PHP Questions and Answers '$num++'and 7th line: CLEAR $_S[cart] is link [action] which unsets $_SESSION[cart] variable ... Its so simple :P Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 25, 2006 Author Share Posted July 25, 2006 And logining in..I dont know how do it ...My problem is :whn somebody is shopping..And wants to login, he just lOGIN , but if Logining is OK, it makes refesh to that place where he was before logining....before this script it was that after logining he was refreshed to deafut page for all users...here is my script of logining at the header of index.php [code]session_start();require_once("scripts/auth.inc.php");require_once("mysql.php"); $action = $_GET[action];if ($action == "login") {check_database($_POST[username], $_POST[password]);//this function will return :$db_status = 0 [if user and pass are bad] or db_status = 1 + $db_array [if user and pass are OK] if ($db_status == 1) { set_cookie($db_array,session_id()); //and function set_cookie will setcookie (SESSION, session_id());//also will set $auth_status = 1 }}if ($action == "logout") { $session = $_COOKIE[SESSION]; $q = mysql_query(" DELETE FROM sessions WHERE session = '".$session."' ") or die(mysql_error()); unset($_SESSION[user_id],$_SESSION[username],$_SESSION[user_level]); setcookie('SESSION', '', 0); header("location: index.php");} check_auth($_COOKIE);[/code]in the pace where login form is :[code] if ($auth_status == '1') { logged_menu(); } else { login_page(); }[/code]and at last auth.inc.php: [code]function login_page(){ echo ' <table width="160" align="center" border="0" cellpadding="0"> <form method="post" action="'.$_SERVER['HTTP_REFERER'].'&action=login"> <tr> <td colspan="2"><img src="imgs/menu_login.gif"></td> </tr> <tr> <td width="70"> Username: </td> <td width="90"><input type="text" name="username" size="10" class="login_box"></td> </tr> <tr> <td> Password: </td> <td><input type="password" name="password" size="10" class="login_box"></td> </tr> <tr> <td colspan="2"> <table width="100%" border="0" cellspacing="0" cellpadding="0"> <tr> <td><a href="?page=register"> <img src="imgs/button_register.png" border="0"></a></td> <td align="right"><input type="image" src="imgs/button_login.png" name="login" value="login"> </td> </tr></table> </td> </tr> </form> </table>';} function check_database($username, $password){global $db_status;global $db_array; $query = mysql_query("SELECT user_id, user_level, username FROM users WHERE username = '".$username."' AND password = '".$password."' LIMIT 1"); $db_array = mysql_fetch_array($query); $count = mysql_num_rows($query); if($count == 1) { $db_status = 1; } else { $db_status = 0; } }function check_auth($cookie){ global $auth_status; $session = $cookie[SESSION]; $q = mysql_query(" SELECT user_id, username FROM sessions WHERE session = '".$session."' ") or die(mysql_error()); if (mysql_num_rows($q) == 1) { $r = mysql_fetch_array($q); $_SESSION['user_id'] = $r['user_id']; $_SESSION['username'] = $r['username']; $q2 = mysql_query("SELECT user_level FROM users WHERE user_id = '$r[user_id]'"); $r2 = mysql_fetch_array($q2); $_SESSION['user_level'] = $r2['user_level']; $auth_status = 1; } else { $auth_status = 0; } }function set_cookie($db_array,$session){ setcookie('SESSION', $session, time() + 60*60*24*21); $C = mysql_query(" SELECT * FROM sessions WHERE user_id = '".$db_array[user_id]."' AND username = '".$db_array[username]."' "); if(mysql_num_rows($C) == 0) { $Q = mysql_query(" INSERT INTO sessions (session, user_id, username) VALUES ('".$session."','".$db_array[user_id]."','".$db_array[username]."') "); } else { $Q = mysql_query(" UPDATE sessions SET session = '$session' WHERE user_id = '".$db_array[user_id]."' AND username = '".$db_array[username]."' "); } refresh(0,$_SERVER['HTTP_REFERER']);}function logged_menu(){echo 'Now you are Logged IN';//I've just cutted this part off, coz here is code that shows your user_menu when you are logged in}function fm($String){ return addslashes(strip_tags(trim($String)));}[/code] Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 27, 2006 Author Share Posted July 27, 2006 Hi..I 've just updated my web, now you can try also functional side of the web :P Username: adminpassword: adminAnd...I have a question to designer..Look at the logo..I think, that flower doesnt match to that text, blackSun but there is a flower... I have another logo, but I dont like, whcih is the better one ... look this one : [img]http://www.blacksun.magistri.net/imgs/logo.gif[/img]or this one: [img]http://www.blacksun.magistri.net/imgs/logo2.gif[/img]or do you have any other ideas ??[that blacksun is a real logo of the clothes] Quote Link to comment Share on other sites More sharing options...
cmgmyr Posted July 28, 2006 Share Posted July 28, 2006 I'd make your top links rollovers. I like the logo with the black sun better.-Chris Quote Link to comment Share on other sites More sharing options...
wildteen88 Posted July 28, 2006 Share Posted July 28, 2006 crashmaster I would strongly advise you yo validate user input, especially when they login, as at the moment your site is prone to SQL Injection attacks! I would recommend you to use a function called mysql_real_escape_string() on your $username and $password variables in the check_database function. Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 28, 2006 Author Share Posted July 28, 2006 [quote author=cmgmyr link=topic=101603.msg404840#msg404840 date=1154045636]I'd make your top links rollovers. I like the logo with the black sun better.-Chris[/quote]what does it mean, rollover??\you mean when you mouseover links should change color or somethibng else.. ?? Quote Link to comment Share on other sites More sharing options...
crashmaster Posted July 28, 2006 Author Share Posted July 28, 2006 [quote author=wildteen88 link=topic=101603.msg405042#msg405042 date=1154081502]crashmaster I would strongly advise you yo validate user input, especially when they login, as at the moment your site is prone to SQL Injection attacks! I would recommend you to use a function called mysql_real_escape_string() on your $username and $password variables in the check_database function.[/quote]thanks wildteen..I will imediatly correct it... Quote Link to comment Share on other sites More sharing options...
cmgmyr Posted July 28, 2006 Share Posted July 28, 2006 Yeah, thats what I meant mouseover/image swap.Just to change the color of the text.-Chris Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.