PHP OOP Help

[PdVortex]

Thats wicked and perfectly explained thanks very much appreciate it a lot.

 

One last question for you, is this part necessary?

 

    $cols = implode( ', ', array( FORUM_TOPIC, TID ) );

 

could i not just add the constants directly into the sql line or just the table colum names i need?

something like this

    $sql = "
        SELECT id, topic
        FROM forum_topic 
        WHERE forum_topic.user_id='{$this->userId}' 
        ORDER BY datetime DESC LIMIT 5
    ";

 

Thanks again.

[roopurt18]

Both are equivalent ways of specifying the columns.

 

FYI, when I first started PHP I used constants for my columns and table names.  IMO it's more effort than it's worth and I haven't done that in a loooooooooooong time.

 

I do it like this:

    $sql = "
        SELECT id, topic
        FROM forum_topic 
        WHERE forum_topic.user_id='{$this->userId}' 
        ORDER BY datetime DESC LIMIT 5
    ";

 

I typically write my queries in all lower case as well: select id, topic from forum_topic ...

 

And you should properly enclose your table and column names in the delimiter expected by the database engine:  select `id`, `topic` from `forum_topic` ...

[keldorn]

Where are you getting $this->userId ?

That looks to be  undefined. (by your code)..

 

If you want to do this, you have to convert it to an asscotive array, the loop over it in the html.

 

So

 

function forumTopics() {
   $sql = "SELECT * FROM forum_topic WHERE forum_topic.user_id='".$this->userId."' ORDER BY datetime ASC LIMIT 5";
   $tmp = mysql_query($sql);

   while ($line = mysql_fetch_assoc($tmp)){

        $result[] = $line;

   }
   
// Check if its an array (meaning there is a result)
   if(is_array($result)){

    return $result;    

   } else {
   
     return false;

   }


$Topics = $user->forumTopics($user);

// if returned false, then this will trigger.
if(!$topics){

    // nothing found error
}


// Then loop it

 

[roopurt18]

He could accomplish returning false or an array of results with one change:

 

return count( $FTopics ) === 0 ? false : $FTopics;

[keldorn]

He could accomplish returning false or an array of results with one change:

 

return count( $FTopics ) === 0 ? false : $FTopics;

 

ternary operation ftw.