propper way to white OR

[flemingmike]

hello,

 

here is what i have.  i feel like im close.

 

$result4 = mysql_query("SELECT * FROM schedule WHERE eid = '$posteid' AND status = 1 OR 2");

[jcbones]

$result4 = mysql_query("SELECT * FROM schedule WHERE eid = '$posteid' AND status = 1 OR status = 2");

[flemingmike]

thx man

[jcbones]

NP

[DavidAM]

Shouldn't that be:

$result4 = mysql_query("SELECT * FROM schedule WHERE eid = '$posteid' AND (status = 1 OR status = 2)");

 

Otherwise you get all rows where eid == $posteid AND status == 1

along with the rows where status == 2 (regardless of the value of eid)

[joshd963]

also should the 1 and 2 be in ''

 

ie '1' or '2'

 

 

correct me if im wrong

[DavidAM]

If the status column is numeric, the quotes are not required.  Apparently mySql allows it though, and some people say it is safer.  I'm old school, so I don't put numeric values in quotes.

[jcbones]

You are correct David, it should be in parenthesis.

 

Quotes on INT column is moot, you can use them or not.  It may be a little safer using them, if you security isn't top notch.  Who can really say.