Undefined variable error

[guidance51x]

Hey Everyone. I've been using a piece of code several times before and its worked fine but now (after updating my php version) I get an error.

Heres the code:

 

if(isset($_GET['id']) == TRUE){	
if(is_numeric($_GET['id'])==FALSE) {
	$error = 1;
}
if($error == 1){
	header("Location: " . $config_basedir);
}
else{
	$validentry = $_GET['id'];
}
}
else{
$validentry = 1;
}

 

The line with "if($error == 1){" gets flagged with an error saying:

Notice: Undefined variable: error in C:\xampp\htdocs\sites\smd\index.php on line 8

 

I've used the code before with no problems and uploaded to my web server I also have no errors. What did I do wrong. I hope it isn't a seriously stupid error.

 

Thanks in advance.

[requinix]

Like the message says, it's a notice. That's the lowest level of "error" message that PHP will generate.

 

The problem is that if that second condition (with is_numeric()) isn't true, $error will not be set to 1. Which means PHP doesn't know what $error is supposed to be when you try to test it ==1. For all PHP knows, there's a bug in the code and you forgot to set $error=0 beforehand. Or worse: you forgot to set $error=1 beforehand. PHP will then pretend that $error=null and continue with your code.

 

The solution is simple: set $error=0 somewhere earlier. Like before that second condition. Thus it will always have a value.

[The Letter E]

There's a few ways around this.

 

option 1:

if(isset($_GET['id']) == TRUE){	
if(is_numeric($_GET['id'])==FALSE) {
	$error = 1;
}else{
                $error = 0;
        }
if($error == 1){
	header("Location: " . $config_basedir);
}
else{
	$validentry = $_GET['id'];
}
}
else{
$validentry = 1;
}

 

option 2:

$error = 0;
if(isset($_GET['id']) == TRUE){	
if(is_numeric($_GET['id'])==FALSE) {
	$error = 1;
}
if($error == 1){
	header("Location: " . $config_basedir);
}
else{
	$validentry = $_GET['id'];
}
}
else{
$validentry = 1;
}

 

option 3:

 

if(isset($_GET['id']) == TRUE){	
if(is_numeric($_GET['id'])==FALSE) {
	$error = 1;
}
if(@$error == 1){ //the @ will hide errors for that var, it also works on functions
	header("Location: " . $config_basedir);
}
else{
	$validentry = $_GET['id'];
}
}
else{
$validentry = 1;
}

[Fadion]

You have error_reporting set to E_ALL (default is: E_ALL & ~E_NOTICE). While it is a good idea to show them in a development environment, it's not a good one for a production server. Take a look at this section in the PHP Manual.

[guidance51x]

Thank you everyone for your help. I really appreciate it.