First letter is missing!! Something wrong with my PHP

[Help!php]

I am trying to get a paragraph from a website. Everything works but the first letter is kept on missing. The code shown below is used to get the paragraph. Not sure why the first letter is missing. Please help!!!

 

		if ( isset( $offer[ 0 ] ) )
		{
			// Tidy it up - remove commas and weird Word chars
			$off = strip_tags( $offer[ 0 ] );
			$off = substr( $off, strpos( $off, ";" ) + 1 );
			$off = str_replace("'", "", $off );
			$off = trim( $off );

		}
		else
		{
			$off = "0";
		}

[Pikachu2000]

Is the letter there if you echo the value of $offer[0] before it's passed through all of those string functions?

[ManiacDan]

$off = substr( $off, strpos( $off, ";" ) + 1 );

If there is no ';' in $off, that line will trim the first letter off $off.

 

[Help!php]

Yh it does print the result. But some of the result is printer like

 

I want to get something from a website + I want to get something from a websiteI want to get something from a website

 

First line is splitted with + the other one is not. I ran the code without

 

$off = substr( $off, strpos( $off, ";" ) + 1 );

 

No luck

[Pikachu2000]

How about a sample of actual data, the output you expect from the code, and what you actually get from it?

[Help!php]

Actual data : Free 3 Year On-Site Warranty

 

Output I am expecting is : Free 3 Year On-Site Warranty

 

What I am getting now is : ree 3 Year On-Site Warranty

 

Cheers

[ManiacDan]

That code is definitely the problem, I just ran your code with and without it:

 

php > $offer = array('Free 3 Year On-Site Warranty');
php > 
php > if ( isset( $offer[ 0 ] ) )
php > {
php { $off = strip_tags( $offer[ 0 ] );
php { $off = substr( $off, strpos( $off, ";" ) + 1 );
php { $off = str_replace("'", "", $off );
php { $off = trim( $off );
php { } else {
php { $off = "0";
php { }
php > 
php > echo $off;
ree 3 Year On-Site Warranty
php > 
php > 
php > 
php > $offer = array('Free 3 Year On-Site Warranty');
php > 
php > if ( isset( $offer[ 0 ] ) )
php > {
php { $off = strip_tags( $offer[ 0 ] );
php { //$off = substr( $off, strpos( $off, ";" ) + 1 );
php { $off = str_replace("'", "", $off );
php { $off = trim( $off );
php { } else {
php { $off = "0";
php { }
php > 
php > echo $off;
Free 3 Year On-Site Warranty

See?

[Pikachu2000]

EDIT: Composing while Dan was posting, apparently . . .

 

It seems to be exactly what ManiacDan said it was. If there is no semicolon, the first letter is stripped, so check for the presence of a semicolon before allowing the substr() function.

 

// Tidy it up - remove commas and weird Word chars
$off = strip_tags( $offer[0] );
//$off = substr( $off, strpos( $off, ";" ) + 1 ); COMMENTED OUT THIS LINE
$off = strpos($off, ';') !== FALSE ? substr( $off, strpos( $off, ";" ) + 1 ) : $off;  // ADDED THIS LINE
$off = str_replace("'", "", $off );
$off = trim( $off );

[ManiacDan]

Pika, you may be interested to learn that the && can be used as a quick shorthand IF:

 

strpos($off, ';') !== FALSE && $off = substr( $off, strpos( $off, ";" ) + 1 );

It's sloppy and perl-like and will cause any code reviewers to punch you, but it's valid.  I think it's fun.

 

[Pikachu2000]

I've never seen it used that way. It would be my luck that I'd use it and the forget what it does. Then I'd be punching myself later. Again.

[ManiacDan]

You totally shouldn't do it...but you could.

 

You should have seen my face when I was trying to debug a perl module and realized that the window was too narrow to show me the "unless" clauses off on the right side of the lines.  I was so confused.

[Pikachu2000]

I can picture that happening. Hell, it's happened to me here, with the horizontal scrolling in the divs that the php and code tags sometimes cause.

[sasa]

Pika, you may be interested to learn that the && can be used as a quick shorthand IF:

 

strpos($off, ';') !== FALSE && $off = substr( $off, strpos( $off, ";" ) + 1 );

It's sloppy and perl-like and will cause any code reviewers to punch you, but it's valid.  I think it's fun.

 

you can use or too

strpos($off, ';') == FALSE || $off = substr( $off, strpos( $off, ";" ) + 1 );

[ManiacDan]

We have to stop giving this poor girl such horrible ideas.

[Help!php]

Thank you very much for your help!

 

That would a girl. Cheers.