Register Script

[Robiedick]

The following code doesn't work can someone please help me out?

 

<?php 
// Connects to your Database 

mysql_connect("db.xxxxxx.org", "xxxxxx", "xxxxxx") or die(mysql_error()); 

mysql_select_db("md212730db240041") or die(mysql_error()); 


//This code runs if the form has been submitted

if (isset($_POST['submit'])) { 



//This makes sure they did not leave any fields blank

if (!$_POST['username'] | !$_POST['pass'] | !$_POST['pass2'] ) {

  die('You did not complete all of the required fields');

 }



// checks if the username is in use

 if (!get_magic_quotes_gpc()) {

  $_POST['username'] = addslashes($_POST['username']);

 }

$usercheck = $_POST['username'];

$check = mysql_query("SELECT username FROM users WHERE username = '$usercheck'") 

or die(mysql_error());

$check2 = mysql_num_rows($check);



//if the name exists it gives an error

if ($check2 != 0) {

  die('Sorry, the username '.$_POST['username'].' is already in use.');

 }


// this makes sure both passwords entered match

 if ($_POST['pass'] != $_POST['pass2']) {

  die('Your passwords did not match. ');

 }



 // here we encrypt the password and add slashes if needed

 $_POST['pass'] = md5($_POST['pass']);

 if (!get_magic_quotes_gpc()) {

  $_POST['pass'] = addslashes($_POST['pass']);

  $_POST['username'] = addslashes($_POST['username']);

   }



// now we insert it into the database

 $insert = "INSERT INTO users (username, password)

   VALUES ('".$_POST['username']."', '".$_POST['pass']."')";


 $add_member = mysql_query($insert);
?>

 

It returns this error:

 

Parse error: syntax error, unexpected $end in /public/sites/build2.mccity.org/Register.php on line 237

 

Thanks alot on forhand.

[PFMaBiSmAd]

Here's the error message in a readable font (you cannot edit your post without messing up the posted code) -

 

Parse error: syntax error, unexpected $end in /public/sites/build2.mccity.org/Register.php on line 237

[Pikachu2000]

That error usually means there's a missing closing curly brace or semicolon. Aside from that, that code is years out of date, and should be updated before being used in the real world.

[Christian F.]

Yeah... That's the kind of code I haven't seen for almost 12 years now, that's how out of date (and insecure) it is.

As such I strongly recommend that you read this article about secure login systems. It'll teach you how to write a modern, and properly secure, user registration/login system. Even provides you with most of the code you need, so that you don't have to write all of the really complex stuff yourself (if you don't want to).