Jump to content

Register form


Metoriium

Recommended Posts

Sorry for many posts, trying to make my website

 

When I press the register button on my website it will just act as if the page is refreshing and not send any information to mysql

I believe I have connected everything up correctly, can anyone tell my what I have done wrong please?

 

If you want to check out the website to see what is going on check out www.jokestary.comli.com

<?php


//This function will display the registration form

function register_form(){


$date = date('D, M, Y');

echo "<form action='?act=register' method='post'>"

."Username: <input type='text' name='username' size='30'><br>"

."Password: <input type='password' name='password' size='30'><br>"

."Confirm your password: <input type='password' name='password_conf' size='30'><br>"

."Email: <input type='text' name='email' size='30'><br>"

."<input type='hidden' name='date' value='$date'>"

."<input type='submit' value='Register'>"

."</form>";


}


//This function will register users data

function register(){


//Connecting to database

include('connect.php');

if(!$connect){

die(mysql_error());

}


//Selecting database

$select_db = mysql_select_db("database", $connect);

if(!$select_db){

die(mysql_error());

}


//Collecting info

$username = $_REQUEST['username'];

$password = $_REQUEST['password'];

$pass_conf = $_REQUEST['password_conf'];

$email = $_REQUEST['email'];

$date = $_REQUEST['date'];


//Here we will check do we have all inputs filled


if(empty($username)){

die("Please enter your username!<br>");

}


if(empty($password)){

die("Please enter your password!<br>");

}


if(empty($pass_conf)){

die("Please confirm your password!<br>");

}


if(empty($email)){

die("Please enter your email!");

}


//Let's check if this username is already in use


$user_check = mysql_query("SELECT username FROM users WHERE username='$username'");

$do_user_check = mysql_num_rows($user_check);


//Now if email is already in use


$email_check = mysql_query("SELECT email FROM users WHERE email='$email'");

$do_email_check = mysql_num_rows($email_check);


//Now display errors


if($do_user_check > 0){

die("Username is already in use!<br>");

}


if($do_email_check > 0){

die("Email is already in use!");

}


//Now let's check does passwords match


if($password != $pass_conf){

die("Passwords don't match!");

}



//If everything is okay let's register this user


$insert = mysql_query("INSERT INTO users (username, password, email) VALUES ('$username', '$password', '$email')");

if(!$insert){

die("There's little problem: ".mysql_error());

}


echo $username.", you are now registered. Thank you!<br><a href=login.php>Login</a> | <a href=index.php>Index</a>";


}


switch($act){


default;

register_form();

break;


case "register";

register();

break;


}


?> 

Here is the connect.php code

<?php
$hostname="mysql6.000webhost.com"; //local server name default localhost
$username="a5347792_users";  //mysql username default is root.
$password="";       //blank if no password is set for mysql.
$database="a5347792_users";  //database name which you created
$con=mysql_connect($hostname,$username,$password);
if(! $con)
{
die('Connection Failed'.mysql_error());
}
 
mysql_select_db($database,$con);
?>
Link to comment
Share on other sites

That setup is very unorganized.  It would take too much time looking back and forth to see what's happening in your code.

 

1: Indent your code.  It's so hard to read.

2: Functions should be kept in a separate file.

3: Instead of using switch functions that just call functions, why not just layout your registration?

<?php
 
// Process registration
 
?>
<html>
<head>
    <title>Registration</title>
</head>
<body>

    <!-- Just put your form here -->
 
</body>
</html>

My guess would be these lines here:

 

 

if(!$connect){

die(mysql_error());

}

$connect is not set in your connection.php

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.