Jump to content

Null Safe Operator


NotionCommotion
Go to solution Solved by requinix,

Recommended Posts

The following four methods were changed.  The first three seem to be correct but not sure about the last one (hasPhysicalMedia).  Agree?  Best way to fix is just type casting the returned value?  Thanks

 

     public function getPhysicalMedia(): ?PhysicalMedia
     {
-        return $this->activeMedia?$this->activeMedia->getPhysicalMedia():null;
+        return $this->activeMedia?->getPhysicalMedia();
     }

     public function getMediaType(): ?MediaType
     {
-        return $this->activeMedia?$this->activeMedia->getMediaType():null;
+        return $this->activeMedia?->getMediaType();
     }

     public function getFilename(): ?string
     {
-        return $this->activeMedia?$this->activeMedia->getFilename():null;
+        return $this->activeMedia?->getFilename();
     }

     public function hasPhysicalMedia(): bool
     {
-        return $this->activeMedia && $this->activeMedia->hasPhysicalMedia();
+        return $this->activeMedia?->hasPhysicalMedia();
     }
class ActiveMedia
{
    public function getPhysicalMedia(): PhysicalMedia
    {
        return $this->physicalMedia;
    }

    public function getMediaType(): ?MediaType
    {
        return $this->mediaType;
    }

    public function getFilename(): ?string
    {
        return $this->filename;
    }

    public function hasPhysicalMedia(): bool
    {
        return (bool) $this->physicalMedia;
    }
}

 

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.