Jump to content

Data not being inserted into table


phppup

Recommended Posts

I am trying to insert from a form into a table with an auto increment primary id and a default TIMESTAMP
 

$sql = "INSERT INTO $table (a,b,c,TIMESTAMP) VALUES (NULL, ?,?,?,? )";

if($stmt = mysqli_prepare($conn, $sql)){
    mysqli_stmt_bind_param($stmt, 'ssss', $w,$x,$y,$z);

mysqli_stmt_execute($stmt);

echo "Records inserted.<br>";
} else{
    echo "ERROR". mysqli_error($conn);;

$last_id = mysqli_insert_id($conn);
    echo "Last inserted ID is: " . $last_id;

I have eliminated all ERRORS that indicated
Warning: mysqli_stmt::bind_param(): Number of elements in type definition string doesn't match number of bind variables

However, I am still receiving the same code generated message

Records inserted.
Last inserted ID is: 0

No data is visible when I open the actual database and view the table.

Link to comment
Share on other sites

I am trying to insert from a form into a table with an auto increment primary id and a default TIMESTAMP

$sql = "INSERT INTO $table (a,b,c,TIMESTAMP) VALUES ( ?,?,?,? )";

if($stmt = mysqli_prepare($conn, $sql)){
    mysqli_stmt_bind_param($stmt, 'ssss', $w,$x,$y,$z);

mysqli_stmt_execute($stmt);

echo "Records inserted.<br>";
} else{
    echo "ERROR". mysqli_error($conn);;

$last_id = mysqli_insert_id($conn);
    echo "Last inserted ID is: " . $last_id;

I have eliminated all ERRORS that indicated
Warning: mysqli_stmt::bind_param(): Number of elements in type definition string doesn't match number of bind variables

However, I am still receiving the same code generated message

Records inserted.
Last inserted ID is: 0

No data is visible when I open the actual database and view the table.

 

@ginerjm Actually made that correction after the posting, but same issue persists. But thanks.

PS: checked all db connectivity and everything seems to be fine from that side.

 

Edited by phppup
forgot item
Link to comment
Share on other sites

you need error handling for ALL the database statements that can fail - connection, query, prepare, and execute. you currently don't have any error handling for the execute call, which would be telling you why the query is failing at execution time.

the easiest way of adding error handling for all the database statements, without adding logic at each one, is to use exceptions for errors and in most cases simply let php catch and handle the exception, where php will use its error related settings to control what happens with the actual error information (database statement errors will 'automatically' get displayed/logged the same as php errors.) this will allow you to remove the existing error handling logic, since it will no longer get executed upon an error. the exception to this rule is when inserting/updating duplicate or out of range user submitted data. in this case, you would catch the exception in your code, test if the error number is for something that your code is designed to handle,  and setup a unique and helpful error message letting the visitor know what was wrong with the data that they submitted. for all other error numbers, just rethrow the exception and let php handle it.

to enable exceptions for errors for the mysqli extension, add the following line of code before the point where you make the database connection, and remove the existing error handling logic you have now -

mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);

 

Link to comment
Share on other sites

You added error handling for the db function calls but you should leave in the php error handling to point out syntax errors in your code until you move it into production.  And I don't think you need the display startup errors setting if you are not actually Starting Php itself.

Basically:

error_reporting(E_ALL);
ini_set('display_errors', '1');

Reset the 2nd line to '0' when you are not in development.

Link to comment
Share on other sites

@ginerjm Stalled as in the top of the page loaded perfectly, but other PHP lines that I had an echo'ed output during development (ie: print_r or echoes from a function) simply did not display beyond a certain point; as if the code simply stalled or derailed; froze or died.

Note that while it did seem suspicious, I have reviewed my code and none of these items seems like it should interfere with an INSERT statement or the table, as they are unrelated.  I'm not entirely sure of the effects of MYSQLI_REPORT_STRICT, and really don't have the time to investigate them.

Link to comment
Share on other sites

19 minutes ago, phppup said:

Stalled as in the top of the page loaded perfectly, but other PHP lines that I had an echo'ed output during development (ie: print_r or echoes from a function) simply did not display beyond a certain point; as if the code simply stalled or derailed; froze or died.

Have a look at the page source and see if there are any error messages.

Link to comment
Share on other sites

UPDATE:  Took a troubleshooting approach to this and managed to obtain an INSERT using a good 'ole fashioned SELECT statement WITHOUT any binding or prepared statements.

I suppose that indicates that, as stated, all connectivity is valid.

Now I'll move forward and count my commas, quotes, and variables to try to get to the full resolution.

Unless there are more suggestions, I'll just say THANKS for everyone's help.

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.