Nolongerused3921 Posted February 7, 2007 Share Posted February 7, 2007 I have spent the past month and a half writing well over 15,000 lines of code to get my new site up and running... And, well - I need reviews. Here it is: http://www.eyesoute.com/ I would like reviews on every aspect... The functionality, what you think it's missing, what's broken, and so on. Link to comment Share on other sites More sharing options...
The Black Death Posted February 8, 2007 Share Posted February 8, 2007 I think it's very impressive, I'm currently in the middle of creating my own CMS, I would like to ask for your help, if you don't mind, I have made a post in the help forum, please reply if you would be kind enough to help :-\. Link to comment Share on other sites More sharing options...
kaz_64 Posted February 12, 2007 Share Posted February 12, 2007 A very nice system, I received no php errors so I have no advice for you there only a small bit of design advice: you should probably remove the (comming eventually) for your download of the day untill you get it running. A neat way I do it is i set a constant for every system i have (true for operational, false for not) and that way you can say if(__DL_DAY__) echo "foobar" (or what ever you wish to name your constant) and it you want to get even more fancy you can set the constant based on a value from your database on a side note you could use variable in the same way but the nice thing about constants is that once they are set at the execution of your script is that they cannot be modified for the rest of the execution... i find this useful because there's no accidentally changing a variable the could give you an error else where on your page Link to comment Share on other sites More sharing options...
Daniel0 Posted February 12, 2007 Share Posted February 12, 2007 There is a difference between the beta test board and the website review board. If you just want critique for your site it belongs in the review board. I just noticed one thing: "Time elapsed: 0.042178869247437 seconds - Queries (9)" - the end-user does not care about it, and s/he probably doesn't know what it means anyways. For the navigation: I was expecting them to be buttons instead of links, but I had to move my cursor "all the way" to the actual text instead of being able to click the button. Link to comment Share on other sites More sharing options...
TreeNode Posted February 12, 2007 Share Posted February 12, 2007 I noticed there was a lack of padding (spacing) throughout. The + (plus) signs on the navigation labeled sections made me think I could minimize them. The links on the navigation could use the style- display: block; width: 100%; ...so that the link stretches the rectangle. Before you're done, you should remove all of those comments left in the html and clean up the javascript. Can't help too much on the PHP side unless I saw the source. Looks like you're doing a good job seperating out the sections but you have everything setup with the "view-#"... wondering how you went about this. Thanks, hope this helps! Link to comment Share on other sites More sharing options...
newb Posted February 14, 2007 Share Posted February 14, 2007 "Time elapsed: 0.042178869247437 seconds - Queries (9) meh ive always wondered what code shows that information...anybody can pls tell me i would appreciate it. Link to comment Share on other sites More sharing options...
agentsteal Posted March 4, 2007 Share Posted March 4, 2007 Cross Site Scripting: http://www.eyesoute.com/search?"><marquee><h1>vulnerable</marquee> Link to comment Share on other sites More sharing options...
Nolongerused3921 Posted March 4, 2007 Author Share Posted March 4, 2007 Thanks for pointing that out... I don't really have that much experience with XSS, but I suppose a simple regex could fix that. Link to comment Share on other sites More sharing options...
mattd8752 Posted March 10, 2007 Share Posted March 10, 2007 The forums last posts, they just don't seem to blend in. The only way I knew they were newest posts, not sections/categories is because I recognized the link URL. Other than that, mooth and nice. Link to comment Share on other sites More sharing options...
Recommended Posts