Hit counter help

[avatar.alex]

ok I don't want the page counter to recount the page each time me or anyone else roloads it or goes it it I just want one count per person could anyone help me out

 

heres the code thank you:

 

<?php
//-----------------------------------------------//
//---------------Simple Logger-------------------//
//-----------------------------------------------//
// This code is (c) to TheSavior (Eli White) as  //
// of 2005-2006. This code may NOT be reproduced //
// ,or                                           //
// distributed by any means, unless you have     //
// explicit written permissions by TheSavior     //
//-----------------------------------------------//
// You may edit this file as you wish, as long   //
// as it isn't redistributed after words.        //
// Free support is provided for all scripts on   //
// http://www.thesavior.co.nr                    //
//-----------------------------------------------//
// I hope you enjoy this script, now get to the  //
// fun part of looking at how it works! Its a    //
// joy. XD                                       //
//-----------------------------------------------//

//----------------------------------------------
// Log files with permissions to write
//----------------------------------------------
$log = "logger.txt";
$file = "users.txt";

//----------------------------------------------
// Get our variables for future use
//----------------------------------------------
$today = getdate();
$month = $today[month];
$mday = $today[mday];
$year = $today[year];
$date = $mday . $month . $year;
$remote = $_SERVER["REMOTE_ADDR"];
$timeoutsecs = 900;
$timestamp = time();
$timeout = ($timestamp-$timeoutsecs);
$online = fopen("$file", "a+");
$write = $remote."||".$timestamp."n";

//----------------------------------------------
// Write to our logfile
//----------------------------------------------
$fp = fopen($log, "a");
$line = "|" . $mday . $month . $year . "\n";
$size = strlen($line);
fputs($fp, $line, $size);
fclose($fp);

$contents = file($log);
$total_hits = count($contents);

//----------------------------------------------
// Formmating for daily_hits_size
//----------------------------------------------
$daily_hits = array();
for ($i=0;$i<count($contents);$i++) {
$entry = explode("|", $contents[$i]);
if ($date == rtrim($entry[1])) {
	array_push($daily_hits, $entry[0]);
}
}
$daily_hits_size = count($daily_hits);

//----------------------------------------------
// Users Online
//----------------------------------------------
fwrite($online, $write);
fclose($online);
$online_array = array();
$file_array = file($file);
foreach($file_array as $newdata)
{
list($ip, $time) = explode("||", $newdata);
if($time >= $timeout){
array_push($online_array, $ip);
}
}
$online_array = array_unique($online_array);
$online = 1+ count($online_array);

//----------------------------------------------
// Echo our stats to the page
//----------------------------------------------

echo 

"<span class=\"stats\">Page hits:<strong>" . $total_hits . "</strong><br />
Todays Page hits: <strong>" . $daily_hits_size . "</strong><br />
Users Online: <strong>" . $online . "</strong><br /></span>
"
?>

[nikkieijpen]

Two ways:

 

1. you can count unique visits by IP addresses. If an IP address is already logged, don't log it.

2. use sessions. If a visit is being logged, set a session variable to 'logged' (or whatever you like). Don't log a visit when the session has that value.

[avatar.alex]

where or how would I add that into the script

[clown[NOR]]

i just finished a project like that earlier today... this logs the IP's visiting your site

 

<?php
   function countIP()
   {
       $ip = $_SERVER['REMOTE_ADDR'];
       $chkIP = checkIP($ip);
       if (!$chkIP) {
           $write = $ip."\n";
           $fh = fopen('filename.txt', 'a+');
           fwrite($fh, $write);
           fclose($fh);
           return calcIP();
       } else {
           return calcIP();
       }
   }    

   function checkIP($ip)
   {
       $lines = file('filename.txt');
       foreach ($lines as $line) {
           if (trim($line) == $ip)
               return true;
       }
   }

   function calcIP()
   {
       $lines = file('filename.txt');
       $i = 1;
       foreach ($lines as $line) {
           $i++;
       }
       return $i-1;
   }
?>

 

edit it to your needs and wherever you want the counter just add this

<?php echo countIP(); ?>

 

EDIT: WTF happened to the code?!

[avatar.alex]

thanks what functions would I use if I just wanted to count how many people were on today

[clown[NOR]]

there's 2 ways to do that...

 

1. Make a new file for every day.

2. When today is over you clear the file and start over..

 

with option 1 you can keep track of visits and make visitor statistics

with option 2 you dont end up having hundreds of files

[avatar.alex]

thats cool well i think i got it but how would I add it so the it logs the ip address...

 

/
// Log files with permissions to write
$log = "logger.txt";
$file = "users.txt";


// Get our variables for future use
$today = getdate();
$month = $today[month];
$mday = $today[mday];
$year = $today[year];
$date = $mday . $month . $year;
$remote = $_SERVER["REMOTE_ADDR"];
$timeoutsecs = 900;
$timestamp = time();
$timeout = ($timestamp-$timeoutsecs);
$online = fopen("$file", "a+");
$write = $remote."||".$timestamp."n";


// Write to our logfile
$fp = fopen($log, "a");
$line = "|" . $mday . $month . $year . "\n";
$size = strlen($line);
fputs($fp, $line, $size);
fclose($fp);

$contents = file($log);
$total_hits = count($contents);


// Formmating for daily_hits_size
$daily_hits = array();
for ($i=0;$i<count($contents);$i++) {
$entry = explode("|", $contents[$i]);
if ($date == rtrim($entry[1])) {
	array_push($daily_hits, $entry[0]);
}
}
$daily_hits_size = count($daily_hits);

[clown[NOR]]

in the script you're using.. the users IP address is stored into $remote ... just write the value of $remote to a text file

[avatar.alex]

Im looking through these two scripts and trying to put them together but im kinda stuck on where to put the parts....I think that I would take the

function checkIP($ip)

and change the $ip it $log but im not sure?

 

<?
function countIP()
    {
        $ip = $_SERVER['REMOTE_ADDR'];
        $chkIP = checkIP($ip);
        if (!$chkIP) {
            $write = $ip."\n";
            $fh = fopen('filename.txt', 'a+');
            fwrite($fh, $write);
            fclose($fh);
            return calcIP();
        } else {
            return calcIP();
        }
    }    
    
    function checkIP($ip)
    {

// Log files with permissions to write
$log = "logger.txt";
$file = "users.txt";


// Get our variables for future use
$today = getdate();
$month = $today[month];
$mday = $today[mday];
$year = $today[year];
$date = $mday . $month . $year;
$remote = $_SERVER["REMOTE_ADDR"];
$timeoutsecs = 900;
$timestamp = time();
$timeout = ($timestamp-$timeoutsecs);
$online = fopen("$file", "a+");
$write = $remote."||".$timestamp."n";


// Write to our logfile
$fp = fopen($log, "a");
$line = "|" . $mday . $month . $year . "\n";
$size = strlen($line);
fputs($fp, $line, $size);
fclose($fp);

$contents = file($log);
$total_hits = count($contents);


// Formmating for daily_hits_size
$daily_hits = array();
for ($i=0;$i<count($contents);$i++) {
$entry = explode("|", $contents[$i]);
if ($date == rtrim($entry[1])) {
	array_push($daily_hits, $entry[0]);

}
}
$daily_hits_size = count($daily_hits);

[clown[NOR]]

no... $ip in the checkIP function is storing the users IP address so it can look for it in the textfile the IP's are saved to

[avatar.alex]

ok let me try again sorry kinda sorta new to the whole php thing lol

[clown[NOR]]

but it looks like the script you have allready stores the IPs... so there's no need for you to try make my script and the one you allready have work together

[avatar.alex]

no but when ever I refresh the page it adds one to the counter so I just want it so it only counts one person at a time not so it counts everytime I refreash the page.

[clown[NOR]]

well.. you have to add something like this

$chkIP = checkIP($remote);

 

before the section where the users IP address get's written to the file

 

then when the script is about to write the IP you run an IF statement to see if the IP was found or not.

if (!$chkIP) {
make the script add the IP
}

[avatar.alex]

ok I did it right I think but it says that there is a error on line 45 which is the line with the

 

 

$chkIP = checkIP($remote);

 

$log = "logger.txt";
$file = "users.txt";


// Get our variables for future use
$today = getdate();
$month = $today[month];
$mday = $today[mday];
$year = $today[year];
$date = $mday . $month . $year;
$remote = $_SERVER["REMOTE_ADDR"];
$timeoutsecs = 900;
$timestamp = time();
$timeout = ($timestamp-$timeoutsecs);
$online = fopen("$file", "a+");
$write = $remote."||".$timestamp."n";


// Write to our logfile

$chkIP = checkIP($remote);

if (!$chkIP) {


$fp = fopen($log, "a");
$line = "|" . $mday . $month . $year . "\n";
$size = strlen($line);
fputs($fp, $line, $size);
fclose($fp);

$contents = file($log);
$total_hits = count($contents);
}

// Formmating for daily_hits_size
$daily_hits = array();
for ($i=0;$i<count($contents);$i++) {
$entry = explode("|", $contents[$i]);
if ($date == rtrim($entry[1])) {
	array_push($daily_hits, $entry[0]);
}

[john010117]

What exactly is the error message?

[avatar.alex]

Fatal error: Call to undefined function: checkip() in /home/mystrh00/domains/witchin.net/public_html/blog/logger.php on line 45

[avatar.alex]

does anyone know why the error is like that

[clown[NOR]]

it cant find the function checkIP()

[avatar.alex]

did I do something wrong

[clown[NOR]]

well.. since you're getting an error message i would belive you did but can you post the whole code?

[avatar.alex]

<?php
//-----------------------------------------------//
//---------------Simple Logger-------------------//
//-----------------------------------------------//
// This code is (c) to TheSavior (Eli White) as  //
// of 2005-2006. This code may NOT be reproduced //
// ,or                                           //
// distributed by any means, unless you have     //
// explicit written permissions by TheSavior     //
//-----------------------------------------------//
// You may edit this file as you wish, as long   //
// as it isn't redistributed after words.        //
// Free support is provided for all scripts on   //
// http://www.thesavior.co.nr                    //
//-----------------------------------------------//
// I hope you enjoy this script, now get to the  //
// fun part of looking at how it works! Its a    //
// joy. XD                                       //
//-----------------------------------------------//

//----------------------------------------------
// Log files with permissions to write
//----------------------------------------------
$log = "logger.txt";
$file = "users.txt";

//----------------------------------------------
// Get our variables for future use
//----------------------------------------------
$today = getdate();
$month = $today[month];
$mday = $today[mday];
$year = $today[year];
$date = $mday . $month . $year;
$remote = $_SERVER["REMOTE_ADDR"];
$timeoutsecs = 900;
$timestamp = time();
$timeout = ($timestamp-$timeoutsecs);
$online = fopen("$file", "a+");
$write = $remote."||".$timestamp."n";

//----------------------------------------------
// Write to our logfile
//----------------------------------------------
$chkIP = checkIP($remote);

if (!$chkIP) {

$fp = fopen($log, "a");
$line = "|" . $mday . $month . $year . "\n";
$size = strlen($line);
fputs($fp, $line, $size);
fclose($fp);

$contents = file($log);
$total_hits = count($contents);
}
//----------------------------------------------
// Formmating for daily_hits_size
//----------------------------------------------
$daily_hits = array();
for ($i=0;$i<count($contents);$i++) {
$entry = explode("|", $contents[$i]);
if ($date == rtrim($entry[1])) {
	array_push($daily_hits, $entry[0]);
}
}
$daily_hits_size = count($daily_hits);

//----------------------------------------------
// Users Online
//----------------------------------------------
fwrite($online, $write);
fclose($online);
$online_array = array();
$file_array = file($file);
foreach($file_array as $newdata)
{
list($ip, $time) = explode("||", $newdata);
if($time >= $timeout){
array_push($online_array, $ip);
}
}
$online_array = array_unique($online_array);
$online = 1+ count($online_array);

//----------------------------------------------
// Echo our stats to the page
//----------------------------------------------

echo 

"<span class=\"stats\">Page hits:<strong>" . $total_hits . "</strong><br />
Todays Page hits: <strong>" . $daily_hits_size . "</strong><br />
Users Online: <strong>" . $online . "</strong><br /></span>
"
?>

[dj-kenpo]

it wants the function checkIP. you don't seem to have that function there, hence this is incomplete code (unless I'm blind. which I sometimes am).

 

 

can anyone comment, is storing hits in a textfile MUCH slower than an sql database? I would assume by alot!

 

also, keep in mind, people at offices/colleges many times use shared IP. therefore, if 30 people in an office look at your site and you filter by IP, you will get an very, very incorrect count. it's better to use sessions.

[avatar.alex]

ok so how would I use sessions in this one

[clown[NOR]]

you cant use the checkIP() function I gave you unless you add the function into the script... so just copy, paste and modify it and it should be working