______This code is REALLY simple...why isn't it working?______

[lotrfan]

elseif ($positional_sum == "6") {
if ($number_of_angles == "1"){
echo "This triangle is SAS";}
elseif ($number_of_angles == "3") {
echo "This triangle is AAA.";}
	if (empty($side[0])){
	$side[0] = (sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0])));}}

 

"Parse error: syntax error, unexpected '}' in C:\Program Files\Apache Group\Apache2\htdocs\hypotenuse.php on line 172"

 

Thanks in Advance.

[cooldude832]

and what is line 172?

[lotrfan]

elseif ($positional_sum == "6") {
if ($number_of_angles == "1"){
echo "This triangle is SAS";}
elseif ($number_of_angles == "3") {
echo "This triangle is AAA.";}
	if (empty($side[0])){
	$side[0] = (sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0])));}}

 

The last line here (beginning with 'if(empty($side[0]))....etc') is line 172.

[cooldude832]

well it can't be because it doesn't have a } in it

[lotrfan]

Really? Because there are 2 '}' in that line...

 

I don't understand...

 

The line is long so it wraps down to the next "line space" down, but it is still one line.

[cooldude832]

it must be because its cut.  any way i found it in line 173 of what it appears

$side[0] = (sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0]))));}

 

u missed a ), but that isn't simple that is ugly.

[jd2007]

u added a bracket at the last line before sqrt which caused the error:

 

replace :

 

$side[0] = (sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0])));}}

 

with this:

 

<?php
$side[0] = sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0])));}}
?>

[lotrfan]

Oh, OK. I didn't know that the 'sqrt' function couldn't have a parentheses in front of it...

 

And, yes, it is kind of ugly, but there is no other way to execute that kind of an operation...is there?

[jd2007]

another thing, please make sure your code is readable and properly indented like this :

 

<?php
elseif ($positional_sum == "6")
{
if ($number_of_angles == "1")
{
  echo "This triangle is SAS";
}
elseif ($number_of_angles == "3")
{
  echo "This triangle is AAA.";
}

if (empty($side[0]))
{
  $side[0] = sqrt((($side[1]*$side[1])+($side[2]*$side[2]))-(2*$side[1]*$side[2]*cos($angle[0])));
}
}
?>

 

isn't it better now, readability is important in coding...

[lotrfan]

Thanks. I'm new to PHP, so I really hadn't tried to get it clean like that, but it does help.

 

Thanks for the quick response. Kudos to both of you for your help.

[cooldude832]

no but if you doing math why not make a function p_theory

<?php
function p_theory($a,$b,$theda,$type){
//Angle is in radians
if($type == 1){
$theda = $theda;
}
//Angle is in degrees
else{
$theda = deg2rad($theda);
}
$value = sqrt(
				(pow($a,2)+pow($b,2))-
				(2*$a*$b*cos($theda))
			);
return $value;
}
?>

Makes sense? then its repeatable on other pages

[lotrfan]

Well, I was just trying to use the Law Of Cosines. I don't exactly understand what you're trying to explain. Is it to allow inputs in both degrees and radians? Because that would be helpful. Are PHP values automatically radians? I'm very sorry if these are dumb questions -- I just started PHP about a month ago. I'm loving it, but it's still a new thing for me.

 

Thanks once again...