a faster way?

[blueman378]

hi guys i have this script:

echo "<b>4) Select your game file</b><br>";
//Looks into the directory and returns the files, no subdirectories
echo "<select name='gamefiles'>";
//The path to the style directory
$dirpath = "../games_uins/";
$dh = opendir($dirpath);
while (false !== ($file = readdir($dh))) {
//Don't list subdirectories
if (!is_dir("$dirpath/$file")) {
//Truncate the file extension and capitalize the first letter
echo "<option value='$file'>" . htmlspecialchars(ucfirst(preg_replace('/\..*$/', '', $file))) . '</option>';
}
}
closedir($dh);
//Close Select
echo "</select>";
echo "<br><br>";
echo "<b>5) Select your thumbnail file</b><br>";
//Looks into the directory and returns the files, no subdirectories
echo "<select name='thumbfiles'>";
//The path to the style directory
$dirpath = "../thumbs_uins/";
$dh = opendir($dirpath);
while (false !== ($file = readdir($dh))) {
//Don't list subdirectories
if (!is_dir("$dirpath/$file")) {
//Truncate the file extension and capitalize the first letter
echo "<option value='$file'>" . htmlspecialchars(ucfirst(preg_replace('/\..*$/', '', $file))) . '</option>';
}
}
closedir($dh);
//Close Select
echo "</select><br><br>"; 

 

basically what it does is it reads the files in a directory, removes the extension, and then lists it in a dropdown box,

 

my question is is there a faster way as it takes about 30-40 seconds to complete this (if not it may sut be because it is listing nearly 1000 files,

 

thanks

[BillyBoB]

I dont know how much faster this is but this is the way i would do it.

 

<?php
echo("
<form method=\"POST\">
");
$dir = './pics/';
$handle = opendir($dir);

while (($file = readdir($handle)) !== false)
{
if ( !in_array($file, array('.', '..') ) )
{
	$file_list[] = basename($file, '.jpg'); 
}
}

closedir($handle);

asort($file_list);
echo ("
<center><form method=\"POST\">Select:<select name=\"pic\">
");
foreach($file_list as $key => $value){
echo ("
<option>$value</option>
");
} 
echo("
</select>
<input type=\"submit\" name=\"submit\" value=\"View Pic\" />
</form></center>
");
?>

 

Edit as needed.

[btherl]

30-40 seconds for 1000 files seems too slow .. can you give more information about the system this is running on?  Which OS? and is there any other load?

 

You might also want to try glob()

 

According to the user comments though, opendir() is usually faster than glob()

[blueman378]

running on home computer/ laptop

win xp

 

the laptop is not slow ( 756 ram 2.8 cpu)

also this is my personal computer, so it has the normal load but even if i shut off everything else the time does not change.

 

but i thought it was slow too, but could you give me a example of what you mean?

 

thanks

 

and i made a mistake before so here:

echo "<b>4) Select your game file</b><br>";
//Looks into the directory and returns the files, no subdirectories
echo "<select name='gamefiles'>";
//The path to the style directory
$dirpath = "../games_uins/";
$dh = opendir($dirpath);
while (false !== ($file = readdir($dh))) {
//Don't list subdirectories
if (!is_dir("$dirpath/$file")) {
//Truncate the file extension and capitalize the first letter
echo "<option value='$file'>" . htmlspecialchars(ucfirst(preg_replace('/\..*$/', '', $file))) . '</option>';
}
}
closedir($dh);
//Close Select
echo "</select>";

[blueman378]

how much would the preg replace slow it down?

because that is helpful

but not completely necessary

 

 

thanks

[blueman378]

well i figured it out, the thing that was slowing it down was the

if (!is_dir("$dirpath/$file")) {

 

once i removed that it gets filled within a second,

 

but now i have one more strange problem, now i get two blank entries in the drop down box any ideas?

[blueman378]

ah they are not blank:

<option value='.'></option>
<option value='..'></option>

 

any ideas?

[JacobYaYa]

Just do an if($file != '..' || $file != '.')){}