thewooleymammoth
-
Posts
768 -
Joined
-
Last visited
Never
Posts posted by thewooleymammoth
-
-
You may need to be a bit more specific on what you mean?
-
I would need to see the page/code.
-
I havn't ever actually used that function, but from what i read here
http://php.net/manual/en/mysqli-stmt.bind-result.php
it looks like you would be ok to not check them. I would recommend just taking out the checks and trying it out with values (or lack of values) that you know may screw it up.
i must have been tired when i wrote that. If you're worried about security i would check to make sure it is set. isset doesnt take up a ton of resources. Unless you have a server thats about to explode i really wouldnt worry about a couple extra checks.
-
Maybe add more features on the sides, too much white space...
Just my opinion.
Its a little plain
-
ok well then that seems good as far as checking if those things exist.
-
what are you doing with the errors array if there is an error? If you just want to declare that there was an error the array may not be necessary.
<?php $error = ""; if(!isset($_POST['comment'])) $error = "No comment was entered. <br />"; if (!isset($_SESSION['articleID'])) $error .= "There was no article ID. <br />" if (!isset($_SESSION['memberID'])) $error .= "There was no member ID. <br />" if(strlen(error) > 0){ echo $error; //handle the error here. }else //add the comment. ?> -
It seems ok. It kind of depends on what your doing exactly.
-
Im not sure i understand your question, but if you already have the values you want in a variable and don't want the user to change them, then there is no reason to populate a form with them. Just use the values you have.
-
also why are you causing it to sleep for 2 seconds? that doesn't seem like a very efficient idea.
-
so when you perform a blank search, you want it to fetch all the results from your database and its only returning one result?
-
http://w3schools.com/php/default.asp
I dont think there is anything wrong with that code. I would make sure your knowledge of basic php is up to snuff. If that is not runnign right you might have to post more of the code so i can see what else is going on that could be screwing it up.
-
I havn't ever actually used that function, but from what i read here
http://php.net/manual/en/mysqli-stmt.bind-result.php
it looks like you would be ok to not check them. I would recommend just taking out the checks and trying it out with values (or lack of values) that you know may screw it up.
-
I think this is what your looking for...
<?php if ($News_1_Status=="Y"){ ?>//removed echo and added this. <div class="newstitle" align="left"><?php echo $News_1_Date;?> <a href="<?php echo $News_1_URL;?>"><?php echo $News_1_Name;?></a></div><br>; <?php }else echo "Have a nice day!"; ?> -
the register works, and i can move places? i think? a map would be good. Also, You could really benefit from some css in the main area. playing kind of reminds me of reading server logs. Seems like it's a decent start though, just got to keep plugging away.
-
well make sure you fixed that sql injection vulnerability, because otherwise someone could walk off with your database. And i assume you don't want to end up (ryan)weekly in the papers like sony does
btw are you using:
action="<?php echo $_SERVER['PHP_SELF'];?>"
in your forms?
right now some forms are vulnerable for cross side scripting. Have a read here how to prevent it: http://seancoates.com/blogs/xss-woes
If you want to post to the same page your at,
action='' //or action='?this=works&also='
[/code] is all you need. Problem solved.
-
using regex on your form input and mysql_real_escape_string() takes out almost all sql injections. Someone has got to be pretty clever to get through that. It also fixes your verification issues.
-
If you want media rich look with less media, i would go with a darker background like adobe does. You could also get jquery and jquery plugins for some animation/interactivity. They can be relatively nice and light. One well done interactive image would look better anyways.
I would also get rid of all those images. Images are whats gonna take up most of your bandwidth. If you want to show off your images i would use small thumbnails and only use big images if they ask for them.
-
Interesting, It's working great for me from a coffee shop and through a vpn in switzerland. Is it still timing out for you?
Also i added some ajax loading, if anyone feels like critiquing that feel free.
-
That blue header on the phone, which says "inTouch" does not match the rest of the site, its close, but not quite. if you go blue, choose a blue from the background image.
I don't think that the text in the main text area should be black, I think it would be nice if it was a blue close to the color of the blue behind the font, and add a drop shadow to it of a dark blue.
remove most the text and place it on a sub page, pick out 1 or 2 main features of the app and advertise that on the main page, with a link to more features on the sub page.
Take a look at:
- Twitter
- jQuery
- Netflix
- cakePHP
- Gmail
- ect.
If you notice, they only list a few of the features on their main page, it makes you browse the site a little more.
Thats all I can really think of. But I think it looks really good so far!
Good suggestions, I'll play with the text colors, however, the blue behind the words intouch is a specific hex color that matches the color in the app. Once i get the demo of the app and maybe some screenshots you will be able to see. Ill give this thread a little bump when that happens. I've been putting a ton of time into the app, I suppose it's about time to start working on the website again.
If any of you have ever dealt with trying to start a social networking type site, I was hoping for some advice on content that would tempt people to share it on facebook or wherever. I was thinking of making a funny flash animation (Youtube) that could possible spread like wildfire (hopefully). But thats my best idea so far.
As you know, the more people who use it the more it will snowball. The hard part is getting the ball rolling.
-
I totally agree with the above comments, they have been added to my list of things to do. Thanks!
-
-
I made an android app for a class, Hopefully it gets big, but to help it out i made a website
The content is not alltogether yet, so take it easy on what the pages say. More the actual design im looking to have critiqued.
intouchapp.net
-
The one i use, and which is supposed to be most readable is ariel/helvetica.
-
Text is hard to read, and it's pretty dark. Kinda makes me feel sad inside, other than that, looks ok. I would also change the font.
960.gs has a good system, and it resets your default text font / size to a much better font.
Celbre - My Website
in Website Critique
Posted
I have no idea what this site does, Why is it different than other blogging sites? a sample username/login would be nice.