[SOLVED] Code improvements/ suggestions?

[darkfreaks]

i was wondering if there was anything that i could possibly  include or change in the following 2 pages of code besides a database connect which i will code later.

 

 

Form.php

 

<p><b><fontsize=10><font color=black>Perverted Panda Order Form</font></b></p><br><br>
<form method="post" action="<?php echo $PHP_SELF; ?>">
<p><b><font color=red>Customer Info</font></b></p>
First Name:<input type=text name=fname>
Last Name:<input type=text name=lname>
Email:<input type=text name=email>
Phone:<input type=text name=phone>
Sex:<select name=sex><option value=male>male</option><option value=female>female</option></select>
<p><b><font color=red>Customize Your Corset</font></b></p>
Front Opening Busk:<select name=q1><option value=yes>yes</option><option value=no>no</option></select>
Eyelet Color:<select name=q2><option value=silver>silver</option><option value=gold>gold</option><option value=other>other</option></select>
Lace Color:<select name=q3><option value=black>black</option><option value=white>white</option><option value=other>other</option></select>
Extra Custimization?:<select name=q4><option value=yes>yes</option><option value=no>no</option></select>
Measurements:<select name=unit><option value=inches>inches</option><option value=centimeters>centimeters</option></select>
1.)<input type=text name=m1>
2.)<input type=text name=m2>
3.)<input type=text name=m3>
4.)<input type=text name=m4>
5.)<input type=text name=m5>
6.)<input type=text name=m6>
7.)<input type=text name=m7>
8.)<input type=text name=mate>
9.)<input type=text name=m9>
10.)<input type=text name=m10>
11.)<input type=text name=m11>
<p><b><font color=red>Order Information</font></b></p>
Style Purchased:<select name=q5><option value=Overbust Victorian>Overbust Victorian</option><option value=Underbust Victorian>Underbust Victorian</option>
<option value=Cincher>Cincher</option><option value=Elizibethian>Elizibethian</option></select>
Have you worn a corset before?:<select name=q6><option value=yes>yes</option><option value=no>no</option></select>
Do you intend to tightlace?:<select name=q7><option value=yes>yes</option><option value=no>no</option></select>
Is this corset for everyday wear?:<select name=q8><option value=yes>yes</option><option value=no>no</option></select>
Is this corset for a special occasion?:<select name=q9><option value=yes>yes</option><option value=no>no</option></select>
Why do you want a corset?:<input type=text name=corset>
<input type=submit name=submit Value=submit>
</form>

<?php
$fname=strip_tags(trim(mysql_real_escape_string($_POST['fname'])));
$lname=strip_tags(trim(mysql_real_escape_string($_POST['lname'])));
$email=$_POST['email'];
$phone=strip_tags(trim(mysql_real_escape_string($_POST['phone'])));
$m1=strip_tags(trim(mysql_real_escape_string($_POST['m1'])));
$m2=strip_tags(trim(mysql_real_escape_string($_POST['m2'])));
$m3=strip_tags(trim(mysql_real_escape_string($_POST['m3'])));
$m4=strip_tags(trim(mysql_real_escape_string($_POST['m4'])));
$m5=strip_tags(trim(mysql_real_escape_string($_POST['m5'])));
$m6=strip_tags(trim(mysql_real_escape_string($_POST['m6'])));
$m7=strip_tags(trim(mysql_real_escape_string($_POST['m7'])));
$mate=strip_tags(trim(mysql_real_escape_string($_POST['mate'])));
$m9=strip_tags(trim(mysql_real_escape_string($_POST['m9'])));
$m10=strip_tags(trim(mysql_real_escape_string($_POST['m10'])));
$m11=strip_tags(trim(mysql_real_escape_string($_POST['m11'])));
$sex=strip_tags(trim(mysql_real_escape_string($_POST['sex'])));
$q1=strip_tags(trim(mysql_real_escape_string($_POST['q1'])));
$q2=strip_tags(trim(mysql_real_escape_string($_POST['q2'])));
$q3=strip_tags(trim(mysql_real_escape_string($_POST['q3'])));
$q4=strip_tags(trim(mysql_real_escape_string($_POST['q4'])));
$q5=strip_tags(trim(mysql_real_escape_string($_POST['q5'])));
$q6=strip_tags(trim(mysql_real_escape_string($_POST['q6'])));
$q7=strip_tags(trim(mysql_real_escape_string($_POST['q7'])));
$q8=strip_tags(trim(mysql_real_escape_string($_POST['q8'])));
$q9=strip_tags(trim(mysql_real_escape_string($_POST['q9'])));
$unit=strip_tags(trim(mysql_real_escape_string($_POST['unit'])));
$corset=strip_tags(trim(mysql_real_escape_string($_POST['corset'])));
if(empty($_POST['submit'])||!isset($_POST['submit'])) {
?>

<p><b><fontsize=10><font color=black>Perverted Panda Order Form</font></b></p><br><br>
<form method="post" action="<?php echo $PHP_SELF; ?>">
<p><b><font color=red>Customer Info</font></b></p>
First Name:<input type=text name=fname>
Last Name:<input type=text name=lname>
Email:<input type=text name=email>
Phone:<input type=text name=phone>
Sex:<select name=sex><option value=male>male</option><option value=female>female</option></select>
<p><b><font color=red>Customize Your Corset</font></b></p>
Front Opening Busk:<select name=q1><option value=yes>yes</option><option value=no>no</option></select>
Eyelet Color:<select name=q2><option value=silver>silver</option><option value=gold>gold</option><option value=other>other</option></select>
Lace Color:<select name=q3><option value=black>black</option><option value=white>white</option><option value=other>other</option></select>
Extra Custimization?:<select name=q4><option value=yes>yes</option><option value=no>no</option></select>
Measurements:<select name=unit><option value=inches>inches</option><option value=centimeters>centimeters</option></select>
1.)<input type=text name=m1>
2.)<input type=text name=m2>
3.)<input type=text name=m3>
4.)<input type=text name=m4>
5.)<input type=text name=m5>
6.)<input type=text name=m6>
7.)<input type=text name=m7>
8.)<input type=text name=mate>
9.)<input type=text name=m9>
10.)<input type=text name=m10>
11.)<input type=text name=m11>
<p><b><font color=red>Order Information</font></b></p>
Style Purchased:<select name=q5><option value=Overbust Victorian>Overbust Victorian</option><option value=Underbust Victorian>Underbust Victorian</option>
<option value=Cincher>Cincher</option><option value=Elizibethian>Elizibethian</option></select>
Have you worn a corset before?:<select name=q6><option value=yes>yes</option><option value=no>no</option></select>
Do you intend to tightlace?:<select name=q7><option value=yes>yes</option><option value=no>no</option></select>
Is this corset for everyday wear?:<select name=q8><option value=yes>yes</option><option value=no>no</option></select>
Is this corset for a special occasion?:<select name=q9><option value=yes>yes</option><option value=no>no</option></select>
Why do you want a corset?:<input type=text name=corset>
<input type=submit name=submit Value=submit>
</form>
<?php
        }else{
$sql=mysql_query("INSERT INTO customers (fname,lname,email,phone,m1,m2,m3,m4,m5,m6,m7,mate,m9,m10,m11,sex,q1,q2,q3,q4,q5,q6,unit,q7,q8,q9,corset) VALUES ($fname,$lname,$email,$phone,$m1,$m2,$m3,$m4,$m5,$m6,$m7,$mate,$m9
	,$m10,$m11,$sex,$q1,$q2,$q3,$q4,$q5,$q6,$unit,$q7,$q8,$q9,$corset)");

echo "Thank You for shopping at Perverted Perverts!";}
?>

 

view_order.php

 

<?php
$result=mysql_query("SELECT FROM customers");
while($row=mysql_fetch_array($result)) {
echo "<table><tr><td><b><font csize=10>Customer Information</font></b></td></tr>
<tr><td>First Name:"$row['fname']"</td><td> Last Name:"$row['lname']"</td><td> Email:"$row['email']"
</td><td> Phone:"$row['phone']" </td><td>"$row['sex']"</td></tr>
<tr><td><b><font size=10>Corset Measurements</font></b></td></tr>
<tr><td>)"$row['unit']" </td></tr>
<tr><td>1.)"$row['m1']" </td><td>2.)"$row['m2']"</td><td>3.)"$row['m3']"</td><td>4.)"$row['m4']"</td>
<td>5.)"$row['m5']"</td><td>6.)"$row['m6']"</td><td>7.)"$row['m7']"</td>8.)"$row['mate']"</td><td>
9.)"$row['m9']"</td><td>10.)"$row['m10']"</td><td>11.)"$row['m11']"</td></tr>
<tr><td><b><font size=10>Corset Questions</font></b></td></tr>
<tr><td>Front Opening Busk?"$row['q1']" </td></tr>
<tr><td>Eyelet Color?"$row['q2']" </td></tr>
<tr><td>Lace Color?"$row['q3']" </td></tr>
<tr><td>Extra Customization?"$row['q4']" </td></tr>
<tr><td>Style Ordered:"$row['q5']" </td></tr>
<tr><td>Have you worn a corset before?"$row['q6']" </td></tr>
<tr><td>Do you intend to tightlace?"$row['q7']" </td></tr>
<tr><td>is  this corset for everyday wear?"$row['q8']" </td></tr>
<tr><td>is  this corset for special occasions ?"$row['q9']" </td></tr>
<tr><td>Why do you want a corset?"$row['corset']" </td></tr>
</table>";
}
?>

 

[conker87]

Well, you need to add dots before and after all of the variables in view_order.php

 

And can I ask something... 'Perverted Pandas'? lol.

 

Other than some formatting issues, like the huge echo you have there, replace it with just normal HTML and use <?php echo $row['name']; ?> etc.

[darkfreaks]

lol its for a client