Double Inseting?

[a1amattyj]

Hello,

 

For some reason, my code will submit the data i input, but it will also input a second field for no reason with the ID auto increments +1 from the real query.

 

 

if($_GET['act'] == 'add'){

$name = $_POST['name'];
$type = $_POST['type'];
$email = $_POST['email'];

$q = "INSERT INTO `{$db_prfix}help` ( `name` , `type` , `email` ) VALUES ('$name', '$type', '$email')";
$rs = mysql_query($q) or die(mysql_error());

echo "<h1>Add Help Staff</h1>";
echo "Added '$name' to the help system.";
echo "<br /><br />";
echo '<form action="support.php" method="post"><input type="submit" value="Go Back"></form>';

}

 

From phpmyadmin..

 

INSERT INTO `help` VALUES(25, '', '', '');
INSERT INTO `help` VALUES(24, 'jkjhk', 'hjgh', 'gjjhj');
INSERT INTO `help` VALUES(23, '', '', '');
INSERT INTO `help` VALUES(22, 'admin', 'user', '[email protected] ');

 

 

Ta

[jaymc]

Seems pretty clean what you have posted

 

What are the conditions before

 

if($_GET['act'] == 'add'){

 

As it looks like it is being called twice

 

Maybe best to post all the php in this instance

 

Make sure your not calling $rs anywhere in your script, not sure why you have assigned the mysql_query() to a var anyway, could be the root issue

[a1amattyj]

Whole code:

 

<?
require('header.php'); 

if(!$_GET){
?>

<h1>Support Team</h1>
This is a list of the support team which are listed on your home page under the support section. You may delete or add new support members here. You can view the
support team on your main page <a href="../support.php">here</a>.
<br /><br />

<table width="98%" border="0" cellspacing="1" cellpadding="1">

<tr>
<td><b>Name</b></td>
<td><b>Type</b></td>
<td><b>Email</b></td>
<td><b>Delete</b></td>
</tr>

<?
$query = "select * from {$db_prfix}help";
$result = mysql_query($query);

if (mysql_num_rows($result) !=0)
{
    while($row = mysql_fetch_array($result))
    {
        extract($row);

echo "<tr>
<td><a href=\"profile.php?id=$name\">$name</a></td>
<td>$type</td>
<td>$email</td>";
echo '<td><form action="support.php?act=del&name='.$name.'" method="post"><input type="submit" value="Delete"></form></td>';
echo "
</tr>";

} 
}
?>

<form action="support.php?act=add" method="post">
<tr>
<td><input type='text' name='name'></td>
<td><input type='text' name='type'></td>
<td><input type='text' name='email'</td>
<td><input type="submit" name="Submit" value="Add"></td>
</tr>


</table>

<br> This will not make a user be able to enter the Admin Panel it will just add their name to the staff page list which
can be found <a href="../support.php">here</a>. 





<?

}

if($_GET['act'] == 'del'){
$supportname = $_REQUEST['name'];
?>

<script language=javascript1.1>
var answer = confirm("Confirm Delete")
if (answer){
}
else{
	alert("NOT DELETED!")
	window.location = "support.php";
}
</script>
<?

echo "<h1>Delete Staff</h1>";
echo "Deleted '$supportname' from the help system.";
echo "<br /><br />";
echo '<form action="support.php" method="post"><input type="submit" value="Go Back"></form>';

$sql = "DELETE FROM `{$db_prfix}help` WHERE name = '$supportname'";
$result = mysql_query($sql) or die(mysql_error());


}



if($_GET['act'] == 'add'){

$name = $_POST['name'];
$type = $_POST['type'];
$email = $_POST['email'];

$q = "INSERT INTO `{$db_prfix}help` ( `name` , `type` , `email` ) VALUES ('$name', '$type', '$email')";
$rs = mysql_query($q) or die(mysql_error());

echo "<h1>Add Help Staff</h1>";
echo "Added '$name' to the help system.";
echo "<br /><br />";
echo '<form action="support.php" method="post"><input type="submit" value="Go Back"></form>';



}
require("footer.php");
?>

 

Thanks!

[beansandsausages]

try this :

 

in your querry

$q = "INSERT INTO `{$db_prfix}help` ( `name` , `type` , `email` ) VALUES ('$name', '$type', '$email')";

 

take the space out before `name`

[a1amattyj]

try this :

 

in your querry

$q = "INSERT INTO `{$db_prfix}help` ( `name` , `type` , `email` ) VALUES ('$name', '$type', '$email')";

 

take the space out before `name`

 

Still does it.

 

Thanks!

[beansandsausages]

you tried taking the space after email as well?

[a1amattyj]

you tried taking the space after email as well?

 

Yeah :

 

 

if($_GET['act'] == 'add'){

$name2 = $_POST['name'];
$type2 = $_POST['type'];
$email2 = $_POST['email'];


$q = "INSERT INTO `{$db_prfix}help` (`name`,`type`,`email`) VALUES ('$name2','$type2','$email2')";
$rs = mysql_query($q) or die(mysql_error());

echo "<h1>Add Help Staff</h1>";
echo "Added '$name2' to the help system.";
echo "<br /><br />";
echo '<form action="support.php" method="post"><input type="submit" value="Go Back"></form>';



}

 

I really have no idea why.

[beansandsausages]

okay giz 10min ill take a look on my localhost.

[beansandsausages]

try this :

 

if($_GET['act'] == 'add'){

$name2 = $_POST['name'];
$type2 = $_POST['type'];
$email2 = $_POST['email'];


mysql_query("INSERT INTO `{$db_prifix}help` (`name2`,`type2`,`email2`) VALUES ('{$name}','{$type2}', '{$email2}') ") or die(mysql_error());  


echo "<h1>Add Help Staff</h1>";
echo "Added '$name2' to the help system.";
echo "<br /><br />";
echo '<form action="support.php" method="post"><input type="submit" value="Go Back"></form>';



}

 

the values mayneed changing

[a1amattyj]

mysql_query("INSERT INTO `{$db_prifix}help` (`name`,`type`,`email`) VALUES ('{$name2}','{$type2}', '{$email2}') ") or die(mysql_error());  

 

BTW thanks for your time!

 

but nope, it still does it

[a1amattyj]

Fixed:

 

$name = $_POST['name'];
$type = $_POST['type'];
$email = $_POST['email'];
if ($name != ""){
?>
<?
        $q = "INSERT INTO `{$db_prfix}help` ( `name` , `type` , `email` ) VALUES (
'$name', '$type', '$email')";
        $rs = mysql_query($q) or die     ("Could not execute query : $q." . mysql_error());


if ($rs){
echo "Support Added";
}
}

 

Thanks