Jump to content

help with simple regex function


gammaman

Recommended Posts

Why does thid function always evaluate to true? Based on what is being passed to the function, false should be returned.

 

<?php

  function test($var)
  {

    $pattern='^[A-Z][0-5]{3}$';

    $x=ereg($pattern,$var);

  }

  $value="1323";

  test($value);

  if($value==true){
     echo "value is true";
  }else{
     echo "false";
  }
?>

Link to comment
Share on other sites

First, your function isn't returning anything. Second, you are testing the value of $value, not the return value. Your code should look like:

<?php
  function test($var)
  {
    $pattern='^[A-Z][0-5]{3}$';
    return ereg($pattern,$var);
  }

  $value="1323";
  $result = test($value);
  if($result){ //The == true is not needed
     echo "value is true";
  }else{
     echo "false";
  }
?>

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.