Jump to content

help with simple regex function


gammaman

Recommended Posts

Why does thid function always evaluate to true? Based on what is being passed to the function, false should be returned.

 

<?php

  function test($var)
  {

    $pattern='^[A-Z][0-5]{3}$';

    $x=ereg($pattern,$var);

  }

  $value="1323";

  test($value);

  if($value==true){
     echo "value is true";
  }else{
     echo "false";
  }
?>

Link to comment
https://forums.phpfreaks.com/topic/105414-help-with-simple-regex-function/
Share on other sites

First, your function isn't returning anything. Second, you are testing the value of $value, not the return value. Your code should look like:

<?php
  function test($var)
  {
    $pattern='^[A-Z][0-5]{3}$';
    return ereg($pattern,$var);
  }

  $value="1323";
  $result = test($value);
  if($result){ //The == true is not needed
     echo "value is true";
  }else{
     echo "false";
  }
?>

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.