[SOLVED] Syntax issue? Concat

[mickinell]

$sql = "INSERT INTO lesson_plan VALUES ('',  '".$date."', '".addslashes($topic)."', '".addslashes($essques)."', '".addslashes($summary)."', '".addslashes($procedure)."',  '".addslashes($resources)."', '".addslashes($notes)."', 'CONCAT_WS (',', ".($strat ? implode("," , $strat) : "").", ".($eval ? implode("," , $eval) : "").", ".($sta ? implode("," , $sta) : "").")')";

$result = @mysql_query($sql,$connection) or die(mysql_error());

 

What's wrong here?

 

I have a table with 9 fields.  When I try this query, I get "Column count doesn't match value count at row 1."

 

???  I know it has something to do with my last part (I replaced the concat part with '1' as a test) but I can't figure it out.

[mickinell]

I figured it out myself.  The correct way, in case there's someone else trying to figure this out like I was:

 

$sql = "INSERT INTO lesson_plan VALUES (
	'',  
	'".$date."', 
	'".addslashes($topic)."', 
	'".addslashes($essques)."', 
	'".addslashes($summary)."', 
	'".addslashes($procedure)."',  
	'".addslashes($resources)."', 
	'".addslashes($notes)."',
	'".($strat ? implode("," , $strat) : "").",".($eval ? implode("," , $eval) : "").",".($sta ? implode("," , $sta) : "")."' )";


$result = @mysql_query($sql,$connection) or die(mysql_error());

[luca200]

The correct way to avoid some headache would be not to mess your code with that horrible mix of single and double quotes, and set variables before you use them in the query...

imho of course