PHP Download Script

[Bricktop]

Hi chaps,

 

I'm doing something soooo wrong here but just cannot figure it out - any help greatly appreciated!

 

OK, so I have 'download.php' in my web root which is:

 

<?php
require("config.php");

$sql = "UPDATE downloads SET count=(count + 1) WHERE name = '".$_GET['filename']."'";
$result = mysql_query($sql);
$filename = downloads/$_GET['filename']/$_GET['filename'];

header("Content-Type: application/force-download");
header("Content-Disposition: attachment; filename=\"".$filename.".zip\"");
?>

 

What this is meant to do is update a counter under MySQL and then present a download dialog.  All downloads are stored under "http://www.mysite.com/downloads/name_of_download/name_of_download.zip"

 

Everything works as it should up till the download dialog.  The filename which appears in the browser is ".zip[1]" - what have I done wrong please?

 

PS - I am calling the download via "download.php?filename=blah" (I know this works because the MySQL field increment works correctly)

 

Thanks in advance!

[Bricktop]

OK, I forgot to use the PHP 'base' function.  I now have:

 

<?php
require("config.php");

$sql = "UPDATE downloads SET count=(count + 1) WHERE name = '".$_GET['filename']."'";
$result = mysql_query($sql);
$path = "downloads/".$_GET['filename']."/".$_GET['filename']."";
$filename = basename($path); 

header("Content-Type: application/force-download");
header("Content-Disposition: attachment; filename=\"".$filename.".zip\"");
?>

 

The browser now brings up the correctly named file download dialog box, but when the file is saved to the hard drive it is empty - 0 bytes!

 

Anyone know what I've down wrong?

[Orio]

Try using $path in your header instead of $filename.

 

 

Also, you are risking yourself here. You are taking user input and placing it right inside a SQL query. This way, people can enter malicious inputs that can damage your database. This is a security hole, and it has to be fixed. There are tons of articles and tutorials about this issue, just google for it.

 

Orio.

[PFMaBiSmAd]

The reason your file is empty is your code needs to read the file and output it to the browser. The readfile() function is commonly used to do this with one statement.

[Bricktop]

Thanks for your help and pointers chaps - I couldn't get it work so have opted for another route instead!

 

Thanks anyway.