Using Java Script in PHP HELP

[balkan7]

Hi guys, i have created function for show and hide rating in downloads so code not working propertly.

 

code is:

<?php
echo "<script type='text/javascript' language='JavaScript'>
function showhide(id){
if (document.getElementById){
obj = document.getElementById(id);
if (obj.style.display == 'none'){
obj.style.display = '';
} else {
obj.style.display = 'none';
}
}
}
</script>";
echo "<tr>\n<td width='30%' class='tbl2'><b>Ratings:</b> \n<a href='#' onClick='showhide('".$data['download_id']."_ratings'); return(false);'><img src='".IMAGES."ratings.png' border='0' title='Ratings' alt='Ratings' /></a></td>\n</tr>";
echo "<div id='".$data['download_id']."_ratings' style='display:none;'>
				".showratings("D", $data['download_id'], FUSION_SELF."?cat_id=$cat_id&download_id=".$data['download_id'])."</div>";
?>

[.josh]

php doesn't parse javascript. your browser does.  php just spits it out to your browser.  Now, "It doesn't work" could mean that your variables aren't echoing what you want them to (I do see some $'s in there, which makes them php vars) but I don't see where you are setting them in the first place. 

 

You're going to have to be more specific about "it doesn't work." Is the data there, but it's just not showing/hiding? That's a javascript problem.  Variables shooting blanks? Possibly php, possibly javascript.  But again, you have to be more specific. 

[balkan7]

maybe, now just show me ratings not hidding link in picture not working, and now when i try to rate one download rate everyone from that category, strange.

i have set variable for show id to div tags and open from download id. 

what wrong here i dont know

Soryy for bad english

[balkan7]

dump  ???

[.josh]

...well, you didn't really answer my question...what exactly is the problem? Do you see your data or not?

[balkan7]

Soryy Crayon Violent, yes i see data from onClick='showhide('".$data['download_id']."_ratings');

i tryed whit many modifycation but nothing again, when i rate one from download rating all downloads.

Exactly problem is not working link on image, this tag is opened not hidden -> <div id='".$data['download_id']."_ratings' style='display:none;'>.

Exactly doesn't work, where i wrong ?

[.josh]

alright then. Since you're seeing data then it's not a php problem it's a javascript problem.

 

moving thread.

[balkan7]

any idea ?

[balkan7]

why java script wont work ?

[balkan7]

guys how can i get real id from open it for vote, if i vote only vote id=1, i need help to get id from show rating in div tag:

 

<?php
echo "<script type='text/javascript' language='JavaScript'>
function showhide(id){
if (document.getElementById){
obj = document.getElementById(id);
if (obj.style.display == 'none'){
obj.style.display = '';
} else {
obj.style.display = 'none';
}
}
}
</script>";
echo "<tr>\n<td width='30%' class='tbl2'><b>Ratings:</b> \n<a href='#' onClick='showhide('".$data['download_id']."_ratings')'><img src='".IMAGES."ratings.png' border='0' title='Ratings' alt='Ratings' /></a></td>\n</tr>";
echo "<div id='".$data['download_id']."_ratings' style='display:none;'>
				".showratings("D", $data['download_id'], FUSION_SELF."?cat_id=$cat_id&download_id=".$data['download_id'])."</div>";
?>