[SOLVED] Query Issue

[ainoy31]

Hello-

 

I am trying to get data from the database and populate the data in a drop down menu but it does not seem to work.

 

$sql = "SELECT DISTINCT make FROM car";
$result = mysql_query($sql) or die("Error: " . mysql_error());
$rows = mysql_num_rows($result);  //gives me the total rows found to use as my counter
    
?>
        <select name="make">
            <option value="">Make</option>
    <?      $x = 0;
            while($x < $rows)
    {
            $make = mysql_result($result, $x, 'make'); 
    ?>
     
     
            <option value="<?=$make[$x]?>"><? echo $make[$x];?></option>
             </select>
<?
        $x++;

       
    }
?>

 

There should be 51 records but I get nothing in the select menu.  Much appreciation.

[Barand]

"$make[$x]" in the options should be just "$make".

 

 

or try

<?php
$sql = "SELECT DISTINCT make FROM car";
$result = mysql_query($sql) or die("Error: " . mysql_error());
while ($row = mysql_fetch_assoc($result))
{
printf("<option value='%s'>%s</option>\n", $row['make'], $row['make']);
}
?>

[ainoy31]

Thanks for the suggestion.  It is working.  Why did you use %s?

[Barand]

Why did you use %s?

Because I thought the car makes would probably be string values