[SOLVED] Creating XML File with PHP

[proggR]

Hey. I'm adding an RSS feature to my mini CMS type thing and its supposed to read the previous entries from a buffer that is a text file, add the new entry to that file and save the new entry, followed by the old entries into one variable. Then its supposed to write that variable (with all posts, newest at the top) to an xml file with a header and footer before and after that entries. The buffer is working fine but the feed.xml is blank. However it does seem to create a feedxml file and when i open it with notepad or wordpad it has all the content that I would expect in the feed.xml. Can anyone explain why this is happening? Heres my code that does this:

 

The variable $rss is just the entries, which would normally have variables for the title and description but I've hard coded them here for you.

 

 

$rss = "<item> \n<title>Wiiiii</title> \n<description>This is a test entry.</description> \n <link>www.site.com/test.php</link> \n </item>";

 

//checks if the file is already listed in the all file and adds it if not

if (!file_exists("rssBuffer.txt")){ 
touch("rssBuffer.txt");
}

$fh = fopen("rssBuffer.txt", 'r');
$fold = fread($fh, filesize("rssBuffer.txt"));

$write = "$rss \n $fold";

$fh2 = fopen("rssBuffer.txt", 'w+');
fwrite($fh2, $write);
fclose($fh);
fclose($fh2);

//end adding the rss to the buffer


$header = "<?xml version=\"1.0\"?> \n<rss version=\"2.0\"> \n<channel> \n";
$footer = "</channel> \n</rss>";
$fullRSS = $header.$write.$footer;
//add feed to the rss

if (!file_exists("feed.xml")){ 
touch("feed.xml");
}

$fh = fopen(feed.xml, 'w');
if($fh==false)
die("unable to create file");
fwrite($fh, $fullRSS);

fclose($fh);


//end adding feed to the rss

[proggR]

Nvm. A friend pointed out the mistake. I didn't have the feed.xml in quotes.

[anon_login_001]

If I understand correctly, it is generating a file on your server named "feedxml" but not correctly placing the contents (that you *are finding in "feedxml") into "feed.xml"?

 

If so, and if the code sample you provided is something like what you're using, the problem is right here:

 

$fh = fopen(feed.xml, 'w');

 

If you were showing All Errors (or if you go and check your logs), you would most likely see two NOTICEs happening on this line, something along the lines of "Undefined Constant".

 

The fix is the put quotes around "feed.xml".

 

As PHP sees it right now, it tries to find a Constant called 'feed', and not finding one it uses the string "feed".  It doesn't use the dot, because now it thinks it's supposed to concatenate with what comes next (since the period isn't in quotes of any kind) ... then it sees "xml" and once again doesn't find a constant named "xml" so it uses the string "xml".

 

The period, not being in a string, concatenates the two strings, and you get "feedxml".

 

 

[anon_login_001]

Doh! Longwinded, when I could have answered in seconds.

 

[proggR]

lol Thanks anon! At least I know someone would have spotted that either way!