Registering On My Website: MySQL Syntax Error?

[EPCtech]

Hello,

My website, on the register page, says that my MySQL syntax to insert a member into the database is incorrect. Is there anything wrong with this? (P.S. - All variables exist)

 

mysql_query("INSERT INTO login(username, password, email)VALUES(".$username.",".$password.",".$email) or die(mysql_error());

 

I don't get it.

 

Best Regards,

En-Psyche Management

[mjedman1]

The query was missing some chars at the end.

mysql_query("INSERT INTO login(username, password, email)VALUES(".$username.",".$password.",".$email.")") or die(mysql_error());

[gabarab]

try this:

mysql_query("INSERT INTO login (username, password, email) VALUES('$username','$password','$email')") or die(mysql_error());

[PFMaBiSmAd]

String data must be enclosed in single-quotes so that mysql knows they are strings and not identifiers.

 

Edit: gabarab's is correct, but it is missing a closing " and ) on the end of the mysql_query() statement.

[revraz]

You want single quotes and no periods around your variables.

 

Posting the error would help catch it also.

 

mysql_query("INSERT INTO login (username, password, email)VALUES('$username', '$password', '$email'") or die(mysql_error());

[PFMaBiSmAd]

That one is missing a closing ) for the VALUES (...) clause.

[EPCtech]

Hi,

Actually, "mjedman1" did it correctly. Thanks, my system now works!

 

Best Regards,

En-Psyche Management

[PFMaBiSmAd]

Only if the contents in the variables contain single-quotes as well.

[EPCtech]

Hello,

Now I have another problem. When I try making it so it adds the user group, it has the same error:

 

mysql_query("INSERT INTO login(username, password, email, group)VALUES('".$username."','".$password."','".$email."','".$group."')") or die(mysql_error());

 

Any help?

 

Best Regards,

En-Psyche Management

[PFMaBiSmAd]

If you were to post the error messages you are getting, you would get a more direct and quicker solution because the error points to the place in the query where the problem is.

 

group is a reserved keyword. Either change the column name to something else or enclose it in back-ticks.