Jump to content

Information from MySQL not being Displayed...expert needed

strujillo

By strujillo
in PHP Coding Help

 Share

Recommended Posts

strujillo Member

strujillo

Posted
Posted

So i just uploaded everything to godaddy(yay...onikz.com)

 

anyways, i am making a social network but its still very beta, i am having a problem with my this code: Basically whats going on is, i need it to print out the email onto the screen, but it wont for some reason.

 

Can you spot the problem??

 

NOTE: this is inbox.php?id=(a number goes here, depending on what message you pick)

<?php
//This code checks to make sure they are logged in BEFORE they can access the webpage
session_start();
if(!isset($_SESSION['myusername'])){
//If he is not logged in, go to index.php
header("location:/si/onikz/index.php");
}else{
//If he is logged in do nothing and go on to the rest of the code.
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Email: Inbox</title>
<link rel="stylesheet" href="http://onikz.com/si/housekeeping/css.css"  type="text/css" media="screen"  />
<body>

<div id="content">
<div id="email">
		<?php
		 inbox($id); //Calls the inbox function
		?>
</div>
</div>
<?php
//This adds the menu to the program
include("menu.php"); 
?>
</body>
</html>
<?php


function inbox($id){
//THIS CODE JUST SHOWS THE BUTTONS
//They are disquised as links with a button exterior


//THIS IS THE CODE THAT DISPLAYS THE MESSAGE.
		include("../housekeeping/dbconnect.php"); 					//conects to database
		$username=$_SESSION["myusername"];									//assigns the user name to $username
		$sql ="SELECT * FROM `SocInt`.`email` WHERE `id`='$id'";  			//This selects the message fromt he database

		$result=mysql_query($sql); 										
		$count=1;
		while($row = mysql_fetch_array($result)){							//This displays the message

		$to = $row[to];
		$from=$row[from];
		$subject=$row[subject];
		$message=$row[message];
		$id=$row[id];
			if($to == $username){											//This double checks to make sure the username also
																			//matches
			echo"<center><table id=\"Message\">";
			echo"<tr><td>From:</td><td>$from</td></tr>";
			echo "<tr><td>Subject</td><td>$subject</td></tr>";
			echo "<tr><td>Message</td><td>$message</td></tr>";
			echo"</table></center>";
			echo "hello";
			}

		}
		}
		?>

 

Heres the webpage were it gives them the option to view the message. This then sends them to the above code.

 

<?php
//This code checks to make sure they are logged in BEFORE they can access the webpage
session_start();
if(!isset($_SESSION['myusername'])){
//If he is not logged in, go to index.php
header("location:/si/onikz/index.php");
}else{
//If he is logged in do nothing and go on to the rest of the code.
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Email</title>
<link rel="stylesheet" href="http://onikz.com/si/housekeeping/css.css"  type="text/css" media="screen"  />
<body>

<div id="content">
<div id="email">
		<?php
		 email(); //Calls the email function
		?>
</div>
</div>
<?php
//This adds the menu tot he program
include("menu.php"); 
?>
</body>
</html>

<?php
function email(){
	buttons();
}

function buttons(){
	echo "<center><form mehtod=\"get\"><input type=\"submit\" value=\"Inbox\" name=\"inbox\" />";
	echo "<input type=\"submit\" value=\"Outbox\" name=\"outbox\" />";
	echo "<input type=\"submit\" value=\"Compose\" name=\"compose\" /></form></center>";

	if(isset($_GET["inbox"])){
		inbox();
	}
	if(isset($_GET["outbox"])){
		outbox();
	}
	if(isset($_GET["compose"])){
		compose();
	}
	return ;
}

function inbox(){
	include("../housekeeping/dbconnect.php"); 
		$username=$_SESSION["myusername"];
		//This selects the message where it has not been read alread, thats why it only pick
		$sql ="SELECT * FROM `SocInt`.`email` WHERE `to`='$username'"; 

		$result=mysql_query($sql);
		$count=1;
		while($row = mysql_fetch_array($result)){

		$to = $row[to];
		$from=$row[from];
		$subject=$row[subject];
		$message=$row[message];
		$id=$row[id];
			if($to == $username){
			echo"<table id=\"emailInbox\">";
			echo"<tr id=\"emailInbox\"><td id=\"emailInbox\">Option</td><td id=\"emailInbox\">From</td><td id=\"emailInbox\">Subject</td></tr>";
			echo"<tr id=\"emailInbox\"><td id=\"emailInbox\"><a href=\"inbox.php?id=$id\">View</a></td><td id=\"emailInbox\">$from</td><td id=\"emailInbox\">$subject</td>";
			echo"</table>";

			}

		}
}

function outbox(){
	include("../housekeeping/dbconnect.php"); 

		$username=$_SESSION["myusername"];
		//This selects the message where it has not been read alread, thats why it only pick
		//the messages with stats to 0
		$sql ="SELECT * FROM `SocInt`.`email` WHERE `from`='$username'"; 

		$result=mysql_query($sql);
		$count=1;
		while($row = mysql_fetch_array($result)){

		$to = $row[to];
		$from=$row[from];
		$subject=$row[subject];
		$message=$row[message];
		$id=$row[id];

			echo "<center>";
			echo "<table border=\"1\" cellpadding=\"5\" width=\"400px\">";
				echo "<td></td>";
				 echo "<th rowspan\"3\"> Email Number " .$count." </th>";
				echo "<tr>";
					echo "<th scope=\"row\" width=\"50px\">From</th>";
				echo "<td>$from</td>";
				echo "</tr>";
				echo "<tr>";
					echo "<th scope=\"row\" width=\"50px\">Subject</th>";
					echo "<td>$subject</td>";
				echo "</tr>";
				echo "<tr>";
					echo "<th scope=\"row\" width=\"50px\">Message</th>";
					echo "<td>$message</td>";
				echo "</tr>";
				echo "<tr></tr>";
			echo "</table>";
			echo "</center>";
			$count++;}
		}


function compose(){
	echo "<center>";
	echo "<form action=\"sendmail.php\" method=\"post\" name=\"email\">";
		echo "<table>";
		echo "<tr>";
				echo "	<td>To:</td>";
				echo "<td><input  name=\"to\" type=\"text\" size=\"50\" maxlength=\"70\" /></td>";
			echo "	</tr>";
			echo "	  <tr>";
			echo "		<td>Subject</td>";
			echo "		<td><input name=\"Subject\" type=\"text\" size=\"50\" maxlength=\"70\" /><br /></td>";
			echo "	  </tr>";
			echo "	  <tr>";
			echo "		<td>Message</td>";
			echo "		<td><textarea name=\"Message\" cols=\"38\" rows=\"5\"></textarea></td>";
			echo "	  </tr>";
			echo "	  <tr>";
			echo "		<td>Options</td>";
			echo "		<td><input name=\"send\" type=\"submit\" value=\"Send\" /></td>";
			echo "	  </tr>";
		echo "	</table>";
	echo "</form>";
	echo"</center>";
}
?>

PFMaBiSmAd Advanced Member

PFMaBiSmAd

Posted
Posted

So, several questions, since you did not provide any useful information as to what it is actually doing or to even point out in which section or line in your code the email address should be output at -

 

1) Are you developing and debugging this on a local development system first and if so, does it work on the development system? If you are developing and debugging this online, why?

 

2) Do you have error_reporting set to E_ALL and display_errors set to ON to get php to help you?

 

3) None of your mysql_query() function calls have any error checking or error reporting logic to get your program to tell you if the query failed, and we cannot tell you that either without more information. You need to add error checking (check if something worked or failed), error reporting (output a useful message if it failed), error logging (log what happened so you have a record of problems), and error recovery (what does your code do when an error occurs, blindly continue or terminate) logic to your script.

 

4) What is being output? Is just the email address blank or is there no output at all? You need to state or post exactly what you see in front of you when you try this.

 

5) What exact line of code should be outputting the email address?

 

Edit: Upon further review, it is the whole email you are expecting to be displayed but it is not. So, what troubleshooting have you done to pin down at what point the code is working at and at what point it is not? Don't forget we don't have access to your database and cannot test this to duplicate your problem.

 

 

PFMaBiSmAd Advanced Member

PFMaBiSmAd

Posted
Posted

Upon further review of your code, it is dependent on register_globals to set the program variable $id. Register_globals were turned off 6 years ago. No new code should have been written after 2002 that relied on register_globals. Your first piece of code needs to use $_GET['id'] to reference the parameter on the end of the url.

 

You also need to validate all external data (your validation code would have detected that $id did not contain a valid value and would have output a useful error message.) You also need to use mysql_real_escape_string() on all data put into a query that could contain special characters to prevent sql injection and to prevent special characters from breaking your query.

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.