Register page - script wont add details to mysql table

overidemehra · October 24, 2008

Hi,

i was jsut wondering why does not my script allow to add details when i add the username, password and email. Thought it will not allow me to take the same username or email already present in my mysql table. It even goes thorugh when i add all new details , by saying that i have registered properly and i can login. But when i check in my mysql table, no new data is added. How to fix this?

i am new to php... learnt over the net....

thanks

<?php

$action=$_GET["action"];

$uname = $_POST["user"];

$pword = $_POST["pass"];

$email = $_POST["email"];

$vpass = $pword;

$user_name = "xxxxx";

$pass_word = "xxxxx";

$dbname="xxxx";

$table = "login";

$server = "xxxx";

$c=mysql_connect($server,$user_name, $pass_word, $table) OR DIE ('Unable to connect to database! Please try again later.');

$db_found=mysql_select_db($dbname);

//if registering, check fields.

if ($action == register) {

if (!$uname || !$pword || !$email || !$vpass) {

print "You must fill out all fields.";

exit;

}

$dupe1 = mysql_num_rows(mysql_query("SELECT username FROM `$table` WHERE `username` = '$uname'"));

if ($dupe1 > 0) {

print "Someone already has that username.";

exit;

}

$dupe2 = mysql_num_rows(mysql_query("SELECT email FROM `$table` WHERE `email` ='$email'"));

if ($dupe2 > 0) {

print "Someone already has that email.";

exit;

}

//check if passwords are the same

if ($pword != $vpass) {

print "The passwords do not match.";

exit;

}

//end

//insert

mysql_query("INSERT INTO login (username, email, pass) VALUES ('$uname','$email','$pword')");

print "You are now registered. Login.";

}

?>

<html>

<body>

<table>

<tr><td>Username:</td><td><input type=text name=user></td></tr>

<tr><td>Email:</td><td><input type=text name=email></td></tr>

<tr><td>Verify Pass:</td><td><input type=password name=vpass></td></tr>

</table>

</form>

</body>

</html>

overidemehra · October 24, 2008

found the answer at

http://www.trap17.com/forums/php-mysql-login-register-t9487.html

and

http://www.java2s.com/Code/Php/MySQL-Database/Useformtoadddatatodatabase.htm

anyways,

thanks you

monkeytooth · October 24, 2008

<?php

   $action=$_GET["action"];
   
   $uname = $_POST["user"];
   $pword = $_POST["pass"];
   $email = $_POST["email"];
   $vpass = $pword;

   $user_name = "xxxxx";
   $pass_word = "xxxxx";
   $dbname="xxxx";
   $table = "login";
   $server = "xxxx";

   $c=mysql_connect($server,$user_name, $pass_word, $table) OR DIE ('Unable to connect to database! Please try again later.');
   $db_found=mysql_select_db($dbname);


//if registering, check fields.
if ($action == register) {

if (!$uname || !$pword || !$email || !$vpass) {
print "You must fill out all fields.";

exit;
}
$dupe1 = mysql_num_rows(mysql_query("SELECT username FROM `$table` WHERE `username` = '$uname'"));

if ($dupe1 > 0) {
print "Someone already has that username.";

exit;
}
$dupe2 = mysql_num_rows(mysql_query("SELECT email FROM `$table` WHERE `email` ='$email'"));
if ($dupe2 > 0) {
print "Someone already has that email.";

exit;
}

//check if passwords are the same
if ($pword != $vpass) {
print "The passwords do not match.";

exit;
}
//end
//insert
///////////////////////////////////////////////////////
/////////////////////Code Adjusted from here down
/////////////////////havent looked at the rest, but
/////////////////////if you were just having issue
/////////////////////with just insert this should
/////////////////////fix it..
///////////////////////////////////////////////////////
$query_up = "INSERT INTO login (username, email, pass) VALUES('$uname', '$email', '$pword')";
mysql_query($query_up) or die('Error, insert query failed.<br><br>' . mysql_error());


print "You are now registered. Login.";
}
?>

<html>
<body>

<form method="post" action="register.php?action=register" name="s">
<table>
<tr><td>Username:</td><td><input type="text" name="user"></td></tr>
<tr><td>Email:</td><td><input type="text" name="email"></td></tr>
<tr><td>Pass:</td><td><input type="password" name="pass"></td></tr>
<tr><td>Verify Pass:</td><td><input type="password" name="vpass"></td></tr>
<tr><td colspan="2" align="center"><input type="submit" value="Register"></td></tr>
</table>
</form>


</body>
</html>

The problem I found with your original insert was it was laid out in my opion wrong, but there's different ways for everyone that is mine.. the concept works fine for me on a site i am building (crecs.org)

One thing I beg you to look into and research before implementing this script above is SQL Sanitation.. Sanitize your inputs.. Also consider encrypting passes.. shal() would work fine.. and look into SQL Injection Attacks as well that will help better understand why Sanitation is needed.

monkeytooth · October 24, 2008

good beginners tutorial site that still helps me on occasion today is

http://www.tizag.com wont teach ya everything but will teach you enough to get a good start quick.

overidemehra · October 24, 2008

thanks alot ppl...

its is possible that could you just show me where to add these protection commands, as i have no clue u even needd to, i thought all this was fine, as i am testing everything is running perfectly fine now, it adds the data to my database.....

thanks...

heres my new script

<?php

$action=$_GET["action"];

$uname = $_POST["user"];

$pword = $_POST["pass"];

$email = $_POST["email"];

$vpass = $pword;

$user_name = "xxxx";

$pass_word = "xxxx";

$dbname="xxxx";

$table = "login";

$server = "xxxx";

$c=mysql_connect($server,$user_name, $pass_word, $table) OR DIE ('Unable to connect to database! Please try again later.');

$db_found=mysql_select_db($dbname);

//if registering, check fields.

if ($action == register) {

if (!$uname || !$pword || !$email || !$vpass) {

?>

var message = "Copy Right Belongs To The Administrator";

function rtclickcheck(keyp){ if (navigator.appName == "Netscape" && keyp.which == 3){ alert(message); return false; }

if (navigator.appVersion.indexOf("MSIE") != -1 && event.button == 2) { alert(message); return false; } }

document.onmousedown = rtclickcheck;

</SCRIPT>

</HEAD>

<BODY>

<H1><B><FONT size=5>xxxx</FONT></B><BR><B><I><FONT size=2>The greatest site on the Internet!</FONT></I></B></H1></DIV>

<DIV id=mainContent><FONT size=5><STRONG> Login</STRONG></FONT>

<UL>

You must fill out all fields. <A href="register.php">Click here to Register</a>

<?

exit;

}

$dupe1 = mysql_num_rows(mysql_query("SELECT username FROM `$table` WHERE `username` = '$uname'"));

if ($dupe1 > 0) {

?>

var message = "Copy Right Belongs To The Administrator";

function rtclickcheck(keyp){ if (navigator.appName == "Netscape" && keyp.which == 3){ alert(message); return false; }

if (navigator.appVersion.indexOf("MSIE") != -1 && event.button == 2) { alert(message); return false; } }

document.onmousedown = rtclickcheck;

</SCRIPT>

</HEAD>

<BODY>

<H1><B><FONT size=5>xxxxx</FONT></B><BR><B><I><FONT size=2>The greatest site on the Internet!</FONT></I></B></H1></DIV>

<DIV id=mainContent><FONT size=5><STRONG> Login</STRONG></FONT>

<UL>

Someone already has that username. <A href="register.php">Click here to Register</a>

<?

exit;

}

$dupe2 = mysql_num_rows(mysql_query("SELECT email FROM `$table` WHERE `email` ='$email'"));

if ($dupe2 > 0) {

?>

var message = "Copy Right Belongs To The Administrator";

function rtclickcheck(keyp){ if (navigator.appName == "Netscape" && keyp.which == 3){ alert(message); return false; }

if (navigator.appVersion.indexOf("MSIE") != -1 && event.button == 2) { alert(message); return false; } }

document.onmousedown = rtclickcheck;

</SCRIPT>

</HEAD>

<BODY>

<H1><B><FONT size=5>xxxx</FONT></B><BR><B><I><FONT size=2>The greatest site on the Internet!</FONT></I></B></H1></DIV>

<DIV id=mainContent><FONT size=5><STRONG> Login</STRONG></FONT>

<UL>

Someone already has that email. <A href="register.php">Click here to Register</a>

<?

exit;

}

//check if passwords are the same

if ($pword != $vpass) {

echo "The passwords do not match.";

exit;

}

//end

//insert

$send = mysql_query("INSERT INTO login SET `username` = '$uname', `password` = '$pword', `email` = '$email'");

if ($send) {

?>

var message = "Copy Right Belongs To The Administrator";

function rtclickcheck(keyp){ if (navigator.appName == "Netscape" && keyp.which == 3){ alert(message); return false; }

if (navigator.appVersion.indexOf("MSIE") != -1 && event.button == 2) { alert(message); return false; } }

document.onmousedown = rtclickcheck;

</SCRIPT>

</HEAD>

<BODY>

<H1><B><FONT size=5>xxxx</FONT></B><BR><B><I><FONT size=2>The greatest site on the Internet!</FONT></I></B></H1></DIV>

<DIV id=mainContent><FONT size=5><STRONG> Login</STRONG></FONT>

<UL>

<A href="index.php">Click here to Login</a>

<?

exit;

}

?>

<html>

<body>

var message = "Copy Right Belongs To The Administrator";

function rtclickcheck(keyp){ if (navigator.appName == "Netscape" && keyp.which == 3){ alert(message); return false; }

if (navigator.appVersion.indexOf("MSIE") != -1 && event.button == 2) { alert(message); return false; } }

document.onmousedown = rtclickcheck;

</SCRIPT>

</HEAD>

<BODY>

<H1><B><FONT size=5>xxxx</FONT></B><BR><B><I><FONT size=2>The greatest site on the Internet!</FONT></I></B></H1></DIV>

<DIV id=mainContent><FONT size=5><STRONG> Login</STRONG></FONT>

<UL>

<table>

<tr><td>Username:</td><td><input type=text name=user></td></tr>

<tr><td>Email:</td><td><input type=text name=email></td></tr>

<tr><td>Verify Pass:</td><td><input type=password name=vpass></td></tr>

</table>

</form>

All Content &copy by xxxx

</UL></DIV></DIV></DIV></DIV>

</body>

</html>

overidemehra · October 24, 2008

conti of above ...

if someone could explain how to make the script forward an email to the person who registers my site and as well as to me... jsut how it happens on this site when u register , an email coems with ur user name and password????

thanks alot

Sign In

Register page - script wont add details to mysql table

Recommended Posts

overidemehra

Link to comment

Share on other sites

overidemehra

Link to comment

Share on other sites

monkeytooth

Link to comment

Share on other sites

monkeytooth

Link to comment

Share on other sites

overidemehra

Link to comment

Share on other sites

overidemehra

Link to comment

Share on other sites

Archived

Browse

Activity

Important Information