Help needed.

seany123 · October 27, 2008

Okay for you to understand how to help me i need to explain what i am trying to do -

I am making a game and part of the game is Doing Crimes which has a success rate based on the amount of nerve the player has etc etc etc.

Now i think i have got this all written up to work however im constantly getting a 'Not enough nerve' error.

Maybe there is something im not quite doing right.

here it is:

<?
if ($_GET['act'] == "1" && $player->nerve > 0)
{
if($perc2 > 74 && $crime < 9) 
{
if (25 + $player->exp >= $player->maxexp) //Player gained a level!
    {
     //Update player
	 echo "You gained 25 EXP and $10";
	 $query = $db->execute("update `players` set `exp`=?, `money`=?, `nerve`=? where `id`=?", array($player->exp + 25, $player->money + 10, $player->nerve - 1, $player->id));
}
}
else if($crime > 8 && $jail < 3)
{
//Update player
	 echo "You Failed the Crime and was sent to Prison!";
	 $query = $db->execute("update `players` set `nerve`=?, `prison`=?  where `id`=?", array($player->nerve - 1, $player->prison + 1, $player->id));
}
else if($crime > 
{
//Update player
	 echo "You Failed the Crime!";
	 $query = $db->execute("update `players` set `nerve`=? where `id`=?", array($player->nerve - 1, $player->id));

}
else if($perc2 > 48 && $perc2 < 75 && $crime < 7) 
{
if (25 + $player->exp >= $player->maxexp) //Player gained a level!
    {
     //Update player, gained a level
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `points`=?, `level`=?, `maxexp`=?, `maxhp`=?, `exp`=?, `money`=?, `hp`=?, `nerve`=? where `id`=?", array($player->points + 3, $player->level + 1, ($player->level+1) * 70 - 20, $player->maxhp + 30, $player->money + 10, $newexp, $player->nerve - 1, $player->id));
}
else
     //Update player
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `exp`=?, `nerve`=? where `id`=?", array($player->exp + 25, $player->nerve - 1, $player->id));
}
}
else if($crime > 6 && $jail < 3)
{
//Update player
	 echo "You Failed the Crime and was sent to Prison!";
	 $query = $db->execute("update `players` set `nerve`=?, `prison`=?  where `id`=?", array($player->nerve - 1, $player->prison + 1, $player->id));
}
else if($crime > 6)
{
//Update player
	 echo "You Failed the Crime!";
	 $query = $db->execute("update `players` set `nerve`=? where `id`=?", array($player->nerve - 1, $player->id));
}
else
{
if($perc2 > 24 && $perc2 < 49 && $crime < 5) 
{
if (25 + $player->exp >= $player->maxexp) //Player gained a level!
    {
     //Update player, gained a level
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `points`=?, `level`=?, `maxexp`=?, `maxhp`=?, `exp`=?, `money`=?, `hp`=?, `nerve`=? where `id`=?", array($player->points + 3, $player->level + 1, ($player->level+1) * 70 - 20, $player->maxhp + 30, $player->money + 10, $newexp, $player->nerve - 1, $player->id));
}
else
     //Update player
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `exp`=?, `nerve`=? where `id`=?", array($player->exp + 25, $player->nerve - 1, $player->id));
}
else if($crime > 4 && $jail < 3)
{
//Update player
	 echo "You Failed the Crime and was sent to Prison!";
	 $query = $db->execute("update `players` set `nerve`=?, `prison`=?  where `id`=?", array($player->nerve - 1, $player->prison + 1, $player->id));
}
else if($crime > 4)
{
//Update player
	 echo "You Failed the Crime!";
	 $query = $db->execute("update `players` set `nerve`=? where `id`=?", array($player->nerve - 1, $player->id));
}
else
{
if($perc2 > 0 && $perc2 < 25 && $crime < 3) 
{
if (25 + $player->exp >= $player->maxexp) //Player gained a level!
    {
     //Update player, gained a level
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `points`=?, `level`=?, `maxexp`=?, `maxhp`=?, `exp`=?, `money`=?, `hp`=?, `nerve`=? where `id`=?", array($player->points + 3, $player->level + 1, ($player->level+1) * 70 - 20, $player->maxhp + 30, $player->money + 10, $newexp, $player->nerve - 1, $player->id));
}
else
     //Update player
	 echo "You gained 25 EXP";
	 $query = $db->execute("update `players` set `exp`=?, `nerve`=? where `id`=?", array($player->exp + 25, $player->nerve - 1, $player->id));
}
else if($crime > 2 && $jail < 3)
{
//Update player
	 echo "You Failed the Crime and was sent to Prison!";
	 $query = $db->execute("update `players` set `nerve`=?, `prison`=?  where `id`=?", array($player->nerve - 1, $player->prison + 1, $player->id));
}
else if($crime > 2)
{
//Update player
	 echo "You Failed the Crime!";
	 $query = $db->execute("update `players` set `nerve`=? where `id`=?", array($player->nerve - 1, $player->id));
}

else
{
echo "Not enough Nerve";
}
}
}
?>

akitchin · October 27, 2008

have you checked what $_GET['act'] and $player->nerve actually are? i assume your braces are all in order; you may want to look them over and be sure of this.

EDIT: you may want to do just a generic variable dump. you can do this quickly and efficiently like so:

echo '<pre>'.print_r(get_defined_vars(), TRUE);

Fruct0se · October 27, 2008

I have noticed several areas in your code where your statements are missing the { and } deliminator and several areas where you have else followed by elseif's, you may want to scrub through the code.

seany123 · October 27, 2008

I dont know if not having the {}s in the right places is the problem because im getting a "not enough nerve" echo.

ALSO

I dont really know too much about php, im writing these codes in Dreamweaver or Notepad++... and testing them out on a online website.

How would i use that code?

echo '<pre>'.print_r(get_defined_vars(), TRUE);

akitchin · October 27, 2008

put that line at the top of the script (or just above this block that you've shown us). misplaced and miscounted braces can lead to the execution of incorrect statements, which in this case could be the "Not enough nerve" echo at the end. good practice is to indent every set of statements to avoid just this sort of confusion.

seany123 · October 27, 2008

putting that code at the top... what result should i get?

and i put it in the <? dont i?

MasterACE14 · October 27, 2008

put it at the end of your script before the last ?>

then copy paste whatever comes up here.

seany123 · October 27, 2008

I dont know if this is right but yeah.

seany123 · October 27, 2008

EDIT: Just realized that i had left some passwords in the code.

akitchin · October 27, 2008

it doesn't look like $crime or $perc2 are set as far as i can tell. this might explain why you're getting odd results.

seany123 · October 27, 2008

When you say 'not set' what exactly do you mean?

akitchin · October 27, 2008

what i mean is that those variables don't actually exist, so the conditions you're testing against in the if()s and elseif()s will produce unexpected results.

seany123 · October 27, 2008

lol yeah i see what you mean... needs fixing and thats now fried my brain.

Sign In

Help needed.

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information