php help needed please

petchy · November 25, 2008

ive got my own online rpg and it has in it crews now the bit below is from the functions.php and i would love if any body could give me the right instructions to also enter into the script so that rhm and lhm will also take over the owner postion just like underboss does i can supply any more parts of scripts you may need thanks in advance petchy

}

$crew_check =mysql_query("SELECT * FROM crews");

while($k = mysql_fetch_object($crew_check)){

$user=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));

$underboss=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));

if ($user->status == "Dead" || $user->status == "Banned"){

if ($k->underboss != "0" && $underboss->status == "Alive"){

mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'");

}

elseif ($k->underboss == "0" || $underboss->status == "Dead" || $underboss->status == "Banned"){

mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");

mysql_query("DELETE FROM crews WHERE name='$k->name'");

}

little brief of wat happens incase you dont no might help you out

when the user(owner) gets killed on the game the underboss takes over i would like it so that if owner and underboss are killed the rhm takes over and same for lhm when all 3 above are dead he takes the owner's postion over and then after all 4 are killed the crew is deleted thank you very much again in advance im learning php and so far have had no help from anyone but this as really got me please help

flyhoney · November 25, 2008

Use code tags plzkthnx

<?php
$crew_check = mysql_query("SELECT * FROM crews");

while ($k = mysql_fetch_object($crew_check))
{
$user = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));
$underboss = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));

if ($user->status == "Dead" || $user->status == "Banned")
{
	if ($k->underboss != "0" && $underboss->status == "Alive")
	{
		mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'");
	}
	elseif ($k->underboss == "0" || $underboss->status == "Dead" || $underboss->status == "Banned")
	{
		mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");
		mysql_query("DELETE FROM crews WHERE name='$k->name'");
	}
}
}
?>

petchy · November 25, 2008

sorry first time user thanks for doing it

daydreamer · November 25, 2008

have you got a URL for the game?

petchy · November 25, 2008

www.mafiadream.co.uk

petchy · December 1, 2008

<?php


$crew_check =mysql_query("SELECT * FROM crews");
while($k = mysql_fetch_object($crew_check)){
$user=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));
$underboss=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));
$rhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->rhm'"));
$lhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->lhm'"));
if ($user->status == "Dead" || $user->status == "Banned"){
if ($k->underboss != "0" && $underboss->status == "Alive"){
mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'"); 
if ($underboss->status == "Dead" || $underboss->status == "Banned"){
if ($k->rhm != "0" && $rhm->status == "Alive"){
mysql_query("UPDATE crews SET underboss='$k->rhm', rhm='0' WHERE name='$k->name'"); 
if ($rhm->status == "Dead" || $rhm->status == "Banned"){
if ($k->lhm != "0" && $lhm->status == "Alive"){
mysql_query("UPDATE crews SET rhm='$k->lhm', lhm='0' WHERE name='$k->name'"); 

}
elseif ($k->lhm == "0" || $lhm->status == "Dead" || $lhm->status == "Banned"){
mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");
mysql_query("DELETE FROM crews WHERE name='$k->name'");

}
}
}
?>

i dont no how close this is if im totally wrong this really has got me confused any help would be grateful and well appreciated thanks in advance

by the way this errors out when i upload it

email me at [email protected] if u think you can help and need more information thanks again

revraz · December 1, 2008

And that error is....?

petchy · December 1, 2008

Parse error: syntax error, unexpected $end in /usr/home2/usr/home/mafia/public_html/includes/functions.php on line 348

sorry bit new at all this

revraz · December 2, 2008

You are probably missing a closing } bracket somewhere.

petchy · December 2, 2008

<?php
session_start(); 
include_once "db_connect.php";
$username=$_SESSION['username'];
echo "<link rel=stylesheet href=includes/in.css type=text/css>";

$query=mysql_query("SELECT * FROM users WHERE username='$username' LIMIT 1");
$info = mysql_fetch_object($query);
$don=mysql_num_rows(mysql_query("SELECT * FROM donaters WHERE username='$username'"));

$date = gmdate('Y-m-d h:i:s');

if ($info->health <= "0"){
mysql_query("UPDATE users SET status='Dead' WHERE username='$username'");
session_destroy();
}
if ($info->status == "Dead"){
session_destroy();
echo "You're dead!";
exit();
}

if ($info->status == "Banned"){
session_destroy();
include("../banned.php");
exit();
}


$crew_check =mysql_query("SELECT * FROM crews");
while($k = mysql_fetch_object($crew_check)){
$user=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));
$underboss=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));
$rhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->rhm'"));
$lhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->lhm'"));
if ($user->status == "Dead" || $user->status == "Banned"){
if ($k->underboss != "0" && $underboss->status == "Alive"){
mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'"); 
if ($underboss->status == "Dead" || $underboss->status == "Banned"){
if ($k->rhm != "0" && $rhm->status == "Alive"){
mysql_query("UPDATE crews SET underboss='$k->rhm', rhm='0' WHERE name='$k->name'"); 
if ($rhm->status == "Dead" || $rhm->status == "Banned"){
if ($k->lhm != "0" && $lhm->status == "Alive"){
mysql_query("UPDATE crews SET rhm='$k->lhm', lhm='0' WHERE name='$k->name'"); 

}
elseif ($k->lhm == "0" || $lhm->status == "Dead" || $lhm->status == "Banned"){
mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");
mysql_query("DELETE FROM crews WHERE name='$k->name'");

}
}
}
$bba=mysql_query("SELECT * FROM bank");
while($nana =mysql_fetch_object($bba)){
$ppl=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$nana->owner'"));
if ($ppl->status == "Dead" || $ppl->status == "Banned"){
mysql_query("UPDATE bank SET owner='0' WHERE id='$nana->id'");
}

}




$oc_query=mysql_query("SELECT * FROM oc");
while($ttfn = mysql_fetch_object($oc_query)){
$user_oc=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$ttfn->leader'"));

if ($user_oc->status == "Dead" || $user_oc->status == "Banned"){
mysql_query("UPDATE users SET oc='0' WHERE username='$ttfn->we'");
mysql_query("UPDATE users SET oc='0' WHERE username='$ttfn->ee'");
mysql_query("UPDATE users SET oc='0' WHERE username='$ttfn->driver'");
mysql_query("UPDATE users SET oc='0' WHERE username='$ttfn->leader'");
mysql_query("DELETE FROM oc WHERE id='$ttfn->id'");

}}


function logincheck(){


if (empty($_SESSION['username'])){
echo "
<SCRIPT LANGUAGE='JavaScript'>
window.location='index.php';

</script>
";
exit();
}}

////UPDATE ONLINE
$time = time() + (60 * 10);
mysql_query("UPDATE users SET online='$time' WHERE username='$username'");
///FINSH UPDATING ONLINE

function makecomma($input)
{
  
   if(strlen($input)<=3)
   { return $input; }
   $length=substr($input,0,strlen($input)-3);
   $formatted_input = makecomma($length).",".substr($input,-3);
   return $formatted_input;
}



/////////NOW TO THE BB CODES ETC....







function rankcheck(){
$username=$_SESSION['username'];
$query=mysql_query("SELECT * FROM users WHERE username='$username' LIMIT 1");
$info = mysql_fetch_object($query);
$date = gmdate('Y-m-d h:i:s');

if (($info->rank == "Scum") && ($info->rankpoints >= "100")){ $newrank="Package Boy"; $done="1"; }
elseif (($info->rank == "Package Boy") && ($info->rankpoints >= "200")){ $newrank="Goon"; $done="1"; }
elseif (($info->rank == "Goon") && ($info->rankpoints >= "400")){ $newrank="Thug"; $done="1"; }
elseif (($info->rank == "Thug") && ($info->rankpoints >= "800")){ $newrank="Gangster"; $done="1"; }
elseif (($info->rank == "Gangster") && ($info->rankpoints >= "1200")){ $newrank="Hired Gangster"; $done="1"; }
elseif (($info->rank == "Hired Gangster") && ($info->rankpoints >= "2000")){ $newrank="Hitman"; $done="1"; }
elseif (($info->rank == "Hitman") && ($info->rankpoints >= "4000")){ $newrank="Hired Hitman"; $done="1"; }
elseif (($info->rank == "Hired Hitman") && ($info->rankpoints >= "8000")){ $newrank="Associate"; $done="1"; }
elseif (($info->rank == "Associate") && ($info->rankpoints >= "12800")){ $newrank="The Man"; $done="1"; }
elseif (($info->rank == "The Man") && ($info->rankpoints >= "25600")){ $newrank="Boss"; $done="1"; }
elseif (($info->rank == "Boss") && ($info->rankpoints >= "60000")){ $newrank="Don"; $done="1"; }
elseif (($info->rank == "Don") && ($info->rankpoints >= "120000")){ $newrank="Enemy Of the State"; $done="1"; }
elseif (($info->rank == "Enemy Of the State") && ($info->rankpoints >= "240000")){ $newrank="The Myth"; $done="1"; }
elseif (($info->rank == "The Myth") && ($info->rankpoints >= "360000")){ $newrank="Hired Legend"; $done="1"; }
elseif (($info->rank == "Hired Legend") && ($info->rankpoints >= "500000")){ $newrank="Legend"; $done="1"; }
elseif (($info->rank == "Legend") && ($info->rankpoints >= "650000")){ $newrank="Legend"; $done="1"; }


if (!$done){
$done="0";
}
if ($done == "1"){

mysql_query("UPDATE users SET rank='$newrank' WHERE username='$username'");
mysql_query("INSERT INTO `inbox` ( `id` , `to` , `from` , `message` , `date` , `read` , `saved` , `event_id` ) 
VALUES (
'', '$username', '$username', 'You have been promoted to $newrank your doing well! - Mafia Dream', '$date', '0', '0', '0'
)");

}}

rankcheck();
///////HOUSTON WE HAVE JAIL CHECK!


$jail_check=mysql_query("SELECT * FROM jail");


while($monster=mysql_fetch_object($jail_check)){

if (time() > $monster->time_left){
mysql_query("DELETE FROM jail WHERE username='$monster->username'");
}}

function maketime($last){
$timenow = time();
		if($last>$timenow){
				$order = $last-$timenow;
					while($order >= 60){
						$order = $order-60;
						$ordermleft++;
					}
					while($ordermleft >= 60){
						$ordermleft = $ordermleft-60;
						$orderhleft++;
					}

					if($ordermleft == 0){
						$ordermleft = "";
					} else {
					$ordermleft = "$ordermleft Minutes";
					}
					if($orderhleft == 0){
						$orderhleft = "";
					} else {
					$orderhleft = "$orderhleft Hours";
					}	
return "$orderhleft $ordermleft $order Seconds";
}}

function loose_energy(){
$username=$_SESSION['username'];
$query=mysql_query("SELECT * FROM users WHERE username='$username' LIMIT 1");
$info = mysql_fetch_object($query);

$energy=$info->energy - rand(1,3);
if ($energy <= "0"){
$update=health;
$thing=$info->health - rand(1,3);
$energy_new="0";

}elseif ($energy > "0"){
$update=energy;
$thing=$info->energy - rand(1,3);
}
if (!$energy_new){
mysql_query("UPDATE users SET $update='$thing' WHERE username='$username'");
}elseif ($energy_new){

mysql_query("UPDATE users SET $update='$thing', energy='0' WHERE username='$username'");
}
}


$most_online=mysql_fetch_object(mysql_query("SELECT * FROM site_stats WHERE id='1'"));
$timenow=time();
$now_online =mysql_num_rows(mysql_query("SELECT * FROM users WHERE online > '$timenow'"));

if ($now_online > $most_online->online){

mysql_query("UPDATE site_stats SET online='$now_online' WHERE id='1'");
}



$drop =mysql_query("SELECT * FROM casinos");

while($tard=mysql_fetch_object($drop)){
$per = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard->owner'"));
if ($per->status == "Dead" || $per->status == "Banned"){
mysql_query("UPDATE casinos SET owner='0' WHERE casino='$tard->casino' AND owner='$tard->owner'");
}

}
$drop_bar =mysql_query("SELECT * FROM bar");

while($tard_bar=mysql_fetch_object($drop_bar)){
$per_bar = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard_bar->owner'"));
if ($per_bar->status == "Dead" || $per_bar->status == "Banned"){
mysql_query("UPDATE bar SET owner='0' WHERE owner='$tard_bar->owner'");
}
}
$drop_airport =mysql_query("SELECT * FROM airport");

while($tard_airport=mysql_fetch_object($drop_airport)){
$per_airport = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard_airport->owner'"));
if ($per_airport->status == "Dead" || $per_airport->status == "Banned"){
mysql_query("UPDATE airport SET owner='0' WHERE owner='$tard_airport->owner'");
}

}
$drop_bf =mysql_query("SELECT * FROM bf");

while($tard_bf=mysql_fetch_object($drop_bf)){
$per_bf = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard_bf->owner'"));
if ($per_bf->status == "Dead" || $per_bf->status == "Banned"){
mysql_query("UPDATE bf SET owner='0' WHERE owner='$tard_bf->owner'");
}

}
if ($info->banktime <= time() && $info->bank > "0"){
$nmoney =  5 * $info->bank / 100;
$money_in = $info->bank + $nmoney;
$money_in= round($money_in); 
$recieve = $info->money + $money_in;

mysql_query("UPDATE users SET money = '$recieve', bank='0', banktime='0' WHERE username='$username'");

}
$drop_und =mysql_query("SELECT * FROM shop");

while($tard_und=mysql_fetch_object($drop_und)){
$per_und = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard_und->owner'"));
if ($per_und->status == "Dead" || $per_und->status == "Banned"){
mysql_query("UPDATE shop SET owner='0' WHERE owner='$tard_und->owner'");
}

}
$drop_dea =mysql_query("SELECT * FROM dealership");

while($tard_dea=mysql_fetch_object($drop_dea)){
$per_dea = mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$tard_dea->owner'"));
if ($per_dea->status == "Dead" || $per_dea->status == "Banned"){
mysql_query("UPDATE dealership SET owner='0' WHERE owner='$tard_dea->owner'");
}

}
$user_info=mysql_fetch_object(mysql_query("SELECT * FROM user_info WHERE username='$username'"));
if ($user_info->jail_able == "1" && $user_info->jail_untill <= time()){
mysql_query("UPDATE user_info SET jail_able='0' WHERE username='$username'");

}


$user_shit=mysql_fetch_object(mysql_query("SELECT * FROM user_info WHERE username='$username'"));
if ($user_shit->last_respect < time() && $fetch->rank != "Tramp"){
if ($info->rank == "Scum"){ $new_res="1"; }
elseif($info->rank == "Package Boy"){  $new_res="2"; }
elseif($info->rank == "Goon"){  $new_res="3"; }
elseif($info->rank == "Thug"){  $new_res="4"; }
elseif($info->rank == "Gangster"){  $new_res="5"; }
elseif($info->rank == "Hired Gangster"){  $new_res="6"; }
elseif($info->rank == "Hitman"){  $new_res="7"; }
elseif($info->rank == "Hired Hitman"){  $new_res="8"; }
elseif($info->rank == "Associate"){  $new_res="9"; }
elseif($info->rank == "The Man"){  $new_res="10"; }
elseif($info->rank == "Boss"){  $new_res="11"; }
elseif($info->rank == "Don"){  $new_res="12"; }
elseif($info->rank =="Enemy Of the State"){$new_res="13"; }
elseif($info->rank == "The Myth"){$new_res="14"; }
elseif($info->rank =="Hired Legend"){$new_res="15"; }
elseif($info->rank =="Legend"){$new_res="16"; }





$now=time() + (3600 * 24 * 7);
mysql_query("UPDATE user_info SET respect='$new_res', last_respect='$now' WHERE username='$username'"); 











}












?>

thats the full script on it finishes on line 348 :S

awpti · December 2, 2008

Tab that garbage out.

Indentation will lead to enlightenment.

revraz · December 2, 2008

Then I guess you have a lot of hunting to do.

thats the full script on it finishes on line 348 :S

awpti · December 2, 2008

Let me put it this way:

cat junk.php | grep '{' | wc -l

85

cat junk.php | grep '}' | wc -l

76

You are missing 9 closing brackets.

And they make fun of me for using alternative syntax. HAH!

petchy · December 2, 2008

Thanks have you any idea at all were these closing brackets go cause really i dont have a clue im self taught on only been doing it a year now i think im trying to dive in too quick but i just love it so much

revraz · December 2, 2008

Yes, they go after the opening bracket after the code is executed that you want performed.

petchy · December 2, 2008

<?php



$crew_check =mysql_query("SELECT * FROM crews");
while($k = mysql_fetch_object($crew_check)){
$user=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));
$underboss=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));
$rhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->rhm'"));
$lhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->lhm'"));
if ($user->status == "Dead" || $user->status == "Banned"){
if ($k->underboss != "0" && $underboss->status == "Alive"){
mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'"); 
if ($underboss->status == "Dead" || $underboss->status == "Banned"){
if ($k->rhm != "0" && $rhm->status == "Alive"){
mysql_query("UPDATE crews SET underboss='$k->rhm', rhm='0' WHERE name='$k->name'"); 
if ($rhm->status == "Dead" || $rhm->status == "Banned"){
if ($k->lhm != "0" && $lhm->status == "Alive"){
mysql_query("UPDATE crews SET rhm='$k->lhm', lhm='0' WHERE name='$k->name'"); 

}
elseif ($k->lhm == "0" || $lhm->status == "Dead" || $lhm->status == "Banned"){
mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");
mysql_query("DELETE FROM crews WHERE name='$k->name'");

}
}
}
?>

thats the bit that i have editited so would these closing brackets go in there somewere or somewere else on the script ???

awpti · December 2, 2008

You're beyond help at this point, Petchy.

Tab out your code and you will find the missing braces.

awpti · December 2, 2008

Here's a start for you, so you understand indenting (assuming you don't, for obvious reasons):

<?php

$crew_check =mysql_query("SELECT * FROM crews");
while($k = mysql_fetch_object($crew_check)){
$user=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->owner'"));
$underboss=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->underboss'"));
$rhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->rhm'"));
$lhm=mysql_fetch_object(mysql_query("SELECT * FROM users WHERE username='$k->lhm'"));
	if ($user->status == "Dead" || $user->status == "Banned"){
		if ($k->underboss != "0" && $underboss->status == "Alive"){
			mysql_query("UPDATE crews SET owner='$k->underboss', underboss='0' WHERE name='$k->name'"); 
			if ($underboss->status == "Dead" || $underboss->status == "Banned"){
				if ($k->rhm != "0" && $rhm->status == "Alive"){
					mysql_query("UPDATE crews SET underboss='$k->rhm', rhm='0' WHERE name='$k->name'"); 
					if ($rhm->status == "Dead" || $rhm->status == "Banned"){
						if ($k->lhm != "0" && $lhm->status == "Alive"){
							mysql_query("UPDATE crews SET rhm='$k->lhm', lhm='0' WHERE name='$k->name'"); 

						}
						elseif ($k->lhm == "0" || $lhm->status == "Dead" || $lhm->status == "Banned"){
							mysql_query("UPDATE `users` SET `crew`='0' WHERE `crew`='$k->name'");
							mysql_query("DELETE FROM crews WHERE name='$k->name'");
						}
					}
				}
?>

I think we can begin to see what a horrendous mess this application is. This beast needs some SERIOUS refactoring. Yikes.

I'm not going to tab anything else out for you. Good luck.

Sign In

php help needed please

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Archived

Important Information