Jump to content


Photo

$_GET Problems.


  • Please log in to reply
2 replies to this topic

#1 xyn

xyn
  • Members
  • PipPipPip
  • Advanced Member
  • 779 posts
  • LocationNorthampton

Posted 03 July 2006 - 03:45 PM

Hi.
I'm trying to make an Unban IP script by using this way, I used it before but I don't know how to make this "multiple script" work...

ie:
delete.php?id=X
then it'll delete the X id from database, but now I wanted to do this:

ban.php?act=unban&ip=172.141.192.232&id=1
//AT the top of script i have:
$act = $_GET['act'];
$id = $_GET['id'];

} elseif( $act == unban ) {
$pip = $_GET['ip'];
if( $id == '.$pid.' ){
		
		include("db.php");
		mysql_query("DELETE FROM ban WHERE id='$pid'"); //$pip is set as a var above the code! also. works
		
		echo '<SCRIPT>alert ("You have unbanned the IP #'.$pip.'.")</SCRIPT>';
		}


#2 wildteen88

wildteen88
  • Staff Alumni
  • Advanced Member
  • 10,482 posts
  • LocationUK, Bournemouth

Posted 03 July 2006 - 03:51 PM

Is that you code? If it is you have a few problems unban should be 'unban' (including the quotes). Also '.$pid.' wont work as it wont parse the $pid variable as it is in single quotes. You might want ot use double quotes instead.
Also if $id is supposed to be an number you should check that it by doing this:
if(isset($_GET['id']) && is_int($_GET['id']))
{
    // unban ip code here
}
else
{
    die("Please provide a valid id for the ipaddress");
}


#3 .josh

.josh
  • Staff Alumni
  • .josh
  • 14,871 posts

Posted 03 July 2006 - 06:02 PM

all that aside, am i reading this wrong or are you basing your unban script on an id passed in the url?
Did I help you? Feeling generous? Buy me lunch! 
Please, take the time and do some research and find out how much it would have cost you to get your help from a decent paid-for source. A "roll-of-the-dice" freelancer will charge you $5-$15/hr. A decent entry level freelancer will charge you around $15-30/hr. A professional will charge you anywhere from $50-$100/hr. An agency will charge anywhere from $100-$250/hr. Think about all this when soliciting for help here. Think about how much money you are making from the work you are asking for help on. No, we do not expect you to pay for the help given here, but donating a few bucks is a fraction of the cost of what you would have paid, shows your appreciation, helps motivate people to keep offering help without the pricetag, and helps make this a higher quality free-help community :)




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users