image upload problem

[kev wood]

i have this following script for uploading images to the server but it will not let me upload images over a few hundred kb.  the limit has been set to 1mb in bytes but it is not working and always comes back with the error limit exceeded. 

 

here is the code

 

<?php



	set_time_limit(0); 

	$link  =  mysql_connect(localhost, xxxxxxxxxx, cxxxxxxxxx) or die("Could not connect to host.");
	mysql_select_db(cxxxxxxxx) or die("Could not find database.");




	 //define a maxim size for the uploaded images
	 define ("MAX_SIZE","1048576"); 
	 // define the width and height for the thumbnail
	 // note that theese dimmensions are considered the maximum dimmension and are not fixed, 
	 // because we have to keep the image ratio intact or it will be deformed
	 define ("WIDTH","150"); 
	 define ("HEIGHT","120"); 

	  // this is the function that will create the thumbnail image from the uploaded image
	 // the resize will be done considering the width and height defined, but without deforming the image
	 function make_thumb($img_name,$filename,$new_w,$new_h)
	 {
		//get image extension.
		$ext=getExtension($img_name);
		//creates the new image using the appropriate function from gd library
		if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
			$src_img=imagecreatefromjpeg($img_name);

		if(!strcmp("png",$ext))
			$src_img=imagecreatefrompng($img_name);

		if(!strcmp("gif",$ext))
			$src_img=imagecreatefromgif($img_name);

			//gets the dimmensions of the image
		$old_x=imageSX($src_img);
		$old_y=imageSY($src_img);

		 // next we will calculate the new dimmensions for the thumbnail image
		// the next steps will be taken: 
		// 	1. calculate the ratio by dividing the old dimmensions with the new ones
		//	2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
		//		and the height will be calculated so the image ratio will not change
		//	3. otherwise we will use the height ratio for the image
		// as a result, only one of the dimmensions will be from the fixed ones
		$ratio1=$old_x/$new_w;
		$ratio2=$old_y/$new_h;
		if($ratio1>$ratio2)	{
			$thumb_w=$new_w;
			$thumb_h=$old_y/$ratio1;
		}
		else	{
			$thumb_h=$new_h;
			$thumb_w=$old_x/$ratio2;
		}

		// we create a new image with the new dimmensions
		$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);
		// resize the big image to the new created one
		imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y); 

		// output the created image to the file. Now we will have the thumbnail into the file named by $filename
		if(!strcmp("png",$ext))
			imagepng($dst_img,$filename); 
		else
			imagejpeg($dst_img,$filename);

		if (!strcmp("gif",$ext))
			imagegif($dst_img,$filename); 

		//destroys source and destination images. 
		imagedestroy($dst_img); 
		imagedestroy($src_img); 
	 }

	 // This function reads the extension of the file. 
	 // It is used to determine if the file is an image by checking the extension. 
	 function getExtension($str) {
			 $i = strrpos($str,".");
			 if (!$i) { return ""; }
			 $l = strlen($str) - $i;
			 $ext = substr($str,$i+1,$l);
			 return $ext;
	 }
	  // This variable is used as a flag. The value is initialized with 0 (meaning no error found) 
	 //and it will be changed to 1 if an error occures. If the error occures the file will not be uploaded.
	 $errors=0;
	 // checks if the form has been submitted
	 if(isset($_POST['Submit']))
	 {
	 //reads the name of the file the user submitted for uploading
		$image=$_FILES['cons_image']['name'];
		// if it is not empty
		if ($image) 
		{
			// get the original name of the file from the clients machine
			$filename = stripslashes($_FILES['cons_image']['name']);

			// get the extension of the file in a lower case format
			$extension = getExtension($filename);
			$extension = strtolower($extension);
			// if it is not a known extension, we will suppose it is an error, print an error message 
			//and will not upload the file, otherwise we continue
			if (($extension != "jpg")  && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))	
			{
				echo '<h1>Unknown extension!  Please use .gif, .jpg or .png files only.</h1>';
				$errors=1;
			}
			else
			{
				// get the size of the image in bytes
				// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which 
				//the uploaded file was stored on the server
				$size=getimagesize($_FILES['cons_image']['tmp_name']);
				$sizekb=filesize($_FILES['cons_image']['tmp_name']);

				//compare the size with the maxim size we defined and print error if bigger
				if ($sizekb > MAX_SIZE*1024)
				{
					echo '<h1>You have exceeded the 1MB size limit!</h1>';
					$errors=1;
				}


				$rand= rand(0, 1000);
				//we will give an unique name, for example a random number
				$image_name=$rand.'.'.$extension;
				//the new name will be containing the full path where will be stored (images folder)
				$consname="image/".$image_name;
				$consname2="image/thumb".$image_name;
				$copied = copy($_FILES['cons_image']['tmp_name'], $consname);
				$copied = copy($_FILES['cons_image']['tmp_name'], $consname2);


					$table = $_POST['radio'];
					echo $table;
					$run=mysql_query ('SELECT max(id) from general') or die(mysql_error());
					$lastid = mysql_fetch_row($run)or die(mysql_error());
					$lastid=$lastid[0]or die(mysql_error());
					$sql="UPDATE general SET image= '$consname2'  WHERE id= '$lastid'"or die(mysql_error());
					$query = mysql_query($sql)or die(mysql_error());
				//we verify if the image has been uploaded, and print error instead
				if (!$copied) {
					echo '<h1>Copy unsuccessfull!</h1>';
					$errors=1;
				}
				else
				{
					// the new thumbnail image will be placed in images/thumbs/ folder
					$thumb_name=$consname2	;
					// call the function that will create the thumbnail. The function will get as parameters 
					//the image name, the thumbnail name and the width and height desired for the thumbnail
					$thumb=make_thumb($consname,$thumb_name,WIDTH,HEIGHT);
				}
			}	
		}
	 }

	  //If no errors registred, print the success message and show the thumbnail image created
	 if(isset($_POST['Submit']) && !$errors) 
	 {
		echo "<h5>Thumbnail created Successfully!</h5>";
		echo '<img src="'.$thumb_name.'">';
		echo $lastid;
	 }

	 echo "<form name=\"newad\" method=\"post\" enctype=\"multipart/form-data\"  action=\"\">";
		echo "<input type=\"file\" name=\"cons_image\"  >";
		echo "<input name=\"Submit\" type=\"submit\"  id=\"image1\" value=\"Upload image\" />";
	 echo "</form>";
		 echo "<br />";
	 echo "<br />";
	 echo "<br />";
	 echo "<br />";
	 echo "<br />";
	 echo "<a href='index.php'> <h3><< Add Another Article</a></h3>";

?>

 

any help with this would be great

 

[Yesideez]

What is the BYTE count of the file you're trying to upload?

 

(right-click the file within Windows and select "Properties" - the byte size will be shown in brackets)

 

Also, can we see the HTML form itself?

[Yesideez]

I have to go and collect the wife from work...

 

You're defining 1MB (1,048,576 bytes) at the start of your script and are you using it in the form?

 

Another thing that can be confusing is that files increase in size when they're being sent over the internet by an 8th.

 

I can't remember if the size set in the form declaration is before or after the file is encoded.

 

If you send a file more than 838,860 bytes then by the time it is encoded it'll be over the 1,048,576 byte count.

[kev wood]

here is the code for the form.

 

echo "<form name=\"newad\" method=\"post\" enctype=\"multipart/form-data\"  action=\"\">";
		echo "<input type=\"file\" name=\"cons_image\"  >";
		echo "<input name=\"Submit\" type=\"submit\"  id=\"image1\" value=\"Upload image\" />";

 

 

[Yesideez]

First off, I see you've declared your MAX_SIZE as 1,048,576 bytes then you're using this line:

if ($sizekb > MAX_SIZE*1024)

which is in effect giving you a 10MB file size limit so either way you should be fine.

 

Upload forms are not something I'm very good at having only done them a couple times but one thing I do know is make sure the folder you're uploading them to is CHMOD to the correct permission allowing the user to upload there. One site I've just read says 777 but that gives absolutely everyone read, write and execute rights and doesn't sound right.

[kev wood]

i though t i was giving it enough bytes for the upload but when i try to upload an image which is over 500kb it tells me that i have exceeded the file limit of 1mb.

 

could it be a problem with the php.ini file

 

i have just tried to upload i file with the file size 944 KB i get this error coming up

 

Fatal error: Allowed memory size of 16777216 bytes exhausted (tried to allocate 2016 bytes) in /home/acmeart/public_html/lock/cms/cons_image.php on line 56

 

line 56 is

 

$src_img=imagecreatefromjpeg($img_name);

[Yesideez]

I just did a bit of digging in scripts online and found this line inside one:

$ini_maxsize = ini_get('upload_max_filesize');

 

Giuve that a go and ECHO it to your browser to see what the file limit on the server is set to.

 

The script I found it in is here:

http://www.zubrag.com/scripts/file-upload-form.php

[kev wood]

i have just checked that out i was coming back to post it the limit is set to 8mb which should be well enough for an image which is less than 1mb.

[redarrow]

it your form look again..

 

must be near to exact as this ok .....

 

<!-- The data encoding type, enctype, MUST be specified as below -->
<form enctype="multipart/form-data" action="__URL__" method="POST">
    <!-- MAX_FILE_SIZE must precede the file input field -->
    <input type="hidden" name="MAX_FILE_SIZE" value="30000" />
    <!-- Name of input element determines name in $_FILES array -->
    Send this file: <input name="userfile" type="file" />
    <input type="submit" value="Send File" />
</form>