Embedding PHP within PHP...

docmombo · December 31, 2008

Okay, I am new at PHP and I think someone may be able to direct me to the right thing to do here. I am trying to run the following code. It does not work since the first PHP line runs into the closing code. Is there a way to embedd PHP code within itself to avoid this.

<?php

if ($slname == "") {

echo "1-800-295-9100";

} else {

echo "<a href='<?php siteloklogout()?>' class=topmenu><b>Logout</b></a>";

}

?>

The siteloklogout() is a call in the SiteLok software we just purchased. That is the code to run that function. I want that code to only appear when the user is logged in.

Any advice?

chronister · December 31, 2008

<?php
   if ($slname == "") {
      echo "1-800-295-9100";
   }   else {
      echo '<a href= "'.siteloklogout().'" class="topmenu"><b>Logout</b></a>';
   }
?>

You don't "embed" php within itself. You simply have to concatenate properly.

Nate

docmombo · December 31, 2008

I put your code it. It seemed to improve things, but I got this on the form.

/demo/htm/login.php?sitelokaction=logout Logout

(Logout) is the link name.

Any thoughts.

Psycho · January 1, 2009

This function siteloklogout() is probably returning some character(s) that are fouling up the HTML code.

Post the actual HTML code that is generated for that link.

docmombo · January 1, 2009

Here it the HTM around it.

<tr>

<?php

if ($slname == "") {

echo "<a href='request.htm' class=topmenu>Request Demo</a>";

} else {

echo $slname;

}

?>

</td>

<?php

if ($slname == "") {

echo "1-800-295-9100";

} else {

echo '<a href= "'.siteloklogout().'" class="topmenu"><b>Logout</b></a>';

}

?>

</td>

</tr>

</table>

Dave

revraz · January 1, 2009

Why not just

echo "<a href= 'siteloklogout()' class='topmenu'><b>Logout</b></a>";

chronister · January 1, 2009

I would bet that if you look into the function siteloklogout() you will find that it echo's something rather than returns it.

Here is an example of what I mean.

<?php
   function echoSomething()
   {
        echo 'This is echo\'d in the function';
   }

  function returnSomething()
{
      return ' This is returned in the function';
}
?>

These 2 functions will do something dramatically different. The first one will echo as soon as it is called. If it is in a file that is included in the header, then it will echo at the very top of the page.

The second one will return something so that you can control where it is echo'd or have it set to a variable and echo that later.

I would bet that yours is echo'ing and I would also bet it is at the top of the page.... am I right?

Nate

docmombo · January 1, 2009

Unfortunately, I don't have access to see the code related to siteloklogout(). I wouldn't be surprised if you are right.

My code does not have a return in it.

Here is my complete page of code. Do you see anything funny?

<?php

ob_start();

session_start();

?>

<?php

$groupswithaccess="PUBLIC";

$loginpage="login.php";

$logoutpage="login.php";

$loginredirect=1;

$startpage="../secure/startpage.php";

require_once("../../slpw/sitelokpw.php");

?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"

"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<head>

<title>Client Login - CompuSource Systems, Inc - Credit Union Data Processor</title>

function random_imglink(){

var myimages=new Array()

myimages[1]="../images/login/loginpic1.jpg"

myimages[2]="../images/login/loginpic2.jpg"

myimages[3]="../images/login/loginpic3.jpg"

myimages[4]="../images/login/loginpic4.jpg"

var ry=Math.floor(Math.random()*myimages.length)

if (ry==0)

ry=1

document.banners.src=myimages[ry]

}

</script>

</head>

<tr>

<tr>

<tr>

</td>

</td>

</td>

<tr>

<?php

if ($slname == "") {

echo "<a href='request.htm' class=topmenu>Request Demo</a>";

} else {

echo $slname;

}

?>

</td>

<?php

if ($slname == "") {

echo "1-800-295-9100";

} else {

echo '<a href= "'.siteloklogout().'" class="topmenu"><b>Logout</b></a>';

}

?>

</td>

</tr>

</table>

</td>

</tr>

<tr>

</td>

</tr>

</table>

</td>

</tr>

<tr>

<?php

include("../testinclude/mainmenu.txt")

?>

</noscript>

</td>

</tr>

</table>

<tr>

<tr>

<td>

<br>

</p>

<tr>

</td>

<tr>

Member Area

</p>

<?php

if ($slname == "") {

} else {

echo "You are already logged in.";

echo '<a href= "'.siteloklogout().'" class="email"><b>Logout</b></a>';

}

?>

<?php if ($msg!="") print $msg; ?>

<form name="siteloklogin" action="<?php print $startpage; ?>" method="GET" onSubmit="return validlogin()">

<?php siteloklogin(); ?>

Username: <input type="text" name="username" value""><br><br>

Password: <input type="password" name="password" value=""><br><br>

<a href="javascript: void forgotpw()" title="Forgot your password? Enter username or email & click link" class=subscript>Forgot your password?</a>

</center>

</form>

</td>

</tr>

</table>

</td>

<tr>

<td>

<b>New Member Area</b>

</p>

Welcome to our new Member Area. We have upgraded our Client Login section to be secured behind one simple login.

If you have not registered for your Credit Union login, please register below.

<a href="registerfirst.php" class=email>Register Here!</a>

</p>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

</td>

</tr>

</table>

<?php

include("../testinclude/footerhc.txt")

?>

</td>

</td>

</tr>

</table>

</body>

</html>

<?php

ob_end_flush();

?>

chronister · January 1, 2009

/demo/htm/login.php?sitelokaction=logout Logout

does this appear at the very top of the page?

You can test it out by calling that function somewhere else, by itself.

<?php siteloklogout() ?>

If this prints something on screen, then it echos... if it does not print on screen, then it probably returns data.

BTW, use code tags when you post code. It is the # button above.

Nate

docmombo · January 1, 2009

Thanks for the advice on code. I was looking through help to figure that out. I will fix that.

Yes, that appears on the top of the page.

I will check out the test you suggested.

I think you are right.

I am done for the day - Happy New Year and thanks for all your help.

Psycho · January 1, 2009

Here it the HTM around it.

<table width=100% align=center cellpadding=0 cellspacing=0 valign=top>

<tr>

<td align=center valign=center class=topmenu>

<?php

if ($slname == "") {

echo "<a href='request.htm' class=topmenu>Request Demo</a>";

} else {

echo $slname;

}

?>

</td>

<td align=center valign=bottom class=topmenu>

<?php

   if ($slname == "") {

echo "1-800-295-9100";

   }   else {

echo '<a href= "'.siteloklogout().'" class="topmenu"><b>Logout</b></a>';

   }

?>

</td>

</tr>

</table>

I asked you to post the "the actual HTML code that is generated", i.e. when you bring the page up in your browser, right-click and view source. Then cut and paste the HTML code for that link.

docmombo · January 2, 2009

I'm sorry. I thought you meant something else.

Here is the code you asked for.

<td align=center valign=bottom class=topmenu>
/demo/htm/login.php?sitelokaction=logout<a href= "" class="topmenu"><b>Logout</b></a></td>

Dave

Sign In

Embedding PHP within PHP...

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information