[SOLVED] strpos problem

[s1yman]

Hi,

 

I made a simple script to check what browser some one is using, at the moment it just displays what browser it is on the page, but I'm having problems with opera. My code is;

 

<?php
$browserinfo=$_SERVER['HTTP_USER_AGENT'] ;
print $browserinfo;
echo "<br />";

/*make lowercase*/
$browserstr=strtolower($browserinfo);
echo $browserstr;
echo "<br />";
/*If string contains "firefox" set type to firefox, if not check for other browsers*/
if (strpos($browserstr,"firefox"))
$browsertype="firefox";

elseif (strpos($browserstr,"opera"))
$browsertype="opera";

elseif (strpos($browserstr,"msie"))
$browsertype="msie";

elseif (strpos($browserstr,"safari"))
$browsertype="safari";
/*If none of the above set type to other*/
else
$browsertype="other";

echo $browsertype;
?>

 

browserstr displays "opera/9.63 (windows nt 5.1; u; en) presto/2.1.1" however, browsertype displays "other" it works fine for firefox, explorer and safari. Probably did something simple wrong.

 

Thanks in advance for any help.

[printf]

Use stripos();

 

example...

 

<?php

function get_agent ()
{
$agent = 'other';

if ( false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'safari' ) )
{
	$agent = 'safari';
}
else if ( false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'opera' ) )
{
	$agent = 'opera';
}
else if ( false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'firefox' ) )
{
	$agent = 'firefox';
}
else if ( false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'msie' ) )
{
	$agent = 'msie';
}
else if ( false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'mozilla/4' ) || false !== stripos ( $_SERVER['HTTP_USER_AGENT'], 'mozilla/5' ) )
{
	$agent = 'mozilla';
}

return $agent;
}

/* usage */

echo get_agent ();

?>

[s1yman]

kool, i'll try that.

thanks

[s1yman]

Incase any ever wants to know in future ... my original script didn't work because Opera is labelled as "Presto" no Opera like you'd expect