eddy556 Posted February 22, 2009 Share Posted February 22, 2009 I have the following line: mysql_query("INSERT INTO results (user, movie, input, prediction, error) VALUES('" . $_POST['email'] '" , "' . $Movies[$m]['title'] . '","' . $Movies[$m]["rating"] . '","' . $result . '","' . $err . "' ) ") or die(mysql_error()); However I'm getting mixed up with the opening and closing of "'", can you please have a look? Link to comment https://forums.phpfreaks.com/topic/146353-solved-getting-mixed-up-with-opening-and-closing-strings/ Share on other sites More sharing options...
redarrow Posted February 22, 2009 Share Posted February 22, 2009 You missed a dot that all mate. . $_POST['email'] // . << was missing ok '" <?php mysql_query("INSERT INTO results(user, movie, input, prediction, error) VALUES('" . $_POST['email'] .'" , "' . $Movies[$m]['title'] . '","' . $Movies[$m]["rating"] . '","' . $result . '","' . $err . "' ) ") or die(mysql_error()); ?> Link to comment https://forums.phpfreaks.com/topic/146353-solved-getting-mixed-up-with-opening-and-closing-strings/#findComment-768366 Share on other sites More sharing options...
only one Posted February 22, 2009 Share Posted February 22, 2009 mysql_query("INSERT INTO `results` (`user`, `movie`, `input`, `prediction`, `error`) VALUES('" . $_POST['email'] ."' , '" . $Movies[$m]['title'] . "','" . $Movies[$m]["rating"] . "','" . $result . "','" . $err . "' )") or die(mysql_error()); Link to comment https://forums.phpfreaks.com/topic/146353-solved-getting-mixed-up-with-opening-and-closing-strings/#findComment-768367 Share on other sites More sharing options...
redarrow Posted February 22, 2009 Share Posted February 22, 2009 Here a safer code for you, with database protection in place. <?php mysql_query("INSERT INTO results(user, movie, input, prediction, error) VALUES('" . mysql_real_escape_string($_POST['email']) .'" , "' .mysql_real_escape_string($Movies[$m]['title']) . '","' . mysql_real_escape_string($Movies[$m]["rating"]) . '","' . mysql_real_escape_string($result) . '","' . mysql_real_escape_string($err) . "' ) ") or die("Database insert error\n".mysql_error()); ?> Link to comment https://forums.phpfreaks.com/topic/146353-solved-getting-mixed-up-with-opening-and-closing-strings/#findComment-768369 Share on other sites More sharing options...
Cal Posted February 22, 2009 Share Posted February 22, 2009 Redarrow, yours still have a little mistake (the single quote is in a wrong place): Fixed here: <?php mysql_query("INSERT INTO results(user, movie, input, prediction, error) VALUES('" . mysql_real_escape_string($_POST['email']) ."' , '" .mysql_real_esape_string($Movies[$m]['title']) . "','" . mysql_real_esape_string($Movies[$m]["rating"]) . "','" . mysql_real_escape_string($result) . "','" . mysql_real_esape_string($err) . "' ) ") or die(mysql_error()); ?> Link to comment https://forums.phpfreaks.com/topic/146353-solved-getting-mixed-up-with-opening-and-closing-strings/#findComment-768370 Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.