[SOLVED] Getting mixed up with opening and closing strings

[eddy556]

I have the following line:

 

mysql_query("INSERT INTO results 
(user, movie, input, prediction, error)
VALUES('" . $_POST['email'] '" , "' . $Movies[$m]['title'] . '","' . $Movies[$m]["rating"] . '","' . $result . '","' . $err . "' ) ") 
or die(mysql_error()); 

 

However I'm getting mixed up with the opening and closing of "'", can you please have a look?

[redarrow]

You missed a dot that all mate.

 

. $_POST['email']  // .  << was missing ok '"

<?php
mysql_query("INSERT INTO results(user, movie, input, prediction, error)
VALUES('" . $_POST['email'] .'" , "' . $Movies[$m]['title'] . '","' . $Movies[$m]["rating"] . '","' . $result . '","' . $err . "' ) ")
or die(mysql_error()); 
?>

[only one]

mysql_query("INSERT INTO `results`

(`user`, `movie`, `input`, `prediction`, `error`)

VALUES('" . $_POST['email'] ."' , '" . $Movies[$m]['title'] . "','" . $Movies[$m]["rating"] . "','" . $result . "','" . $err . "' )")

or die(mysql_error());

[redarrow]

Here a safer code for you, with database protection in place.

<?php
mysql_query("INSERT INTO results(user, movie, input, prediction, error)
VALUES('" . mysql_real_escape_string($_POST['email']) .'" , "' .mysql_real_escape_string($Movies[$m]['title']) . '","' . mysql_real_escape_string($Movies[$m]["rating"]) . '","' . mysql_real_escape_string($result) . '","' . mysql_real_escape_string($err) . "' ) ")
or die("Database insert error\n".mysql_error()); 
?>

[Cal]

Redarrow, yours still have a little mistake (the single quote is in a wrong place):

 

Fixed here:

 

<?php
mysql_query("INSERT INTO results(user, movie, input, prediction, error)
VALUES('" . mysql_real_escape_string($_POST['email']) ."' , '" .mysql_real_esape_string($Movies[$m]['title']) . "','" . mysql_real_esape_string($Movies[$m]["rating"]) . "','" . mysql_real_escape_string($result) . "','" . mysql_real_esape_string($err) . "' ) ")
or die(mysql_error()); 
?>