getimagesize() only works sometimes?! Please help

[br3nn4n]

I have some really simple code (that needs to be reworked actually) that just takes a JPEG image and resizes it.

 

For SOME REASON it will only work on maybe half the files I feed it. It returns nothing otherwise for no reason.

 

The errors come out as:

 

  Quote

Notice: Undefined variable: new_width in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 28

 

Notice: Undefined variable: new_height in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 28

 

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 28

 

Notice: Undefined variable: new_width in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 30

 

Notice: Undefined variable: new_height in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 30

 

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 30

 

Warning: imagejpeg(): supplied argument is not a valid Image resource in /hermes/bosweb/web019/b193/ipw./public_html/img.php on line 33

 

My script is as follows:

 

<?PHP
// The file
$src=$_GET['src'];
if ($src == "") {
$src = "noimage"; 
   }
$filename = "images/articles/" . $src . ".jpg";

// Get new dimensions
list($width, $height) = getimagesize($filename);

if ($width > $height) {
$new_width=350;
$new_height=($height/$width)*350;
} 


// Resample
$image_p = imagecreatetruecolor($new_width, $new_height);
$image = imagecreatefromjpeg($filename);
imagecopyresampled($image_p, $image, 0, 0, 0, 0, $new_width, $new_height, $width, $height);


$end = imagejpeg($image_p,'',70);

?>

 

It works for some images, it doesn't for others...? Any idea why? I really need it to always work.

 

Thanks so much in advance!

[tivrfoa]

make sure it is really an jpg image. if you save a png image from the internet as jpg, so I think it won't work.

[br3nn4n]

No, thanks but that's not the problem...I'm always careful about that. I'm thinking it may be the way I get the width and height (with the list function) and maybe it's not reading the width and height. Could this be possible?

[Psycho]

I think I see the error.

 

You first get the width & height of the image and store the values in $width & $height

list($width, $height) = getimagesize($filename);

 

Then you have this IF statment that will set the values of $new_width and $new_height

if ($width > $height) {
$new_width=350;
$new_height=($height/$width)*350;
} 

 

Then later in the code you attempt to use additional image functions using $new_width & $new_height.

 

But, if the IF statment was not true (i.e. The width is not greater than height) then the variables $new_width & $new_height are never defined!

[br3nn4n]

Thank you so much! I'm stupid like that some times