foreverhex Posted July 19, 2006 Share Posted July 19, 2006 Im in the begining stages of writing an upload script. i want the results page (below) to show the image. Everything seems ok but the image comes out broken and as <img src="/art/1">. 1!!! what? Here is my code.[code]<?phpif($_GET[action]=="art") {$target_path = "art/";$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {//Rename the file$artnama = basename( $_FILES['uploadedfile']['name']);$artdir = 'art/';$randomnum = md5(mktime());$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");echo 'Your art has been up loaded! <br /> <img src="/art/' . $newfilename . '">';} else{ echo "There was an error uploading the file, please try again!";} } ?>[/code] Quote Link to comment Share on other sites More sharing options...
redarrow Posted July 19, 2006 Share Posted July 19, 2006 try that ok[code]<?phpif($_GET[action]=="art") {$target_path = "art/";$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {//Rename the file$artnama = basename( $_FILES['uploadedfile']['name']);$artdir = 'art/';$randomnum = md5(mktime());$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");echo "Your art has been up loaded! <br /> <img src= '$target_path . $newfilename '>";} else{ echo "There was an error uploading the file, please try again!";} } ?>[/code] Quote Link to comment Share on other sites More sharing options...
foreverhex Posted July 19, 2006 Author Share Posted July 19, 2006 No that didnt help it made the img src=%20.%201 . I wonder if Im even allowed to do [code]$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");[/code] ? It makes since but all the examples I've seen never does this. Quote Link to comment Share on other sites More sharing options...
foreverhex Posted July 19, 2006 Author Share Posted July 19, 2006 I had to switch the $newfilename around. [code]<?phpif($_GET[action]=="art") {$target_path = "art/";$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {//Rename the file$artnama = basename( $_FILES['uploadedfile']['name']);$artdir = 'art/';$randomnum = md5(mktime());rename("$artdir$artnama", "$artdir$randomnum$artnama");$newfilename = $artdir . $randomnum . $artnama;echo 'Your art has been up loaded! <br /> <img src="' . $newfilename . '">';} else{ echo 'There was an error uploading the file, please try again!';} } ?>[/code]Doesnt seem smart but it works. Quote Link to comment Share on other sites More sharing options...
redarrow Posted July 19, 2006 Share Posted July 19, 2006 well done! Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.