An issue with renam I think... [Solved]

[foreverhex]

Im in the begining stages of writing an upload script. i want the results page (below) to show the image. Everything seems ok but the image comes out broken and as <img src="/art/1">. 1!!! what? Here is my code.

[code]<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());

$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");

echo 'Your art has been up loaded! <br /> <img src="/art/' . $newfilename . '">';



} else{
    echo "There was an error uploading the file, please try again!";
}
}
?>[/code]

[redarrow]

try that ok
[code]
<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());

$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");

echo "Your art has been up loaded! <br /> <img src= '$target_path . $newfilename '>";



} else{
    echo "There was an error uploading the file, please try again!";
}
}
?>
[/code]

[foreverhex]

No that didnt help it made the img src=%20.%201 . I wonder if Im even allowed to do [code]$newfilename = rename("$artdir$artnama", "$artdir$randomnum$artnama");[/code] ? It makes since but all the examples I've seen never does this.

[foreverhex]

I had to switch the $newfilename around.
[code]
<?php

if($_GET[action]=="art")
{

$target_path = "art/";
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {

//Rename the file
$artnama = basename( $_FILES['uploadedfile']['name']);
$artdir = 'art/';
$randomnum = md5(mktime());
rename("$artdir$artnama", "$artdir$randomnum$artnama");

$newfilename = $artdir . $randomnum . $artnama;

echo 'Your art has been up loaded! <br /> <img src="' . $newfilename . '">';


} else{
    echo 'There was an error uploading the file, please try again!';
}
}
?>[/code]Doesnt seem smart but it works.

[redarrow]

well done!