[SOLVED] MySQL/PHP Probs -- single insert somehow inserting 3 rows!

[thepip3r]

		foreach ($_POST as $key=>$val) {
		if ($val !== "") {
			if ($key == "q1" || $key == "q2" || $key == "q3" || $key == "q4") {
				$val = addslashes(htmlentities($val));
				$q = "INSERT INTO survey_question_answers (sqaid, sqid, vc, txt) 
						VALUES(NULL, '".substr($key,1,1)."', '$val', '')";
			} elseif ($key == "q5") {
				$val = addslashes(htmlentities($val));
				$q = "INSERT INTO survey_question_answers (sqaid, sqid, vc, txt) 
						VALUES(NULL, '".substr($key,1,1)."', '', '$val')";
				echo "$q <br>";
			}
			$r = mysql_query($q);
			if (!$r) { errorHandler("mysql", 1, 1); }
		}

 

somehow my q5 area is inserting 3 rows.  i'm echoing out my query and it's only writing to the screen once so I don't see why I'm getting three rows inserted into my db... any ideas?  Here is an example set of my insert:

 

INSERT INTO survey_question_answers (sqaid, sqid, vc, txt) VALUES(NULL, '5', '', 'test')

 

[PFMaBiSmAd]

Your page is probably being requested multiple times by your browser. What browser are you using and what is your form code - do you have any javascript code that submits the form, along with the browser's normal form submission?

[Brian W]

Try

$q = "INSERT INTO survey_question_answers (sqaid, sqid, vc, txt)  
VALUES(NULL, '".substr($key,1,1)."', '', '$val') LIMIT 1";

I've seen phpMyAdmin use the LIMIT 1 before (i think) for inserts. IDK why it would be adding 3

[mrMarcus]

always use LIMIT 1 when doing single queries for starters.

[PFMaBiSmAd]

LIMIT on an INSERT is invalid.

[Brian W]

meh, worth a shot.

any better plans?

[PFMaBiSmAd]

I'm still kind of waiting to learn what browser and what the form code looks like, because FF will request a page twice under certain conditions and it sounds like some javascript validation code is probably submitting the form along with the normal browser form submission.

 

It's also possible that url rewriting will cause the browser to request a page twice. Are you doing any url rewriting?

[thepip3r]

Sorry was afk for a bit... I'm using Chrome and no, i'm currently not using any javascript at all...

[thepip3r]

addon:  i just tested with internet exploder and it's still adding 3 entries.

[PFMaBiSmAd]

Then it is something elsewhere in your code or you have rows leftover in the database from some previous testing.

[thepip3r]

well that's really the problem PFM -- i'm of the same mind except that little snippet of code is the ONLY place where I have insert statements and when I run through the complete web survey, the 4 radio buttosn that precede it enter fine, it's only when I tried to break out this html text field to write to a TEXT column when the problem started occurring so i know it has to do with this specific area of code.  but like i said, i'm echoing out to see if the loop is done a bunch of times but it doesn't appear to be.  check out the survey for yourself:

 

http://www.zigsdigs.com/trigeo/survey/

[xylex]

foreach ($_POST as $key=>$val) {
	if ($val !== "") {
		if ($key == "q1" || $key == "q2" || $key == "q3" || $key == "q4") {
		} elseif ($key == "q5") {
		}
		$r = mysql_query($q);
	}
}

 

You're running the query every time whether or not $key matches the if/elseif, so the post key=> value pairs for "submit" and "token" are causing a query to be run with the last set value of $q.

[PFMaBiSmAd]

Good job, xylex is correct. Your hidden field and submit button $_POST variables are causing two extra queries.

[thepip3r]

ah yes.... it's because i moved my $r = mysql_query($q); outside of my conditional and since the last insert is alwys the text field, it's running through submit and token.  Thanx for the beautiful eyes xylex.

 

Edit:  thanx for both of your assistances guys!