Jump to content

how to cut this duplicated code down?


pouncer

Recommended Posts

    		foreach ($rss_xml->channel->item as $item) {
        		$item_title = $item->title;
        		$item_link = $item->link;
        		$item_description = $item->description;
        		
			echo "
			<h3><a href='$item_link'>$item_title</a></h3>
			<p>$item_description</p>
			<p><a href='$item_link'>Continue reading $item_title</a></p>
			\n";
        	}

	foreach ($rss_xml->item as $item) {
        		$item_title = $item->title;
        		$item_link = $item->link;
        		$item_description = $item->description;
        		
			echo "
			<h3><a href='$item_link'>$item_title</a></h3>
			<p>$item_description</p>
			<p><a href='$item_link'>Continue reading $item_title</a></p>
			\n";
        	}

 

the only thing that is different is the 'foreach' lines

 

foreach ($rss_xml->channel->item as $item)

foreach ($rss_xml->item as $item)

 

but the stuff inside it is the same. so is there a way to cut down the amount of duplicated code?

Link to comment
Share on other sites

yeah.. create a function!



<?php
function myFunc($start)
{
foreach ($start as $item)
{
	$item_title = $item->title;
	$item_link = $item->link;
	$item_description = $item->description;
	echo "<h3><a href='$item_link'>$item_title</a></h3>
	<p>$item_description</p>
	<p><a href='$item_link'>Continue reading $item_title</a></p>";
}
}
myFunc($rss_xml->channel->item);
myFunc($rss_xml->item);
?>

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.