pouncer Posted April 7, 2009 Share Posted April 7, 2009 foreach ($rss_xml->channel->item as $item) { $item_title = $item->title; $item_link = $item->link; $item_description = $item->description; echo " <h3><a href='$item_link'>$item_title</a></h3> <p>$item_description</p> <p><a href='$item_link'>Continue reading $item_title</a></p> \n"; } foreach ($rss_xml->item as $item) { $item_title = $item->title; $item_link = $item->link; $item_description = $item->description; echo " <h3><a href='$item_link'>$item_title</a></h3> <p>$item_description</p> <p><a href='$item_link'>Continue reading $item_title</a></p> \n"; } the only thing that is different is the 'foreach' lines foreach ($rss_xml->channel->item as $item) foreach ($rss_xml->item as $item) but the stuff inside it is the same. so is there a way to cut down the amount of duplicated code? Quote Link to comment https://forums.phpfreaks.com/topic/153071-how-to-cut-this-duplicated-code-down/ Share on other sites More sharing options...
MadTechie Posted April 7, 2009 Share Posted April 7, 2009 yeah.. create a function! <?php function myFunc($start) { foreach ($start as $item) { $item_title = $item->title; $item_link = $item->link; $item_description = $item->description; echo "<h3><a href='$item_link'>$item_title</a></h3> <p>$item_description</p> <p><a href='$item_link'>Continue reading $item_title</a></p>"; } } myFunc($rss_xml->channel->item); myFunc($rss_xml->item); ?> Quote Link to comment https://forums.phpfreaks.com/topic/153071-how-to-cut-this-duplicated-code-down/#findComment-803969 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.