Las Venturas Roleplay Website

[R4nk3d]

ok and so do i just put this at the top of the login, register, and edit scripts?

[darkfreaks]

yes just call all your variables

 

 

like:

<?php
$user= $_POST['user'];
$user= array_map('stripslashes_deep',$user) //combines function with the $user variable
?>

[R4nk3d]

so tell me if my plan will work:

 

ill put this code into 1 file in my sources directory, then include it on top of my edit, register, and login pages. Then for the variables ill just change them to what you just typed out for me.

[darkfreaks]

pretty much

[R4nk3d]

ok cool. thanks man. anything else you see?

[darkfreaks]

if your just going to use the functions with array_map() and include the functions from another file  get rid of

<?php
if(get_magic_quotes_gpc()){}
if(!get_magic_quotes_gpc()){}
?>

 

and just array map the functions into the variables

[R4nk3d]

ok ill try it

[darkfreaks]

also when your done with that post the code for each page so i know that your doin it right

[R4nk3d]

k, heres what i got now:

require("./sources/string_array_maps.php");
$user = $_POST["Username"];
$pass = $_POST["Password"];
//.... continues on

<?php
function stripslashes_deep($value)
    {
        $value = is_array($value) ?
                    array_map('stripslashes_deep', $value) :
                    stripslashes($value);
        return $value;
    }
    $_POST = array_map('stripslashes_deep', $_POST);
    $_GET = array_map('stripslashes_deep', $_GET);
    $_COOKIE = array_map('stripslashes_deep', $_COOKIE);
    $_REQUEST = array_map('stripslashes_deep', $_REQUEST);
function clean_post_var($var){
      $var=mysql_real_escape_string(trim(strip_tags($var)));
      $var=htmlspecialchars($var,ENT_QUOTES);
      return filter_var($var,FILTER_SANITIZE_STRING);
}
$_POST = array_map('clean_post_var', $_POST);
    $_GET = array_map('clean_post_var', $_GET);
    $_COOKIE = array_map('clean_post_var', $_COOKIE);
    $_REQUEST = array_map('clean_post_var', $_REQUEST);
?>

This look right?

[darkfreaks]

Include.php

<?php
   function stripslashes_deep($value)
    {
        $value = is_array($value) ?
                    array_map('stripslashes_deep', $value) :
                    stripslashes($value);
        return $value;
    }
  
   function clean_post_var($var){
      $var=mysql_real_escape_string(trim(strip_tags($var)));
      $var=htmlspecialchars($var,ENT_QUOTES);
      return filter_var($var,FILTER_SANITIZE_STRING);
   }
  
?>

page.php:

[code]<?php
$user = $_POST["Username"];
$user.= array_walk($user,'stripslashes_deep');
$user.= array_walk($user,'clean_post_var');
///etc and so on///
?>

[/code]

[R4nk3d]

ok, i dont have it exactly like that, but i do have it working, try it out

[R4nk3d]

i see that ur tryin it, heres what it actually is putting in the database.... (screenshot)

 

[attachment deleted by admin]

[darkfreaks]

ok screw the array shit just do this:

<?php
include "functionfile.php";
$user=$_POST['user'];
$user.=stripslashes_deep(clean_post_var($user));
?>

[R4nk3d]

haha, ok. changing now

 

actually, now that i think about it. wouldnt making it $user .=...

add it to the end? shouldnt it be $user = $_Post

$user = strip....?

[darkfreaks]

it doesnt matter if you put it all ine one variable or make it 3 variables it still works like i did it

[R4nk3d]

it doesnt matter if you put it all ine one variable or make it 3 variables it still works like i did it

no, if i put root as the username, it inputs it into the db as rootroot because im adding it again. so it needs to be $user = strip...

 

but yeah, its working

[darkfreaks]

uhm no its noti still see injection

[R4nk3d]

nothin is being injected.

[darkfreaks]

delete all the injection stuff just incase the scanner is picking it up and ill scan again

[R4nk3d]

all those users are deleted. nothing is being injected.

 

the user table is "users"

admin = adminlevel (1 for admin)

try whatever u can, i dont see it

[darkfreaks]

scrreeenshot

 

[attachment deleted by admin]

[R4nk3d]

i dont see anything being injected, u cant execute any commands at all

[darkfreaks]

i believe my scanner would beg to differ. being cocky about it is unwise. finding out why it is picking up is more smart

[darkfreaks]

also i would suggest reading up on PDO and MYSQLI prepared statements

 

http://stackoverflow.com/questions/60174/best-way-to-stop-sql-injection-in-php

[R4nk3d]

alright will do