[SOLVED] Header Error

Akenatehm · April 19, 2009

Hey Guys,

I get this error:

404 Not Found

The requested URL /imagecloud/<br /><b>Warning</b>: Cannot modify header information - headers already sent by (output started at /Library/WebServer/Documents/imagecloud/register.php:51) in <b>/Library/WebServer/Documents/imagecloud/register.php</b> on line <b>44</b><br /> was not found on this server.

With this code:

<?php
session_start();
include 'functions.php';
include 'logregfunctions.php';
function registerUser()
{
$username = mysql_escape_string($_POST['username']);
$password = mysql_escape_string( $_POST['password']);
$confirmpassword = mysql_escape_string($_POST['confirmpassword']);
$email = mysql_escape_string($_POST['email']);
$date = date('l jS \of F Y');

if (isset($_POST['submit']))
{
if ($password != $confirmpassword)
{
$result = '<font color="red"> Your Passwords Did Not Match. Please use the Back button on your browser to go back and provide matching passwords.  </font>';
}
else
{
$password = md5($password);
$dbhost = "localhost";
$dbuser = "user";
$dbpass = "pass";
$db = "db";

$connect = mysql_connect($dbhost, $dbuser, $dbpass) or die(mysql_error());
$selectdb = mysql_select_db($db) or die(mysql_error());

$checkusername = mysql_query("SELECT * FROM users WHERE username = '$username'") or die(mysql_error());
if (mysql_num_rows($checkusername) == 1)
{
$result = '<font color="red"> Sorry, that username already exists. Please use the Back button on your browser to go back and choose a new username.</font>';
}
else{
$query = mysql_query("INSERT into users (username, password, email, joindate) values('$username','$password','$email','$date')") or die(mysql_error());
mysql_close($connect);
$result = '<font color="green"> Congratulations, you have succesfully registered. Please Login in the sidebar to gain access to upload your photos and your account management</font>';
}
}
}
$_SESSION['result'] = $result;
$_SESSION['resulttopic'] = "Site - Registration";
header('Location: result.php');
}
?>
<html>
<head>
<title>Site  - Registration</title>
<link rel="stylesheet" type="text/css" href="styles.css">
<script type='text/javascript'>
function formValidator(){
// Make quick references to our fields
var name = document.getElementById('username');
var password = document.getElementById('password');
var confirmpassword = document.getElementById('confirmpassword');
var email = document.getElementById('email');


// Check each input in the order that it appears in the form!
if(notEmpty(name,"Please Enter Your Desired Username")){		
		if(notEmpty(password"Please Enter a Password")){		
			if(notEmpty(email,"Please Enter Your Email Address")){
				if(emailValidator(email, "Please Enter a Valid Email Address")){
						return true;
						}
					}
				} 
		}

return false;

}
return true;
}else{
alert(helperMsg);
return false;
}
}
function notEmpty(elem, helperMsg){
if(elem.value.length == 0){
	alert(helperMsg);
	elem.focus(); // set the focus to this input
	return false;
}
return true;
}

function emailValidator(elem, helperMsg){
var emailExp = /^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/;
if(elem.value.match(emailExp)){
	return true;
}else{
	alert(helperMsg);
	elem.focus();
	return false;
}
}
</script>
</head>

<body>
<?php writeHeader(); ?>
<div class="wrapper">
	<div class="mainleft">
		<div class="navbar"><?php whatPage('register');?></div>
				<br />
				<br /> 
				<br />
				<br />

		<div class="loginbar">
			<li class="topmodule">Login</p>
				<form name="login" method="post" action="<?php checkUserLogin();?>">
					<li class="form" id="userlist">  Username: <input type="text" name="username" id="textinput" size="12"></li>
					<li class="form" id="passlist">Password:   <input type="password" name="password" id="textinput" size="12"></li>
					<li class="bottommodule"><input type="submit" name="submit" class="submit" value="Login" size="12"></li>
				</form>
		</div>		
	</div>

	<div class="maincenter" id="scangreybg">				
		<p class="maincbheader" >Image Cloud Registration!</p>
		<p class="maincbtext"></p>

		<table class="regform">
		<form id="regform" action="<?php registerUser();?>" method="post" onSubmit="return formValidator()">
			<tr>
				<td class="regform" width="250px">
					<td class="regform" width="120px">
						Username:
					</td>
				<td class="regform">
					<input type="text" name="username" id="username" class="regusername" size="12">
				</td>
			</td>

			<td class="regform">
				<td class="regform">
				</td>
			</td >
			</tr>

			<tr>
				<td class="regform" width="250px">
					<td class="regform" width="120px">
						Password:
					</td>
					<td class="regform">
						<input type="password" name="password" id="password" class="regusername" size="12">
					</td>
				</td>
			<td class="regform">
				<td class="regform">

				</td>
			</td >
			</tr>							

			<tr>
				<td class="regform" width="250px">
					<td class="regform" width="120px">
						Confirm Password:
					</td>
					<td class="regform">
						<input type="password" name="confirmpassword" id="confirmpassword" class="regusername" size="12" >
					</td>
				</td>
			<td class="regform">
				<td class="regform">

				</td>
			</td >
			</tr>		

			<tr>
				<td class="regform" width="250px">
					<td class="regform" width="120px">
						Email:
					</td>
					<td class="regform">
						<input type="text" name="email" id="email" class="regusername" size="12">
					</td>
				</td>
			<td class="regform">
				<td class="regform">

				</td>
			</td >
			</tr>	

			<tr>
				<td class="regform" width="250px">
					<td class="regform" width="120px">
						</td>
					<td class="regform">
						<input type="submit" name="submit" id="submit" class="register" value="Register!">
					</td>
				</td>
			</tr>	

			<tr>
			<td class="regform">
							</td>
			<td class="regform" width="200px"></td>
			</tr>
			</form>
		</table>
	</div>	

	<div class="belowmaincb" id="scangreybg">
	<p class="numbertext"><?php checkHowManyImages();?></p> <br />
	<p class="bigtext"> Images Uploaded and Counting</p><br />
	<p class="tinytext"> Footer</p>
	</div>


</div>
</body>

Help would be GREATLY appreciated. This is really annoying me and I have searched everywhere.

Thanks,

Cody

PFMaBiSmAd · April 19, 2009

The error is caused because your page sends HTML to the browser, then it attempts to redirect using a header(). A header() must be sent before anything else is sent to the browser.

But you have a bigger problem, because the header() is being sent when your registerUser() function is being called. You have put the registerUser() function call in your <form tag as the action="..." parameter. Forms and php don't work that way. The action="..." parameter must be a URL of a page that is requested when the form data is submitted. What is happening now is when the page outputs the form, it is calling the registerUser() function at that point in the code when the <form tag is being output to the browser, which attempts to redirect to result.php.

You must put a URL in as the action="..." parameter in your form tag. The code on that page that the URL goes to must then process the form data and determine what to do with it.

Akenatehm · April 19, 2009

Thanks. I read through your help and fixed the page. It works great now.

Sign In

[SOLVED] Header Error

Recommended Posts

Akenatehm

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Akenatehm

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information