[SOLVED] Need help in removing validation from upload files script

agron · May 20, 2009

I have this form in my website with one upload file field. I don't want the upload file function to be mandatory. Here I have included the .php code executing the form. Can anyone tell me what do I need to change in order not to have the upload mandatory. Here is my code:

<?php
// Receiving variables

@$pfw_ip= $_SERVER['REMOTE_ADDR'];

@$name = addslashes($_POST['name']);

@$companyname = addslashes($_POST['companyname']);

@$address = addslashes($_POST['address']);

@$city = addslashes($_POST['city']);

@$stateprovince = addslashes($_POST['stateprovince']);

@$postalzipcode = addslashes($_POST['postalzipcode']);

@$country = addslashes($_POST['country']);

@$phonenumber = addslashes($_POST['phonenumber']);

@$phonenrextention = addslashes($_POST['phonenrextention']);

@$contactfax = addslashes($_POST['contactfax']);

@$email = addslashes($_POST['email']);

@$services = addslashes($_POST['services']);

@$servicenotinlistdescription = addslashes($_POST['servicenotinlistdescription']);

@$materialtype = addslashes($_POST['materialtype']);

@$materialnotinlistdescription = addslashes($_POST['materialnotinlistdescription']);

@$fileupload_Name = $_FILES['fileupload']['name'];

@$fileupload_Size = $_FILES['fileupload']['size'];

@$fileupload_Temp = $_FILES['fileupload']['tmp_name'];

@$fileupload_Mime_Type = $_FILES['fileupload']['type'];

@$dimensionheight = addslashes($_POST['dimensionheight']);

@$dimensionswidth = addslashes($_POST['dimensionswidth']);

@$dimensionslength = addslashes($_POST['dimensionslength']);

@$dimensionsdia = addslashes($_POST['dimensionsdia']);

@$additionalcomments = addslashes($_POST['additionalcomments']);

function RecursiveMkdir($path)

{

if (!file_exists($path))

{

RecursiveMkdir(dirname($path));

mkdir($path, 0777);

}

}

// Validation

if( $fileupload_Size == 0)

{

header("Location: fail.html");

exit;

}

if( $fileupload_Size >10000000000)

{

//delete file

unlink($fileupload_Temp);

header("Location: fail.html");

exit;

}

if( $fileupload_Mime_Type != "image/jpeg" )

{

unlink($fileupload_Temp);

header("Location: fail.html");

exit;

}

$uploadFile = "uploads/".$fileupload_Name ;

if (!is_dir(dirname($uploadFile)))

{

@RecursiveMkdir(dirname($uploadFile));

}

else

{

@chmod(dirname($uploadFile), 0777);

}

@move_uploaded_file( $fileupload_Temp , $uploadFile);

chmod($uploadFile, 0644);

$fileupload_URL = "http://website.com/uploads/".$fileupload_Name ;

//Sending Email to form owner

$pfw_header = "From: $email\n"

. "Reply-To: $email\n";

$pfw_subject = "h8";

$pfw_email_to = "[email protected]";

$pfw_message = "Visitor's IP: $pfw_ip\n"

. "name: $name\n"

. "companyname: $companyname\n"

. "address: $address\n"

. "city: $city\n"

. "stateprovince: $stateprovince\n"

. "postalzipcode: $postalzipcode\n"

. "country: $country\n"

. "phonenumber: $phonenumber\n"

. "phonenrextention: $phonenrextention\n"

. "contactfax: $contactfax\n"

. "email: $email\n"

. "services: $services\n"

. "servicenotinlistdescription: $servicenotinlistdescription\n"

. "materialtype: $materialtype\n"

. "materialnotinlistdescription: $materialnotinlistdescription\n"

. "fileupload: $fileupload_URL\n"

. "dimensionheight: $dimensionheight\n"

. "dimensionswidth: $dimensionswidth\n"

. "dimensionslength: $dimensionslength\n"

. "dimensionsdia: $dimensionsdia\n"

. "additionalcomments: $additionalcomments\n";

@mail($pfw_email_to, $pfw_subject ,$pfw_message ,$pfw_header ) ;

header("Location: success.html");

?>

I don't have a lot of .php knowledge so if someone will rewrite the above code and post it, would be really appreciated

Thank you very much in advance,

MadTechie · May 20, 2009

remove

// Validation
if( $fileupload_Size == 0)
{
header("Location: fail.html");
exit;
}

and

if( $fileupload_Mime_Type != "image/jpeg" )
{
unlink($fileupload_Temp);
header("Location: fail.html");
exit;
}

and WOW @ @'s

agron · May 20, 2009

I would like to keep all the other validations like filesize and format, I just don't want it to be mandatory. How can I do that?

MadTechie · May 20, 2009

Okay, remove them but add

this

<?php
// Validation
if(!empty($fileupload_Name))
{
if( $fileupload_Size == 0)
{
	header("Location: fail.html");
	exit;
}
if( $fileupload_Mime_Type != "image/jpeg" )
{
	unlink($fileupload_Temp);
	header("Location: fail.html");
	exit;
}
}
?>

this check to see if a file was used if it was then checks

agron · May 20, 2009

Now I am getting the "500 Internal Server Error" Here is the code again:

<?php
// Receiving variables

@$pfw_ip= $_SERVER['REMOTE_ADDR'];

@$name = addslashes($_POST['name']);

@$companyname = addslashes($_POST['companyname']);

@$address = addslashes($_POST['address']);

@$city = addslashes($_POST['city']);

@$stateprovince = addslashes($_POST['stateprovince']);

@$postalzipcode = addslashes($_POST['postalzipcode']);

@$country = addslashes($_POST['country']);

@$phonenumber = addslashes($_POST['phonenumber']);

@$phonenrextention = addslashes($_POST['phonenrextention']);

@$contactfax = addslashes($_POST['contactfax']);

@$email = addslashes($_POST['email']);

@$services = addslashes($_POST['services']);

@$servicenotinlistdescription = addslashes($_POST['servicenotinlistdescription']);

@$materialtype = addslashes($_POST['materialtype']);

@$materialnotinlistdescription = addslashes($_POST['materialnotinlistdescription']);

@$fileupload_Name = $_FILES['fileupload']['name'];

@$fileupload_Size = $_FILES['fileupload']['size'];

@$fileupload_Temp = $_FILES['fileupload']['tmp_name'];

@$fileupload_Mime_Type = $_FILES['fileupload']['type'];

@$dimensionheight = addslashes($_POST['dimensionheight']);

@$dimensionswidth = addslashes($_POST['dimensionswidth']);

@$dimensionslength = addslashes($_POST['dimensionslength']);

@$dimensionsdia = addslashes($_POST['dimensionsdia']);

@$additionalcomments = addslashes($_POST['additionalcomments']);

function RecursiveMkdir($path)

{

if (!file_exists($path))

{

RecursiveMkdir(dirname($path));

mkdir($path, 0777);

}

}

// Validation

if(!empty($fileupload_Name))

{

if( $fileupload_Size == 0)

{

header("Location: fail.html");

exit;

}

if( $fileupload_Mime_Type != "image/jpeg" )

{

unlink($fileupload_Temp);

header("Location: fail.html");

exit;

}

}

$uploadFile = "uploads/".$fileupload_Name ;

if (!is_dir(dirname($uploadFile)))

{

@RecursiveMkdir(dirname($uploadFile));

}

else

{

@chmod(dirname($uploadFile), 0777);

}

@move_uploaded_file( $fileupload_Temp , $uploadFile);

chmod($uploadFile, 0644);

$fileupload_URL = "http://website.com/uploads/".$fileupload_Name ;

//Sending Email to form owner

$pfw_header = "From: $email\n"

. "Reply-To: $email\n";

$pfw_subject = "Service Request";

$pfw_email_to = "[email protected]";

$pfw_message = "Visitor's IP: $pfw_ip\n"

. "name: $name\n"

. "companyname: $companyname\n"

. "address: $address\n"

. "city: $city\n"

. "stateprovince: $stateprovince\n"

. "postalzipcode: $postalzipcode\n"

. "country: $country\n"

. "phonenumber: $phonenumber\n"

. "phonenrextention: $phonenrextention\n"

. "contactfax: $contactfax\n"

. "email: $email\n"

. "services: $services\n"

. "servicenotinlistdescription: $servicenotinlistdescription\n"

. "materialtype: $materialtype\n"

. "materialnotinlistdescription: $materialnotinlistdescription\n"

. "fileupload: $fileupload_URL\n"

. "dimensionheight: $dimensionheight\n"

. "dimensionswidth: $dimensionswidth\n"

. "dimensionslength: $dimensionslength\n"

. "dimensionsdia: $dimensionsdia\n"

. "additionalcomments: $additionalcomments\n";

@mail($pfw_email_to, $pfw_subject ,$pfw_message ,$pfw_header ) ;

//Sending auto respond Email to visitor

$pfw_header = "From: [email protected]\n"

. "Reply-To: [email protected]\n";

$pfw_subject = "Service Request";

$pfw_email_to = "$email";

$pfw_message = "Your request has been received. A representative will review your request and call you back with an estimate.\n"

. "If you have any questions or concern do not hesitate to call our hotline number at: 111-111-1111\n"

. "\n"

. "Thank you for your business\n"

. "\n"

. "Business name";

@mail($pfw_email_to, $pfw_subject ,$pfw_message ,$pfw_header ) ;

header("Location: success.html");

?>

I do want to thank you a lot for your quick response,

Take care

MadTechie · May 20, 2009

try this

    <?php
    // Receiving variables
    @$pfw_ip= $_SERVER['REMOTE_ADDR'];
    @$name = addslashes($_POST['name']);
    @$companyname = addslashes($_POST['companyname']);
    @$address = addslashes($_POST['address']);
    @$city = addslashes($_POST['city']);
    @$stateprovince = addslashes($_POST['stateprovince']);
    @$postalzipcode = addslashes($_POST['postalzipcode']);
    @$country = addslashes($_POST['country']);
    @$phonenumber = addslashes($_POST['phonenumber']);
    @$phonenrextention = addslashes($_POST['phonenrextention']);
    @$contactfax = addslashes($_POST['contactfax']);
    @$email = addslashes($_POST['email']);
    @$services = addslashes($_POST['services']);
    @$servicenotinlistdescription = addslashes($_POST['servicenotinlistdescription']);
    @$materialtype = addslashes($_POST['materialtype']);
    @$materialnotinlistdescription = addslashes($_POST['materialnotinlistdescription']);
    @$fileupload_Name = $_FILES['fileupload']['name'];
    @$fileupload_Size = $_FILES['fileupload']['size'];
    @$fileupload_Temp = $_FILES['fileupload']['tmp_name'];
    @$fileupload_Mime_Type = $_FILES['fileupload']['type'];
    @$dimensionheight = addslashes($_POST['dimensionheight']);
    @$dimensionswidth = addslashes($_POST['dimensionswidth']);
    @$dimensionslength = addslashes($_POST['dimensionslength']);
    @$dimensionsdia = addslashes($_POST['dimensionsdia']);
    @$additionalcomments = addslashes($_POST['additionalcomments']);

    function RecursiveMkdir($path)
     {
       if (!file_exists($path))
       {
          RecursiveMkdir(dirname($path));
          mkdir($path, 0777);
        }
      }


    // Validation
    if(!empty($fileupload_Name))
    {
       if( $fileupload_Size == 0)
       {
          header("Location: fail.html");
          exit;
       }
       if( $fileupload_Mime_Type != "image/jpeg" )
       {
          unlink($fileupload_Temp);
          header("Location: fail.html");
          exit;
       }
        $uploadFile = "uploads/".$fileupload_Name ;
    if (!is_dir(dirname($uploadFile)))
      {
        @RecursiveMkdir(dirname($uploadFile));
      }else{
      @chmod(dirname($uploadFile), 0777);
      }
    @move_uploaded_file( $fileupload_Temp , $uploadFile);
    chmod($uploadFile, 0644);
    $fileupload_URL = "http://website.com/uploads/".$fileupload_Name ;
    }else{
    	$fileupload_URL ="";
    }
   

    //Sending Email to form owner
    $pfw_header = "From: $email\n"
      . "Reply-To: $email\n";
    $pfw_subject = "Service Request";
    $pfw_email_to = "[email protected]";
    $pfw_message = "Visitor's IP: $pfw_ip\n"
    . "name: $name\n"
    . "companyname: $companyname\n"
    . "address: $address\n"
    . "city: $city\n"
    . "stateprovince: $stateprovince\n"
    . "postalzipcode: $postalzipcode\n"
    . "country: $country\n"
    . "phonenumber: $phonenumber\n"
    . "phonenrextention: $phonenrextention\n"
    . "contactfax: $contactfax\n"
    . "email: $email\n"
    . "services: $services\n"
    . "servicenotinlistdescription: $servicenotinlistdescription\n"
    . "materialtype: $materialtype\n"
    . "materialnotinlistdescription: $materialnotinlistdescription\n"
    . "fileupload: $fileupload_URL\n"
    . "dimensionheight: $dimensionheight\n"
    . "dimensionswidth: $dimensionswidth\n"
    . "dimensionslength: $dimensionslength\n"
    . "dimensionsdia: $dimensionsdia\n"
    . "additionalcomments: $additionalcomments\n";
    @mail($pfw_email_to, $pfw_subject ,$pfw_message ,$pfw_header ) ;

    //Sending auto respond Email to visitor
    $pfw_header = "From: [email protected]\n"
      . "Reply-To: [email protected]\n";
    $pfw_subject = "Service Request";
    $pfw_email_to = "$email";
    $pfw_message = "Your request has been received. A representative will review your request and call you back with an estimate.\n"
    . "If you have any questions or concern do not hesitate to call our hotline number at: 111-111-1111\n"
    . "\n"
    . "Thank you for your business\n"
    . "\n"
    . "Business name";
    @mail($pfw_email_to, $pfw_subject ,$pfw_message ,$pfw_header ) ;

    header("Location: success.html");

    ?>

EDIT: Oh and your welcome,

agron · May 20, 2009

I think I need serious help on this one bro. I am getting the server error again

MadTechie · May 20, 2009

Okay heres a cleaned up version, it looks fine to me

<?php
error_reporting(0);
// Receiving variables
$pfw_ip = $_SERVER['REMOTE_ADDR'];
$name = (! empty($_POST['name'])) ? addslashes($_POST['name']) : "";
$companyname = (! empty($_POST['name'])) ? addslashes($_POST['companyname']) : "";
$address = (! empty($_POST['name'])) ? addslashes($_POST['address']) : "";
$city = (! empty($_POST['name'])) ? addslashes($_POST['city']) : "";
$stateprovince = (! empty($_POST['name'])) ? addslashes($_POST['stateprovince']) : "";
$postalzipcode = (! empty($_POST['name'])) ? addslashes($_POST['postalzipcode']) : "";
$country = (! empty($_POST['name'])) ? addslashes($_POST['country']) : "";
$phonenumber = (! empty($_POST['name'])) ? addslashes($_POST['phonenumber']) : "";
$phonenrextention = (! empty($_POST['name'])) ? addslashes($_POST['phonenrextention']) : "";
$contactfax = (! empty($_POST['name'])) ? addslashes($_POST['contactfax']) : "";
$email = (! empty($_POST['name'])) ? addslashes($_POST['email']) : "";
$services = (! empty($_POST['name'])) ? addslashes($_POST['services']) : "";
$servicenotinlistdescription = (! empty($_POST['name'])) ? addslashes($_POST['servicenotinlistdescription']) : "";
$materialtype = (! empty($_POST['name'])) ? addslashes($_POST['materialtype']) : "";
$materialnotinlistdescription = (! empty($_POST['name'])) ? addslashes($_POST['materialnotinlistdescription']) : "";
$dimensionheight = (! empty($_POST['name'])) ? addslashes($_POST['dimensionheight']) : "";
$dimensionswidth = (! empty($_POST['name'])) ? addslashes($_POST['dimensionswidth']) : "";
$dimensionslength = (! empty($_POST['name'])) ? addslashes($_POST['dimensionslength']) : "";
$dimensionsdia = (! empty($_POST['name'])) ? addslashes($_POST['dimensionsdia']) : "";
$additionalcomments = (! empty($_POST['name'])) ? addslashes($_POST['additionalcomments']) : "";
// File Validation
if (! empty($_FILES['fileupload']['name'])) {
    if ($_FILES['fileupload']['size'] == 0) {
        header("Location: fail.html");
        exit();
    }
    if ($_FILES['fileupload']['type'] != "image/jpeg") {
        unlink($_FILES['fileupload']['tmp_name']);
        header("Location: fail.html");
        exit();
    }
    $uploadFile = "uploads/" . $_FILES['fileupload']['name'];
    if (! is_dir(dirname($uploadFile))) {
        @RecursiveMkdir(dirname($uploadFile));
    } else {
        @chmod(dirname($uploadFile), 0777);
    }
    @move_uploaded_file($_FILES['fileupload']['tmp_name'], $uploadFile);
    chmod($uploadFile, 0644);
    $fileupload_URL = "http://website.com/uploads/" . $_FILES['fileupload']['name'];
} else {
    $fileupload_URL = "No file uploader";
}
//Sending Email to form owner
$pfw_header = "From: $email\r\nReply-To: $email\r\n";
$pfw_subject = "Service Request";
$pfw_email_to = "[email protected]";
$pfw_message = "Visitor's IP: $pfw_ip\n
name: $name\n
companyname: $companyname\n
address: $address\n
city: $city\n
stateprovince: $stateprovince\n
postalzipcode: $postalzipcode\n
country: $country\n
phonenumber: $phonenumber\n
phonenrextention: $phonenrextention\n
contactfax: $contactfax\n
email: $email\n
services: $services\n
servicenotinlistdescription: $servicenotinlistdescription\n
materialtype: $materialtype\n
materialnotinlistdescription: $materialnotinlistdescription\n
fileupload: $fileupload_URL\n
dimensionheight: $dimensionheight\n
dimensionswidth: $dimensionswidth\n
dimensionslength: $dimensionslength\n
dimensionsdia: $dimensionsdia\n
additionalcomments: $additionalcomments\n";
$sentmail = mail($pfw_email_to, $pfw_subject, $pfw_message, $pfw_header);
//Sending auto respond Email to visitor
$pfw_header = "From: [email protected]\r\nReply-To: [email protected]\r\n";
$pfw_subject = "Service Request";
$pfw_email_to = "$email";
$pfw_message = "Your request has been received. A representative will review your request and call you back with an estimate.\n
If you have any questions or concern do not hesitate to call our hotline number at: 111-111-1111\n\n
Thank you for your business\n\nBusiness name";
$sentmail = mail($pfw_email_to, $pfw_subject, $pfw_message, $pfw_header);
header("Location: success.html");
function RecursiveMkdir ($path)
{
    if (! file_exists($path)) {
        RecursiveMkdir(dirname($path));
        mkdir($path, 0777);
    }
}
?>

agron · May 20, 2009

It looks like it is working now. The only qustion I have is this: How do you fix this piece so that I have a 5 mgb file size limit:

// File Validation
if (! empty($_FILES['fileupload']['name'])) {

if ($_FILES['fileupload']['size'] == 0) {

header("Location: fail.html");

exit();

}

Thanks again

MadTechie · May 20, 2009

if ($_FILES['fileupload']['size'] == 0) {

to

if ($_FILES['fileupload']['size'] == 0 || $_FILES['fileupload']['size'] > 5242880) {

note

5000000 would be fine but 5MB in bytes is 5242880

agron · May 20, 2009

I am probably boring you with all these questions but what do I need to do if I want to have 4 extensions: jpeg, jpg, png, gif?

I did this but it isn't working:

if ($_FILES['fileupload']['type'] != "image/gif" AND $fileupload_Mime_Type != "image/jpeg" AND $fileupload_Mime_Type != "image/png" ) {
unlink($_FILES['fileupload']['tmp_name']);

header("Location: fail.html");

exit();

}

Masna · May 20, 2009

I am probably boring you with all these questions but what do I need to do if I want to have 4 extensions: jpeg, jpg, png, gif?

http://php.net/pathinfo

MadTechie · May 20, 2009

Okay

change

if ($_FILES['fileupload']['type'] != "image/gif" AND $fileupload_Mime_Type != "image/jpeg" AND $fileupload_Mime_Type != "image/png" )

to

$validfiles = array("image/gif","image/jpeg","image/png","image/jpeg","image/x-png");
if (!in_array($_FILES['fileupload']['type'] ,$validfiles))

agron · May 20, 2009

Right now I have:

if ($_FILES['fileupload']['type'] != "image/jpeg") {
unlink($_FILES['fileupload']['tmp_name']);

header("Location: fail.html");

exit();

}

and it is working only for "jpeg". I did try your fix but I am getting this error:

Parse error: syntax error, unexpected '}' in /home/..../public_html/form.php on line 46

and line 46 is far from the lines I changed

45) } else {
46) $fileupload_URL = "No file uploader";

47) }

I just need to add a couple of more extensions, jpg, gif, png that's all

Thanks again,

MadTechie · May 20, 2009

if ($_FILES['fileupload']['type'] != "image/jpeg") {
        unlink($_FILES['fileupload']['tmp_name']);
        header("Location: fail.html");
        exit();
    }

should be

$validfiles = array("image/gif","image/jpeg","image/png","image/jpeg","image/x-png");
if (!in_array($_FILES['fileupload']['type'] ,$validfiles)) {
        unlink($_FILES['fileupload']['tmp_name']);
        header("Location: fail.html");
        exit();
    }

agron · May 20, 2009

You are a life saver and I really, really wish you all the best my friend! Take care and thank you very, very much!!!!

Sign In

[SOLVED] Need help in removing validation from upload files script

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Archived

Important Information