[SOLVED] Script Modification

[ballouta]

Hello

I have this working validatiuon script.

 

<script type="text/javascript" language="Javascript" >
<!--
function verification()
{
if(document.registration.username.value == "")  {
   alert("Name required");
   document.registration.username.focus();
   return false;
  }
   else
if(document.registration.email.value == "") {
   alert("Email required");
   document.registration.email.focus();
   return false;
  }
  else
if(document.registration.email.value.indexOf('@') == -1) {
   alert("email not valid");
   document.registration.email.focus();
   return false;
  }
  else
if(document.registration.phone.value == "") {
   alert("Phone number is empty!");
   document.registration.phone.focus();
   return false;
  }
  else
if(document.registration.country.value == "") {
   alert("Country is empty!");
   document.registration.country.focus();
   return false;
  }
return true
}
//-->
</script>

 

i want to add more validation for the username (it should be between 4 and 12 characters)

is there better validation for the email address?

 

many thanks

[fanfavorite]

Try these:

 

username:

 

username = document.registration.username;

if(username.value == "" OR username.length < 4 OR username.length > 12)  {

 

 

email:

 

pattern = /^([a-zA-Z0-9_-])+([\.a-zA-Z0-9_-])*@([a-zA-Z0-9_-])+(\.[a-zA-Z0-9]+)+$/;

if( !pattern.test( document.registration.email.value ) ) {

[Ken2k7]

fanfavorite, I think you're thinking about PHP. JavaScript doesn't work with the keyword OR in a conditional. Also, your condition is wrong. Please check.

[fanfavorite]

What do you mean doesn't work with the keyboard?  Those functions work for me in javascript.

 

if(username.value == "" || username.length < 4 || username.length > 12)  { 

[fanfavorite]

Wow I am tired lol.  Just read your post again and realized you said keyword "OR" lol.  The condition is right.  If the value is null, is less than 4 or greater than 12, then it is invalid. 

[Ken2k7]

Oh really?

 

username.length > 4 really works?

[fanfavorite]

I haven't tested this posted code, but I have done things similar.  At second look, I think it needs to be username.value.length

 

Been looking at code all day, need to get some shuteye. 

[Ken2k7]

Yup, that was it.

[ballouta]

Thanks I just added .value before .length and it is working