[SOLVED] Syntax Problem

[will35010]

I want to use echo instead of return in my function. I keep getting error about the syntax being wrong. It's saying the echo line is wrong.

function getDrivers1()
{
   $sql = "SELECT fname, lname, dl FROM drivers";

$rs = mysql_query($conn, $sql);

while($row = mysql_fetch_array($rs))
{
  echo "<option value=\"$row['dl']\">".$row['lname'].",".$row['fname']."</option>";
}

[anupamsaha]

Please change to:

 

echo "<option value=\"{$row['dl']}\">".$row['lname'].",".$row['fname']."</option>";

 

Or,

echo "<option value=\"" . $row['dl'] . "\">".$row['lname'].",".$row['fname']."</option>";

 

Whichever way you like.

 

[Ken2k7]

Read mysql_query. Put $conn after $sql in the parameters.

[will35010]

I keep getting error connecting to mysql. I know my $conn works, because my other scripts use it and it works. Here are the files:

 

functions.php

<?php

//db connection info
require('opendb.php');
require('config.php');

function getDrivers1()
{
   $sql = "SELECT fname, lname, dl FROM drivers";

$rs = mysql_query($sql, $conn);

while($row = mysql_fetch_array($rs))
{
  echo "<option value=\"" . $row['dl'] . "\">".$row['lname'].",".$row['fname']."</option>";
}
}

 

config.php:

<?php
//Database Settings
$dbhost = "localhost"; 
$dbuser = "root"; 
$dbpass = "test"; 
$dbname = "vehicles"; 
$prefix = ""; 
$user_prefix = ""; 
$dbtype = "MySQL"
?>

 

opendb.php

<?php
// This is opendb.php
$conn = mysqli_connect($dbhost, $dbuser, $dbpass, $dbname) or die        
                     ('Error connecting to mysql');
?>

 

I'm using <?php echo getDrivers1() ?> within the html to call the function. I also have a require function.php.

[will35010]

Read mysql_query. Put $conn after $sql in the parameters.

 

Thank you!