Jump to content

[SOLVED] Using function with onclick problem


fry2010

Recommended Posts

I dont no if this is a commen problem, but I have a function im calling inside a loop that is causing problems.

 

I can get it to work one way, but the way I need it to work doesnt.

 

This works:

 

    for(i = 0; i < array_length; i++)
    {
      link = document.getElementById(response[i]);
      link.onclick = self.challenge;     // SENDS TO FUNCTION BELOW
    }

    this.challenge = function()
    {
      var self = populate_arena;
      alert('OK');
    };

 

This works correctly, when I click on the element, the alert pops up 'OK'.

 

But when I try to send a value to the function such as the id of the element, the alert pops up straight away as it cycles through the loop. I dont even click on the element and it does it.

This is what I mean:

 

    for(i = 0; i < array_length; i++)
    {
      link = document.getElementById(response[i]);
      link.onclick = self.challenge(response[i]);    //NOW I PASS IT A VALUE..
    }

    this.challenge = function(str)
    {
      alert(str);
    };

 

what am I doing wrong?

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.