Jump to content

DB updates won't work but no errors

webweever

By webweever
in PHP Coding Help

 Share

Recommended Posts

webweever Member

webweever

Posted
Posted

I've been looking at my code for hours and can't find what the problem is. The form appears to work correctly but it does not update the data in the DB. I don't get any errors.

 

<html>
<head>
<title>Edit Marker</title>

<?php
include_once("../includes/db.php");

$marker_id = $_REQUEST['marker_id'];

$sql = "SELECT * FROM markers WHERE marker_id = '$marker_id'";

$result = MYSQL_QUERY($sql);
$numberOfRows = MYSQL_NUMROWS($result);
if ($numberOfRows==0) {  
?>

Sorry. No records found !!


</head>
<body>

<?php
}
else if ($numberOfRows>0) {

$i=0;
$marker_id = MYSQL_RESULT($result,$i,"marker_id");
$name = MYSQL_RESULT($result,$i,"name");
$street = MYSQL_RESULT($result,$i,"street");
$city = MYSQL_RESULT($result,$i,"city");
$state = MYSQL_RESULT($result,$i,"state");
$zip = MYSQL_RESULT($result,$i,"zip");
$url = MYSQL_RESULT($result,$i,"url");
$lat = MYSQL_RESULT($result,$i,"lat");
$lng = MYSQL_RESULT($result,$i,"lng");
$marker_cat = MYSQL_RESULT($result,$i,"marker_cat");
    $type = MYSQL_RESULT($result,$i,"type");
    $length = MYSQL_RESULT($result,$i,"length");
}
?>

<center><h1> Edit Marker</h1></center>
<form name="UpdateMarker" method="POST" action="<?php echo $_SERVER['PHP_SELF']?>">
  <table width="700" align="center" cellpadding="0" cellspacing="0">
 <tr> 
      <td width="308"><div align="right"><font style="font-size: .75em; font-family: verdana;" type="text"><b> </b></font></div></td>
      <td width="390"><input type="hidden" name="marker_id" value="<?php echo $marker_id; ?>"></td>
    </tr>
    <tr> 
      <td width="308"><div align="right"><font style="font-size: .75em; font-family: verdana;" type="text"><b>Name: </b></font></div></td>
      <td width="390"><input name="name" id="name" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $name; ?>"></td>
    </tr>
    <tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Street: </b></font></div></td>
      <td><input name="street" id="street" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $street; ?>"></td>
    </tr>
    <tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>City: </b></font></div></td>
      <td><input name="city" id="city" size="35"  style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $city; ?>"></td>
    </tr>
    <tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>State: </b></font></div></td>
      <td><input name="state" id="state" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $state; ?>"></td>
    </tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Zip: </b></font></div></td>
      <td><input name="zip" id="zip" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $zip; ?>"></td>
    </tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>URL: </b></font></div></td>
      <td><input name="url" id="url" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $url; ?>"></td>
    </tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Latitude: </b></font></div></td>
      <td><input name="lat" id="lat" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $lat; ?>"></td>
    </tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Longitude: </b></font></div></td>
      <td><input name="lng" id="lng" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $lng; ?>"></td>
    </tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Category: </b></font></div></td>
      <td><input name="marker_cat"  size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $marker_cat; ?>">
</tr>
         <tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Type: </b></font></div></td>
      <td><input name="type"  id="type" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $type; ?>">
</tr>
<tr> 
      <td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Length: </b></font></div></td>
      <td><input name="length"  id="length" size="35" style="font-size: .75em; font-family: verdana;"
type="text" value="<?php echo $length; ?>">
</tr>
<tr>
	<td><div align="right"><font style="font-size: .75em; font-family: verdana;"><b>Edit Category:</b></font></div></td>
	<td>
	<?php
$con = mysql_connect("localhost","root","");
if (!$con) {
	die('Could not connect: ' . mysql_error());
}

mysql_select_db("maps", $con) or die('Failed to select database');

$sql = "SELECT * FROM category";
$result = mysql_query($sql);
$options = "";

while ($row = mysql_fetch_array($result)) {
	$catname = $row['cat_name'];
	//$cat_id=$row["cat_id"];
	$options .= "<OPTION VALUE=\"$catname\">$catname</option>";
}

if (isset($_POST['list']) && is_array($_POST['list'])) {
	$items = implode(", ", $_POST['list']);

	$sql="UPDATE markers SET marker_id = '$marker_id' , name = '$name' , street = '$street' , city = '$city', state = '$state', 
		zip = '$zip', url = '$url', lat = '$lat', lng = '$lng', marker_cat = '$items', type = '$type', length = '$length'
		WHERE marker_id = '$marker_id'";

	if (!mysql_query($sql,$con)) {
		die('Error: ' . mysql_error());
	}


}
?>
<SELECT NAME="list[]" size="8" multiple style="width:150px;" ><?php echo $options?></SELECT>
</td>		 
    </tr>
    <tr> 
      <td><br/><br/></td>
      <td>
	<div align="left"> 
          <input type="submit" name="submitmarker" value="Submit">
          <input type="reset" name="resetForm" value="Clear Form">
        </div>
   </td>
    </tr>
  </table>
  <center><a href="admin.php">Back to Admin Page</a></center>
  
  </body>
  </html>
  <?php
  }
  mysql_close($con);
  ?>

Link to comment
https://forums.phpfreaks.com/topic/163206-db-updates-wont-work-but-no-errors/
Share on other sites
PFMaBiSmAd Advanced Member

PFMaBiSmAd

Posted
Posted

You need to logically organize your code into separate bocks. One block responsible for processing the form and one block responsible for producing the form. You also need to add conditional logic so that your form processing code is only executed when your form has been submitted and conditional logic so that your form is only produced and displayed when you want it to be.

 

Your current code is unconditionally executing the first SELECT query and setting all the $marker_id, $name, $street, .... program variables from the query. These program variables are being used in the UPDATE query later and in fact except for $_POST['list'], there is no code present that is using any of the other $_POST variables from the form in the UPDATE query at all.

 

In pseudo code, you should be doing something like this -

 

if(form_submitted){
... form processing code
}

if(!form_submitted || there_are_form_validation_errors){
... form code
}

webweever Member

webweever

Posted
  • Author
Posted

Ok, I rehacked this thing out. It works, am I leaving anything out?

 

edit.php

<link rel="stylesheet" type="text/css" href="../css/style.css" />
<?php
include_once("../includes/db.php");
// Catch the passed in Marker ID
$marker_id = ($_GET['marker_id']);

if (!isset($_GET['marker_id'])) {
die("No marker id found");
} else {

//Code to pull the marker from the DB 
   //display the marker to be edited
   $result = mysql_query("SELECT * FROM markers WHERE marker_id = '$marker_id'"); 
   
   //run the while loop that grabs the marker based on the marker_id
   while($row=mysql_fetch_array($result)) 
   { 
      //grab all the info for the marker
      $marker_id=$row["marker_id"];//Marker_id from the DB
      $name=$row["name"];//Name from the DB
  $street=$row["street"];//Street from the DB
  $city=$row["city"];//City from the DB
  $state=$row["state"];//State from the DB
  $zip=$row["zip"];//Zip from the DB
  $url=$row["url"];//Url from the DB
  $lat=$row["lat"];//Lat from the DB
  $lng=$row["lng"];//Lng from the DB
  $type=$row["type"];//Type from the DB
  $length=$row["length"];//Length from the DB
  $marker_cat=$row["marker_cat"];//Current Category from the DB
    }
?>
<!-- End Code to pull marker values from the DB -->
<!-- Create the form populated with the values from the DB -->
<form action="update.php" method="post">
<span class="text"><b>Marker ID:<br>
	<INPUT TYPE="TEXT" NAME="marker_id" VALUE="<?php echo $marker_id; ?>" SIZE=50><br>
Name:<br>
	<INPUT TYPE="TEXT" NAME="name" VALUE="<?php echo $name ?>" SIZE=50><br>
Street:<br>
	<INPUT TYPE="TEXT" NAME="street" VALUE="<?php echo $street?>" SIZE=50><br>
City:<br>
	<INPUT TYPE="TEXT" NAME="city" VALUE="<?php echo $city?>" SIZE=50><br>
State:<br>
	<INPUT TYPE="TEXT" NAME="state" VALUE="<?php echo $state?>" SIZE=50><br>
Zip:<br>
	<INPUT TYPE="TEXT" NAME="zip" VALUE="<?php echo $zip?>" SIZE=50><br>
URL:<br>
	<INPUT TYPE="TEXT" NAME="url" VALUE="<?php echo $url?>" SIZE=50><br>
Latitude:<br>
	<INPUT TYPE="TEXT" NAME="lat" VALUE="<?php echo $lat?>" SIZE=50><br>
Longitude:<br>
	<INPUT TYPE="TEXT" NAME="lng" VALUE="<?php echo $lng?>" SIZE=50><br>
Type:<br>
	<INPUT TYPE="TEXT" NAME="type" VALUE="<?php echo $type?>" SIZE=50><br>
Length:<br>
	<INPUT TYPE="TEXT" NAME="length" VALUE="<?php echo $length?>" SIZE=50><br>
Category:<br>
	<INPUT TYPE="TEXT" NAME="marker_cat" VALUE="<?php echo $marker_cat?>" SIZE=50><br>
Created Date:</b></span><br>
	<INPUT TYPE="TEXT" NAME="created_date" VALUE="<?php echo date ("Y-m-j");?>" SIZE=50><br>
<input type="submit" name="submitmarker" value="Submit"><input type="reset" name="resetForm" value="Clear Form">
</form>
<?php
}
?>
<a href="admin.php">Back to list</a> 

 

update.php

<link rel="stylesheet" type="text/css" href="../css/style.css" />
<span class="text">
<?php require("../includes/db.php");
	$marker_id = mysql_real_escape_string($_POST["marker_id"]);
	$name = mysql_real_escape_string($_POST["name"]);
	$street = mysql_real_escape_string($_POST["street"]);
	$city = mysql_real_escape_string($_POST["city"]);
	$state = mysql_real_escape_string($_POST["state"]);
	$zip = mysql_real_escape_string($_POST["zip"]);
	$url = mysql_real_escape_string($_POST["url"]);
	$lat = mysql_real_escape_string($_POST["lat"]);
	$lng = mysql_real_escape_string($_POST["lng"]);
	$type = mysql_real_escape_string($_POST["type"]);
	$length = mysql_real_escape_string($_POST["length"]);
	$marker_cat = mysql_real_escape_string($_POST["marker_cat"]);
	$created_date = mysql_real_escape_string($_POST["created_date"]);

	$sql = "UPDATE markers SET marker_id = '$marker_id' , name = '$name' , street = '$street' , city = '$city', state = '$state', 
		zip = '$zip', url = '$url', lat = '$lat', lng = '$lng', marker_cat = '$marker_cat', type = '$type', length = '$length', created_date = '$created_date'
		WHERE marker_id = '$marker_id'";

	mysql_query($sql) or die ("Error: ".mysql_error()); 
      echo "Thank you! Information updated.";
?>
<br><br>

<?php
echo $marker_id. '<br>';
echo $name.'<br>';
echo $city.'<br>';
echo $state.'<br>';
echo $zip.'<br>';
echo $url.'<br>';
echo $lat.'<br>';
echo $lng.'<br>';
echo $marker_cat.'<br>';
echo $type.'<br>';
echo $length.'<br>';
echo $created_date;
?>
<br>
<a href="admin.php">Back to list</a>
</span>

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.